search

opensearch-project / helm-charts

:wheel_of_dharma: A community repository for Helm Charts of OpenSearch Project.
https://opensearch.org/docs/latest/opensearch/install/helm/
Apache License 2.0
170 stars 228 forks source link

[Testing Confirmation] Confirm current testing requirements #385

Open stephen-crawford opened 1 year ago

stephen-crawford commented 1 year ago

As part of the discussion around implementing an organization-wide testing policy, I am visiting each repo to see what tests they currently perform. I am conducting this work on GitHub so that it is easy to reference.

Looking at the Helm Charts repository, it appears there is

Repository Unit Tests Integration Tests Backwards Compatibility Tests Additional Tests Link
Helm Charts
  • - [x]
  • - [x]
  • - [ ]
    		• Lint Checker https://github.com/opensearch-project/helm-charts/issues/385

    I don't see any requirements for code coverage in the testing documentation. If there are any specific requirements could you respond to this issue to let me know?

    If there are any tests I missed or anything you think all repositories in OpenSearch should have for testing please respond to this issue with details.

    prudhvigodithi commented 1 year ago

    [Triage] Hey @scrawfor99 the link posted is not working, can you double check? Also I see the CI has the testing workflows that checks with multiple k8s versions and with one OpenSearch and Dashboard version (the latest released one) https://github.com/opensearch-project/helm-charts/blob/main/.github/workflows/lint-test.yaml. So technically all tests do exists. The BWC tests might not be exact BWC test as how the OpenSearch is using, but for helm charts we have 2 branches 1.x and main that tracks each isolated helm chart compatible for each major version. @bbarani @peterzhuamazon @TheAlgo @DandyDeveloper

    stephen-crawford commented 1 year ago

    Hi @prudhvigodithi, thank you for your response. I corrected the link. It is just a link to this issue though so it won't take you anywhere. Good catch however. I will update the notes to show you do have BWC tests, apologies for missing that. If there is anything else you would like addressed or any suggestions you have please let me know.