opensearch-project / helm-charts

:wheel_of_dharma: A community repository for Helm Charts of OpenSearch Project.
https://opensearch.org/docs/latest/opensearch/install/helm/
Apache License 2.0
176 stars 236 forks source link

[BUG][Opensearch] init container missing pull policy #611

Closed anna-intellegens closed 3 days ago

anna-intellegens commented 1 month ago

Describe the bug Persistence init container doesn't have a pull policy defined, meaning it defaults to Always, causing it to error on offline deployments

To Reproduce Steps to reproduce the behavior:

  1. Import all required images to a local machine running kubernetes without external network connection
  2. Deploy helm chart with persistence enabled and image.pullPolicy = "Never" set in values.yaml
  3. Opensearch fails to start with ErrImagePull and ImagePullBackOff due to persistence init container

Expected behavior Persistence init container should respect pull policy specified in image.pullPolicy similar to other init containers (such as sysctlInit)

Chart Name Opensearch v1.x charts

Screenshots If applicable, add screenshots to help explain your problem.

Host/Environment (please complete the following information):

prudhvigodithi commented 1 month ago

[Triage] Thanks @anna-intellegens for opening a PR, we can get the PR reviewed and merged. @peterzhuamazon

bshien commented 3 days ago

Since the PR got merged, will go ahead and close the issue. Feel free to reopen if there are any issues.