search

opensearch-project / neural-search

Plugin that adds dense neural retrieval into the OpenSearch ecosytem
Apache License 2.0
64 stars 67 forks source link

[Testing Confirmation] Confirm current testing requirements #124

Open stephen-crawford opened 1 year ago

stephen-crawford commented 1 year ago

As part of the discussion around implementing an organization-wide testing policy, I am visiting each repo to see what tests they currently perform. I am conducting this work on GitHub so that it is easy to reference.

Looking at the Neural Search repository, it appears there is

Repository Unit Tests Integration Tests Backwards Compatibility Tests Additional Tests Link
Neural Search
  • - [x]
  • - [x]
  • - [ ]
    		• Certificate of Origin, Link Checker, Benchmarking Tool (in progress) https://github.com/opensearch-project/neural-search/issues/124

    I don't see any requirements for code coverage in the testing documentation. If there are any specific requirements could you respond to this issue to let me know?

    If there are any tests I missed or anything you think all repositories in OpenSearch should have for testing please respond to this issue with details.

    navneet1v commented 1 year ago

    We are working on adding the perf test benchmarks using OpenSearch Benchmark tool for this plugin too. Issue: https://github.com/opensearch-project/neural-search/issues/34

    Right now we don't need BWC tests, but we will be adding BWC tests soon in this repo.

    I don't see any requirements for code coverage in the testing documentation.

    Ideally we would want code coverage for this repo. but right now we have not enabled it.

    stephen-crawford commented 1 year ago

    Hi @navneet1v, sorry that I overlooked those details. There are a lot of these issues some sometimes I miss a few intricacies. Thank you for following up. I will be sure to update the notes to reflect what you mentioned.

    zelinh commented 1 year ago

    Created a new issue to keep track of the BWC tests #202

    martin-gaievski commented 3 months ago

    @stephen-crawford is there any required part that is missing for neural-search repo, or we can close this issue?