dblock commented 2 weeks ago

Description

We already have index mapping tests in https://github.com/opensearch-project/opensearch-api-specification/blob/main/tests/default/indices/mapping.yaml, so no need to duplicate them under core.
Added FlatObjectProperty index mapping returned in .opensearch-observability.
Added a test to get mappings for all indices, seems to not run into #384 anymore.

Issues Resolved

Closes #384.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

github-actions[bot] commented 2 weeks ago

Changes Analysis

Commit SHA: 84bab06f2c535212e879a9fa65f4702bc801ae30 Comparing To SHA: 62f1f5f7418f48ee8002f2833eb58043ab47d82e

API Changes

Summary

└─┬Components
  ├──[➕] schemas (39154:7)
  └─┬_common.mapping___Property
    ├──[➕] oneOf (39120:7)
    ├─┬ONEOF
    │ └──[🔀] $ref (39155:9)❌ 
    ├─┬ONEOF
    │ └──[🔀] $ref (39995:9)❌ 
    ├─┬ONEOF
    │ └──[🔀] $ref (39200:9)❌ 
    ├─┬ONEOF
    │ └──[🔀] $ref (39045:9)❌ 
    ├─┬ONEOF
    │ └──[🔀] $ref (39214:9)❌ 
    ├─┬ONEOF
    │ └──[🔀] $ref (39812:9)❌ 
    ├─┬ONEOF
    │ └──[🔀] $ref (38967:9)❌ 
    ├─┬ONEOF
    │ └──[🔀] $ref (38879:9)❌ 
    ├─┬ONEOF
    │ └──[🔀] $ref (38991:9)❌ 
    ├─┬ONEOF
    │ └──[🔀] $ref (39413:9)❌ 
    ├─┬ONEOF
    │ └──[🔀] $ref (39548:9)❌ 
    ├─┬ONEOF
    │ └──[🔀] $ref (40025:24)❌ 
    ├─┬ONEOF
    │ └──[🔀] $ref (39484:9)❌ 
    └─┬ONEOF
      └──[🔀] $ref (39984:9)❌

Document Element	Total Changes	Breaking Changes
components	16	14

❌ BREAKING Changes: 14 out of 16
Modifications: 14
Additions: 2
Breaking Modifications: 14

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/11779944286/artifacts/2171498248

API Coverage

	Before	After	Δ
Covered (%)	588 (57.59 %)	588 (57.59 %)	0 (0 %)
Uncovered (%)	433 (42.41 %)	433 (42.41 %)	0 (0 %)
Unknown	40	40	0