Open tlfeng opened 1 year ago
[Triage] @gkamat Can you looks into this? Thanks!
We will address this shortly.
@gkamat @IanHoang I had a proposed code change to resolve the issue in PR https://github.com/opensearch-project/opensearch-benchmark-workloads/pull/82, but I closed it. Noticed you are refactoring the benchmark workload, I don't want to disturb your plan by adding massive code change. I can open the PR again when you want to deal with this problem, or that's fine if you want to make code changes for this issue by yourself. 😁
@gkamat has made some recent changes to percolator and PMC workloads. For future workloads, we can follow the convention he applied:
Is your feature request related to a problem?
Code duplication is introduced by the PR https://github.com/opensearch-project/opensearch-benchmark-workloads/pull/47
The below is the redundant code, which exists in the test procedure definition file for all datasets.
What solution would you like?
By using macros syntax, like commit https://github.com/opensearch-project/opensearch-benchmark-workloads/pull/58/commits/2a7138d050b645a0204334ad9f0a252d2b494889, to reuse the common codes in every file.
What alternatives have you considered?
Put the common codes in a separate file for reusing.
Do you have any additional context?
Coming from https://github.com/opensearch-project/opensearch-benchmark-workloads/pull/58#discussion_r1125144180