[OSB 2.0.0] Reassess renamed-component changes

IanHoang commented 4 months ago

Describe the bug

It's been a while since we've checked the renamed components. @beaioun, @cgchinmay, and I will be gathering changes from the renaming-components and rename-provision branch and place them on top of most recent mainline changes.

We'll then test the current changes to ensure they work before proceeding to add other renamed component changes.

To reproduce

[ ] Add previous changes on top of recent mainline changes
[ ] Test current changes

beaioun commented 4 months ago

@IanHoang I will start working on testing over the weekends

IanHoang commented 3 months ago

Testing Changes in Renamed Components Branch

If cluster-configs and opensearch-plugins are not listable, update the benchmark.ini to use the following

[cluster_configs]
default.dir = default-cluster-config

IanHoang commented 3 months ago

Reproduce Renamed Components Branch Setup

Git clone the repository https://github.com/IanHoang/opensearch-benchmark/tree/renamed-components
Run make install
Run source .venv/bin/activate
Run python3 -m pip install -e .

cgchinmay commented 3 months ago

Hi @IanHoang I am not seeing any issues. Here are the steps I tried. did not make any changes to bechmark.ini. Let me know if I am missing something

1. git clone https://github.com/opensearch-project/opensearch-benchmark.git

2. git checkout -b local-renaming-components origin/renaming-components

3. make prereq

4. make install

5. source .venv/bin/activate

6. python3 -m pip install -e .

7. opensearch-benchmark list cluster-configs 

Available cluster-configs:

Name                  Type            Description
--------------------  --------------  --------------------------------------
16gheap               cluster-config  Sets the Java heap to 16GB
1gheap                cluster-config  Sets the Java heap to 1GB
24gheap               cluster-config  Sets the Java heap to 24GB
2gheap                cluster-config  Sets the Java heap to 2GB
4gheap                cluster-config  Sets the Java heap to 4GB
8gheap                cluster-config  Sets the Java heap to 8GB
defaults              cluster-config  Sets the Java heap to 1GB
basic-license         mixin           Basic License
debug-non-safepoints  mixin           More accurate CPU profiles
ea                    mixin           Enables Java assertions
fp                    mixin           Preserves frame pointers
g1gc                  mixin           Enables the G1 garbage collector
parallelgc            mixin           Enables the Parallel garbage collector
trial-license         mixin           Trial License
unpooled              mixin           Enables Netty's unpooled allocator

8. cat osbenchmark/resources/benchmark.ini

[meta]
config.version = 17

[system]
env.name = local

[node]
root.dir = ${CONFIG_DIR}/benchmarks
src.root.dir = ${CONFIG_DIR}/benchmarks/src

[source]
remote.repo.url = https://github.com/opensearch-project/OpenSearch.git
opensearch.src.subdir = opensearch

[benchmarks]
local.dataset.cache = ${CONFIG_DIR}/benchmarks/data

[results_publishing]
datastore.type = in-memory
datastore.host =
datastore.port =
datastore.secure = False
datastore.user =
datastore.password =

[workloads]
default.url = https://github.com/opensearch-project/opensearch-benchmark-workloads

[provision_configs]
default.dir = default-provision-config

[defaults]
preserve_benchmark_candidate = false

[distributions]
release.cache = true

IanHoang commented 1 month ago

Will need to commit to a release date for this. Will work closely with maintainers to finalize on this.

opensearch-project / opensearch-benchmark