search

opensearch-project / opensearch-benchmark

OpenSearch Benchmark - a community driven, open source project to run performance tests for OpenSearch
https://opensearch.org/docs/latest/benchmark/
Apache License 2.0
112 stars 79 forks source link

change min/max to overall_min/overall_max + update comparison results publisher #687

Closed OVI3D0 closed 2 weeks ago

OVI3D0 commented 1 month ago

Description

This change updates min/max values in aggregated results to reflect the min/max values across all test executions, rather than just an average of the min/max values. I also changed the names from min and max to overall_min and overall_max for clarity. Changes were also made to the comparison results publisher class, so if an aggregated result with these new metrics were to be used in a comparison, these new 'overall' min and max values can still be compared without issue.

Issues Resolved

684

Testing

make test

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

OVI3D0 commented 2 weeks ago

Could you add tests to results_publisher to confirm the changes work?

I added a test for this, but let me know if I should add more!

I also updated the unit tests for the aggregator class.