opensearch-project / opensearch-build

🧰 OpenSearch / OpenSearch-Dashboards Build Systems
Apache License 2.0
132 stars 260 forks source link

[RELEASE] Release version 2.12.0 #4115

Closed github-actions[bot] closed 4 months ago

github-actions[bot] commented 8 months ago

Release OpenSearch and OpenSearch Dashboards 2.12.0

I noticed that a manifest was automatically created in manifests/2.12.0. Please follow the following checklist to make a release.

How to use this issue

## This Release Issue This issue captures the state of the OpenSearch release, its assignee (Release Manager) is responsible for driving the release. Please contact them or @mention them on this issue for help. There are linked issues on components of the release where individual components can be tracked. For more information check the the [Release Process OpenSearch Guide](https://github.com/opensearch-project/opensearch-build/blob/main/RELEASE_PROCESS_OPENSEARCH.md).

Please refer to the following link for the release version dates: Release Schedule and Maintenance Policy.

Entrance Criteria

Criteria Status Description Comments
Documentation draft PRs are up and in tech review for all component changes :green_circle: https://github.com/opensearch-project/opensearch-build/issues/4115#issuecomment-1930888627
Sanity testing is done for all components :green_circle:
Release notes are ready and available for all components :green_circle: OS Components,
OSD Components
Roadmap is up-to-date (information is available to create release highlights) :green_circle:
Release ticket is cut :green_circle:
Any necessary security reviews are complete :green_circle:

OpenSearch 2.12.0 exit criteria status:

Criteria Status Description Comments
Performance tests are run, results are posted to the release ticket and there no unexpected regressions :green_circle: https://github.com/opensearch-project/opensearch-build/issues/4115#issuecomment-1944501520
No unpatched vulnerabilities of medium or higher severity that have been publicly known for more than 60 days :green_circle:
Documentation has been fully reviewed and signed off by the documentation community. :green_circle: https://github.com/opensearch-project/opensearch-build/issues/4115#issuecomment-1952852216
All integration tests are passing :green_circle: Integration Failures Open Issues Manual sign off from comment.
Release blog is ready :green_circle: https://github.com/opensearch-project/opensearch-build/issues/4115#issuecomment-1952852216

OpenSearch-Dashboards 2.12.0 exit criteria status:

Criteria Status Description Comments
Documentation has been fully reviewed and signed off by the documentation community :green_circle: https://github.com/opensearch-project/opensearch-build/issues/4115#issuecomment-1952852216
No unpatched vulnerabilities of medium or higher severity that have been publicly known for more than 60 days :green_circle:
All integration tests are passing :green_circle: Integration Failures Open Issues Manual sign off from comment
Release blog is ready :green_circle: https://github.com/opensearch-project/opensearch-build/issues/4115#issuecomment-1952852216

Preparation

Campaigns

Release Branch and Version Increment - End of February 4th, 2024

Feature Freeze - End of February 5th, 2024

Code Complete - End of February 5th, 2024

Release Candidate Creation and Testing - First RC Generated (release window opens) on February 6th, 2024

Performance testing validation - End of February 17th, 2024

Pre Release - End of February 20th, 2024

Release - February 20th, 2024

Release Checklist.


Release Checklist

### Pre-Release activities - [x] Promote Repos. - - [x] OS https://build.ci.opensearch.org/job/distribution-promote-repos/95/console https://build.ci.opensearch.org/job/distribution-promote-repos/96/console - - [x] OSD https://build.ci.opensearch.org/job/distribution-promote-repos/97/console https://build.ci.opensearch.org/job/distribution-promote-repos/98/console - [x] Promote Artifacts. - - [x] Windows OS: https://build.ci.opensearch.org/job/distribution-promote-artifacts/396/console OSD: https://build.ci.opensearch.org/job/distribution-promote-artifacts/397/console - - [x] Linux Debian - - [x] OS: https://build.ci.opensearch.org/job/distribution-promote-artifacts/398/console https://build.ci.opensearch.org/job/distribution-promote-artifacts/399/console - - [x] OSD: https://build.ci.opensearch.org/job/distribution-promote-artifacts/400/console https://build.ci.opensearch.org/job/distribution-promote-artifacts/401/console - - [x] Linux RPM - - [x] OS: https://build.ci.opensearch.org/job/distribution-promote-artifacts/402/console https://build.ci.opensearch.org/job/distribution-promote-artifacts/403/console - - [x] OSD: https://build.ci.opensearch.org/job/distribution-promote-artifacts/404/console https://build.ci.opensearch.org/job/distribution-promote-artifacts/405/console - - [x] Linux TAR - - [x] OS: https://build.ci.opensearch.org/job/distribution-promote-artifacts/408/console https://build.ci.opensearch.org/job/distribution-promote-artifacts/409/console - - [x] OSD: https://build.ci.opensearch.org/job/distribution-promote-artifacts/406/console https://build.ci.opensearch.org/job/distribution-promote-artifacts/407/console - [x] Consolidated Release Notes. https://github.com/opensearch-project/opensearch-build/pull/3803 ### Release activities - [x] Docker Promotion: https://build.ci.opensearch.org/job/docker-promotion/62/console - [x] Release Validation part 1. - - [x] OpenSearch and OpenSearch Dashboard Validation. - - [x] Validate the native plugin installation. - [x] Merge consolidated release notes PR. - [x] Website and Documentation Changes. - - [x] Merge staging website PR. - - [x] Promote the website changes to prod. - - [x] Add website alert. - [x] Release Validation part 2. - - [x] Validate the artifact download URL's and signatures. - [x] Release Validation part 3. - - [x] Trigger the validation build (Search for `Completed validation for <>` in the logs). - [x] Maven Promotion: https://build.ci.opensearch.org/job/publish-to-maven/28/ - [x] Publish blog posts. - [x] Advertise on Social Media. - [x] Post on public slack and Github Release issue. ### Post-Release activities - [x] Release Tags. https://build.ci.opensearch.org/job/distribution-release-tag-creation/98/console https://build.ci.opensearch.org/job/distribution-release-tag-creation/99/console https://build.ci.opensearch.org/job/distribution-release-tag-creation/100/ - [x] Input Manifest Update: https://github.com/opensearch-project/opensearch-build/pull/4467/files - [x] Decrease the Build Frequency. - [x] OpenSearch Build Release notes: https://github.com/opensearch-project/opensearch-build/releases/tag/2.12.0 - [x] Retrospective Issue: https://github.com/opensearch-project/opensearch-build/issues/4454 - [x] Helm and Ansible Playbook release. https://github.com/opensearch-project/helm-charts/pull/518 https://github.com/opensearch-project/ansible-playbook/pull/153 - [x] Upcoming Release Preparation: This process is automated as the version increment PR's, release issues are created by automated workflows.


Post Release

Components

OpenSearch

Component Issues tagged with 2.12.0
https://github.com/opensearch-project/OpenSearch/issues/10517
https://github.com/opensearch-project/common-utils/issues/548
https://github.com/opensearch-project/k-NN/issues/1224
https://github.com/opensearch-project/geospatial/issues/543
https://github.com/opensearch-project/security/issues/3513
https://github.com/opensearch-project/cross-cluster-replication/issues/1242
https://github.com/opensearch-project/ml-commons/issues/1471
https://github.com/opensearch-project/neural-search/issues/424
https://github.com/opensearch-project/notifications/issues/782
https://github.com/opensearch-project/observability/issues/1725
https://github.com/opensearch-project/reporting/issues/884
https://github.com/opensearch-project/sql/issues/2269
https://github.com/opensearch-project/asynchronous-search/issues/478
https://github.com/opensearch-project/anomaly-detection/issues/1079
https://github.com/opensearch-project/alerting/issues/1243
https://github.com/opensearch-project/security-analytics/issues/653
https://github.com/opensearch-project/index-management/issues/997
https://github.com/opensearch-project/performance-analyzer/issues/580
https://github.com/opensearch-project/flow-framework/issues/414

OpenSearch Dashboards

Component Issues tagged with 2.12.0
https://github.com/opensearch-project/OpenSearch-Dashboards/issues/5257
https://github.com/opensearch-project/opensearch-dashboards-functional-test/issues/914
https://github.com/opensearch-project/dashboards-observability/issues/1104
https://github.com/opensearch-project/dashboards-reporting/issues/207
https://github.com/opensearch-project/dashboards-visualizations/issues/265
https://github.com/opensearch-project/dashboards-query-workbench/issues/152
https://github.com/opensearch-project/dashboards-maps/issues/521
https://github.com/opensearch-project/anomaly-detection-dashboards-plugin/issues/619
https://github.com/opensearch-project/ml-commons-dashboards/issues/275
https://github.com/opensearch-project/index-management-dashboards-plugin/issues/894
https://github.com/opensearch-project/dashboards-notifications/issues/128
https://github.com/opensearch-project/alerting-dashboards-plugin/issues/758
https://github.com/opensearch-project/security-analytics-dashboards-plugin/issues/751
https://github.com/opensearch-project/security-dashboards-plugin/issues/1606
https://github.com/opensearch-project/dashboards-search-relevance/issues/321
https://github.com/opensearch-project/dashboards-assistant/issues/100

Documentation

Component Issues tagged with 2.12.0
https://github.com/opensearch-project/documentation-website/
Legend

| Symbol | Meaning | | -------- | ---------- | | :green_circle: | On track with overall release | | :yellow_circle: | Missed last milestone | | :red_circle: | Missed multiple milestones |

derek-ho commented 6 months ago

This should also be added to exit criteria for 2.12.0 release: https://github.com/opensearch-project/security/issues/3624

prudhvigodithi commented 6 months ago

2.12.0 release dates will be finalized based on the discussion part of the issue https://github.com/opensearch-project/opensearch-build/issues/4290. Thank you

prudhvigodithi commented 6 months ago

The release calendar is updated and 2.12.0 is scheduled to February 20th, 2024, I have updated the issue details with all the release timelines. The First RC will be Generated on February 6th, 2024. Thanks

zelinh commented 5 months ago

Noticed a build issue with flow-framework plugin for 2.12.0. https://github.com/opensearch-project/flow-framework/issues/410 cc: @prudhvigodithi

peterzhuamazon commented 5 months ago

All IntegTest issues and PRs here:

hdhalter commented 5 months ago

Documentation update: We are RED for the RC with 2 PRs outstanding:

Update 2/14: Documentation is GREEN. We have PRs up for all 2.12 features: 44 PRs completed and merged; 4 PRs in final review stages.

prudhvigodithi commented 4 months ago

1st RC build and results - 02/06/2024

🔴 OpenSearch: https://build.ci.opensearch.org/job/distribution-build-opensearch/9353/console

OpenSearch Failed components: performance-analyzer, skills

🟢 OpenSearch Dashboard: https://build.ci.opensearch.org/job/distribution-build-opensearch-dashboards/7242/console

Components Integ test failures: https://github.com/issues?q=is%3Aopen+is%3Aissue+user%3Aopensearch-project+label%3Av2.12.0+label%3Aautocut+%5BAUTOCUT%5D+integration+in%3Atitle+

bowenlan-amzn commented 4 months ago

Backport 2 PRs into 2.12 https://github.com/opensearch-project/OpenSearch/pull/11505 https://github.com/opensearch-project/OpenSearch/pull/12073 their commits on 2.12 branch eafa41651ffc1610a0de267d5915e0bec4db9064 a9c03c2d08051dc3f8e5f8c7920473e53d0d2752

prudhvigodithi commented 4 months ago

2nd RC build and results - 02/07/2024

OpenSearch: https://build.ci.opensearch.org/blue/organizations/jenkins/distribution-build-opensearch/detail/distribution-build-opensearch/9358/pipeline

🟢 OpenSearch Dashboards: https://build.ci.opensearch.org/blue/organizations/jenkins/distribution-build-opensearch[…]il/distribution-build-opensearch-dashboards/7246/pipeline

OS Distribution build Failed components OpenSearch: https://github.com/opensearch-project/OpenSearch/issues/12242 PA: https://github.com/opensearch-project/performance-analyzer/issues/611

Integ test failures: https://github.com/issues?q=is%3Aopen+is%3Aissue+user%3Aopensearch-project+label%3Av2.12.0+label%3Aautocut+%5BAUTOCUT%5D+Integration+in%3Atitle+

opensearch-ci-bot commented 4 months ago

OpenSearch CommitID(after 2023-11-30) & Release Notes info

Repo Branch CommitID Commit Date Release Notes Exists
alerting [2.12] d4f1675 2024-02-08 True
anomaly-detection [2.12] 24c7000 2024-02-09 True
asynchronous-search [2.12] 169fc30 2024-02-14 True
common-utils [2.12] b10a9dd 2024-02-06 True
cross-cluster-replication [2.12] 72c504f 2024-02-12 True
custom-codecs [2.12] 36ad850 2024-02-08 True
flow-framework [2.12] 987b96f 2024-02-09 True
geospatial [2.12] c9ea964 2024-02-08 True
index-management [2.12] f252d63 2024-02-09 True
job-scheduler [2.12] e5e9673 2024-02-09 True
k-NN [2.12] e7a9192 2024-02-08 True
ml-commons [2.12] cbd16d3 2024-02-13 True
neural-search [2.12] a521f78 2024-02-07 True
notifications [2.12] f72ce4a 2024-02-07 True
opensearch-observability [2.12] 7848617 2024-02-10 True
opensearch-reports [2.12] b9d9d99 2024-02-13 True
performance-analyzer [2.12] f2d6b0b 2024-02-12 True
security [2.12] a5c3191 2024-02-09 True
security-analytics [2.12] fca29cf 2024-02-06 True
skills [2.12] 5f3f8ac 2024-02-09 True
sql [2.12] 1848d86 2024-02-06 True
opensearch-ci-bot commented 4 months ago

OpenSearch Dashboards CommitID(after 2023-11-30) & Release Notes info

Repo Branch CommitID Commit Date Release Notes Exists
alertingDashboards [2.12] 9e94502 2024-02-12 True
anomalyDetectionDashboards [2.12] 99ed917 2024-02-13 True
assistantDashboards [2.12] bfe6fb9 2024-02-14 True
customImportMapDashboards [2.12] c3331e1 2024-02-07 True
functionalTestDashboards [2.12] 87ae255 2024-02-07 False
ganttChartDashboards [2.12] 8693f72 2024-02-09 True
indexManagementDashboards [2.12] 28530a0 2024-02-14 True
mlCommonsDashboards [2.12] d28607d 2024-02-04 True
notificationsDashboards [2.12] ac4b533 2024-02-13 True
observabilityDashboards [2.12] 2f19852 2024-02-13 True
queryWorkbenchDashboards [2.12] ac68ded 2024-02-09 True
reportsDashboards [2.12] 0bf4a26 2024-02-13 True
searchRelevanceDashboards [2.12] 8838be9 2024-02-08 True
securityAnalyticsDashboards [2.12] 1eb6894 2024-02-14 True
securityDashboards [2.12] d36297f 2024-02-09 True
hdhalter commented 4 months ago

Documentation update: RED

prudhvigodithi commented 4 months ago

Release update 02/08/2024

Hey everyone, we cant move forward with the RC generation as multiple components missing the release notes (which does not meet the entrance criteria) and performance-analyzer and skills are still failing to build, repo owners please fix them soon without them fixed we cant move forward with the RC generation and might cause in delaying the 2.12.0 release.

OpenSearch components missing release notes

https://github.com/opensearch-project/opensearch-build/issues/4115#issuecomment-1933165208

OpenSearch Dashboards components missing release notes

https://github.com/opensearch-project/opensearch-build/issues/4115#issuecomment-1933165762

Thanks

bbarani commented 4 months ago

Release update 02/08/2024

Hey everyone, we cant move forward with the RC generation as multiple components missing the release notes (which does not meet the entrance criteria) and performance-analyzer and skills are still failing to build, repo owners please fix them soon without them fixed we cant move forward with the RC generation and might cause in delaying the 2.12.0 release.

OpenSearch components missing release notes

#4115 (comment)

OpenSearch Dashboards components missing release notes

#4115 (comment)

Thanks

@psychbot @zane-neo @khushbr Take action to resolve the build issues with PA and Skills repo as soon as possible.

bbarani commented 4 months ago

The below items are still open for Documentation.

One PR to be created for Metrics Framework: [DOC] Metrics Framework documentation-website#6338

Several PRs in tech or doc are still in review: https://github.com/opensearch-project/documentation-website/pulls?q=is%3Aopen+is%3Apr+label%3Av2.12.0

CC: @prudhvigodithi @hdhalter

prudhvigodithi commented 4 months ago

3rd RC build blockers - 02/09/2024

performance-analyzer build failure's https://github.com/opensearch-project/performance-analyzer/issues/611

Pending PR's to merge that will fix the performance-analyzer build failure's https://github.com/opensearch-project/performance-analyzer/pull/627, https://github.com/opensearch-project/performance-analyzer/pull/628

Pending PR's to merge performance-analyzer-rca (performance-analyzer clones RCA during build): https://github.com/opensearch-project/performance-analyzer-rca/pull/533

Missing release notes: https://github.com/opensearch-project/opensearch-build/issues/4115#issuecomment-1933165208 https://github.com/opensearch-project/opensearch-build/issues/4115#issuecomment-1933165762

3rd RC build blockers - 02/09/2024 (4PM PT)

Hey everyone, we cant move forward with the RC generation as multiple components missing the release notes which does not meet the entrance criteria.

OpenSearch components missing release notes https://github.com/opensearch-project/opensearch-build/issues/4115#issuecomment-1933165208 asynchronous-search opensearch-observability opensearch-reports performance-analyzer

OpenSearch Dashboards components missing release notes https://github.com/opensearch-project/opensearch-build/issues/4115#issuecomment-1933165762 alertingDashboards ganttChartDashboards notificationsDashboards observabilityDashboards reportsDashboards securityAnalyticsDashboards

Thanks

prudhvigodithi commented 4 months ago

4th RC OpenSearch 9396 / OpenSearch Dashboards 7278 - 02/12/2024.

We cant finalize this RC build due to missing release notes which does not meet the release notes readiness.

OpenSearch - Build 9396 OpenSearch Dashboards - Build 7278

Check how to install opensearch and dashboards on different platforms

Please note the following components release notes are still missing.

OpenSearch components missing release notes

https://github.com/opensearch-project/opensearch-build/issues/4115#issuecomment-1933165208 asynchronous-search opensearch-reports

OpenSearch Dashboards components missing release notes

https://github.com/opensearch-project/opensearch-build/issues/4115#issuecomment-1933165762 alertingDashboards reportsDashboards notificationsDashboards securityAnalyticsDashboards

prudhvigodithi commented 4 months ago

5th RC OpenSearch 9399 / OpenSearch Dashboards 7280 - 02/12/2024.

We cant finalize this RC build due to missing release notes which does not meet the release notes readiness.

Triggered the RC builds

OpenSearch - Build 9399 OpenSearch Dashboards - Build 7280

Check how to install opensearch and dashboards on different platforms

OpenSearch components missing release notes

https://github.com/opensearch-project/opensearch-build/issues/4115#issuecomment-1933165208 asynchronous-search opensearch-reports

OpenSearch Dashboards components missing release notes

https://github.com/opensearch-project/opensearch-build/issues/4115#issuecomment-1933165762 alertingDashboards reportsDashboards notificationsDashboards

DarshitChanpura commented 4 months ago

@prudhvigodithi The docker testing steps should include the change about admin credentials for Start with security step:

prudhvigodithi commented 4 months ago

Thanks @DarshitChanpura I have updated the 3rd and 4th RC information, please check.

DarshitChanpura commented 4 months ago

@prudhvigodithi one small update: -e "OPENSEARCH_INITIAL_ADMIN_PASSWORD=myStrongPassword123\!" add backslash before ! to escape it.

prudhvigodithi commented 4 months ago

I have just updated to use single quotes which fixes entering into cmdand dquote>, can you test again @DarshitChanpura ?

DarshitChanpura commented 4 months ago

also the run command with env variable "DISABLE_SECURITY_PLUGIN=true" fails due to this logic :

➜  ~ docker pull opensearchstaging/opensearch:2.12.0.9399 && docker run -it -p 9200:9200 -e "DISABLE_SECURITY_PLUGIN=true" -e "discovery.type=single-node" opensearchstaging/opensearch:2.12.0.9399
2.12.0.9399: Pulling from opensearchstaging/opensearch
Digest: sha256:87b2c2bed78237714aea05572b71757470b9b0622867615dde14c1ac3e2eeb27
Status: Image is up to date for opensearchstaging/opensearch:2.12.0.9399
docker.io/opensearchstaging/opensearch:2.12.0.9399

What's Next?
  1. Sign in to your Docker account → docker login
  2. View a summary of image vulnerabilities and recommendations → docker scout quickview opensearchstaging/opensearch:2.12.0.9399
Enabling execution of install_demo_configuration.sh for OpenSearch Security Plugin
OpenSearch 2.12.0 onwards, the OpenSearch Security Plugin a change that requires an initial password for 'admin' user.
Please define an environment variable 'OPENSEARCH_INITIAL_ADMIN_PASSWORD' with a strong password string.
If a password is not provided, the setup will quit.
 For more details, please visit: https://opensearch.org/docs/latest/install-and-configure/install-opensearch/docker/
### OpenSearch Security Demo Installer
### ** Warning: Do not use on production or public reachable systems **
OpenSearch install type: rpm/deb on Linux 6.6.12-linuxkit aarch64
OpenSearch config dir: /usr/share/opensearch/config/
OpenSearch config file: /usr/share/opensearch/config/opensearch.yml
OpenSearch bin dir: /usr/share/opensearch/bin/
OpenSearch plugins dir: /usr/share/opensearch/plugins/
OpenSearch lib dir: /usr/share/opensearch/lib/
Detected OpenSearch Version: 2.12.0
Detected OpenSearch Security Version: 2.12.0.0
No custom admin password found. Please provide a password via the environment variable OPENSEARCH_INITIAL_ADMIN_PASSWORD.
➜  ~

This installs demo config first and then checks whether security plugin is disabled. This is wrong. It should not install demo config if it is not going to enable security plugin. I'll raise a PR to fix this.

PR: https://github.com/opensearch-project/opensearch-build/pull/4446

prudhvigodithi commented 4 months ago

@DarshitChanpura I assume the logic targets installing all the demo config and then access the cluster without security, but adding -e DISABLE_INSTALL_DEMO_CONFIG=true -e "DISABLE_SECURITY_PLUGIN=true" disables running install_demo_configuration.sh and security plugin and starts the cluster, but right just adding -e "DISABLE_SECURITY_PLUGIN=true" would fail with error No custom admin password found with the latest security plugin change. Adding @peterzhuamazon @bbarani

DarshitChanpura commented 4 months ago

@prudhvigodithi I'm confused as to why we are installing demo config (certificates and such) if it is not going to be utilized. Yes, this was brought forward because of admin credentials requirement starting 2.12 and can be resolved by passing an additional flag: DISABLE_INSTALL_DEMO_CONFIG=true however shouldn't it be implied that when security plugin is disabled, the demo config script should not execute? IMO it should.

ylwu-amzn commented 4 months ago

Need to add this PR to 2.12 https://github.com/opensearch-project/ml-commons/pull/2093, somehow missed backporting to 2.x

prudhvigodithi commented 4 months ago

The OpenSearch Dashboards validation test fail on the latest generated RC (4th)

Error:

requests.exceptions.ConnectionError: HTTPConnectionPool(host='localhost', port=5601): Max retries exceeded with url: /api/status (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7f833739e490>: Failed to establish a new connection: [Errno 111] Connection refused'))

The integ tests fail for the same as well: https://build.ci.opensearch.org/blue/organizations/jenkins/integ-test-opensearch-dashboards/detail/integ-test-opensearch-dashboards/5573/pipeline/113

Adding @kavilla @AMoo-Miki to please check.

ylwu-amzn commented 4 months ago

When test with tarball x64, see OpenSearch Dashboard failed to start bin/opensearch-dashboards , error

  log   [18:47:29.259] [fatal][root] /home/ylwu/Downloads/os2.12/rc4/opensearch-dashboards-2.12.0/plugins/assistantDashboards/node_modules/jsdom/lib/jsdom/living/nodes/HTMLInputElement-impl.js:583
      this[filesSymbol] ||= FileList.createImpl(this._globalObject);
                        ^^^

SyntaxError: Unexpected token '||='
    at compileFunction (<anonymous>)
    at wrapSafe (internal/modules/cjs/loader.js:1029:16)
    at Module._compile (internal/modules/cjs/loader.js:1078:27)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1143:10)
    at Module.load (internal/modules/cjs/loader.js:979:32)
    at Function.Module._load (internal/modules/cjs/loader.js:819:12)
    at Module.require (internal/modules/cjs/loader.js:1003:19)
    at Module.Hook._require.Module.require (/home/ylwu/Downloads/os2.12/rc4/opensearch-dashboards-2.12.0/node_modules/require-in-the-middle/index.js:80:39)
    at Module.Hook._require.Module.require (/home/ylwu/Downloads/os2.12/rc4/opensearch-dashboards-2.12.0/node_modules/require-in-the-middle/index.js:80:39)
    at Module.Hook._require.Module.require (/home/ylwu/Downloads/os2.12/rc4/opensearch-dashboards-2.12.0/node_modules/require-in-the-middle/index.js:80:39)
    at Module.Hook._require.Module.require (/home/ylwu/Downloads/os2.12/rc4/opensearch-dashboards-2.12.0/node_modules/require-in-the-middle/index.js:80:39)
    at Module.Hook._require.Module.require (/home/ylwu/Downloads/os2.12/rc4/opensearch-dashboards-2.12.0/node_modules/require-in-the-middle/index.js:80:39)
    at require (internal/modules/cjs/helpers.js:107:18)
    at Object.<anonymous> (/home/ylwu/Downloads/os2.12/rc4/opensearch-dashboards-2.12.0/plugins/assistantDashboards/node_modules/jsdom/lib/jsdom/living/generated/HTMLInputElement.js:1875:14)
    at Module._compile (internal/modules/cjs/loader.js:1114:14)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1143:10)

 FATAL  SyntaxError: Unexpected token '||='
jackiehanyang commented 4 months ago

AD-Dashboard just had a change merged in 2.12 branch for fixing this CVE

bbarani commented 4 months ago

@anirudha @joshuali925 Can you check this issue?

bbarani commented 4 months ago

Seeing errors onsecurityAnalyticsDashboards . CC: @praveensameneni @kavilla @AMoo-Miki @ashwin-pc

opensearch-dashboards | {"type":"log","@timestamp":"2024-02-13T19:54:26Z","tags":["fatal","root"],"pid":1,"message":"Error: Cannot find module '../config'\nRequire stack:\n- /usr/share/opensearch-dashboards/plugins/securityAnalyticsDashboards/server/index.js\n- /usr/share/opensearch-dashboards/src/core/server/plugins/plugin.js\n- /usr/share/opensearch-dashboards/src/core/server/plugins/discovery/plugins_discovery.js\n- /usr/share/opensearch-dashboards/src/core/server/plugins/discovery/index.js\n- /usr/share/opensearch-dashboards/src/core/server/plugins/plugins_service.js\n- /usr/share/opensearch-dashboards/src/core/server/plugins/index.js\n- /usr/share/opensearch-dashboards/src/core/server/index.js\n- /usr/share/opensearch-dashboards/src/cli/serve/serve.js\n- /usr/share/opensearch-dashboards/src/cli/cli.js\n- /usr/share/opensearch-dashboards/src/cli/dist.js\n at Function.Module._resolveFilename (node:internal/modules/cjs/loader:1134:15)\n at Module.Hook._require.Module.require (/usr/share/opensearch-dashboards/node_modules/require-in-the-middle/index.js:61:29)\n at require (node:internal/modules/helpers:177:18)\n at Object.<anonymous> (/usr/share/opensearch-dashboards/plugins/securityAnalyticsDashboards/server/index.ts:9:1)\n at Module._compile (node:internal/modules/cjs/loader:1356:14)\n at Object.Module._extensions..js (node:internal/modules/cjs/loader:1414:10)\n at Module.load (node:internal/modules/cjs/loader:1197:32)\n at Function.Module._load (node:internal/modules/cjs/loader:1013:12)\n at Module.require (node:internal/modules/cjs/loader:1225:19)\n at Module.Hook._require.Module.require (/usr/share/opensearch-dashboards/node_modules/require-in-the-middle/index.js:80:39) {\n code: 'MODULE_NOT_FOUND',\n requireStack: [\n '/usr/share/opensearch-dashboards/plugins/securityAnalyticsDashboards/server/index.js',\n '/usr/share/opensearch-dashboards/src/core/server/plugins/plugin.js',\n '/usr/share/opensearch-dashboards/src/core/server/plugins/discovery/plugins_discovery.js',\n '/usr/share/opensearch-dashboards/src/core/server/plugins/discovery/index.js',\n '/usr/share/opensearch-dashboards/src/core/server/plugins/plugins_service.js',\n '/usr/share/opensearch-dashboards/src/core/server/plugins/index.js',\n '/usr/share/opensearch-dashboards/src/core/server/index.js',\n '/usr/share/opensearch-dashboards/src/cli/serve/serve.js',\n '/usr/share/opensearch-dashboards/src/cli/cli.js',\n '/usr/share/opensearch-dashboards/src/cli/dist.js'\n ]\n}"}

paulstn commented 4 months ago

@prudhvigodithi Fix for a critical bug in dashboards observability, merged in the 2.12 branch: https://github.com/opensearch-project/dashboards-observability/pull/1435

ashwin-pc commented 4 months ago

@prudhvigodithi Bug fix for Discover Saved Query. Will update when merged

Fix save query management render bug on discover

prudhvigodithi commented 4 months ago

@DarshitChanpura @derek-ho @peterzhuamazon tested all the following scenarios based on this comment and works as expected on the latest build (opensearchstaging/opensearch:2.12.0.9407) after this PR is merged, can you please confirm as well?

docker run -it -p 9200:9200 -e 'OPENSEARCH_INITIAL_ADMIN_PASSWORD=myStrongPassword123!' -e "discovery.type=single-node"  opensearchstaging/opensearch:2.12.0.9407

docker run -it -p 9200:9200 -e "discovery.type=single-node"  opensearchstaging/opensearch:2.12.0.9407

docker run -it -p 9200:9200 -e "discovery.type=single-node" -e "DISABLE_SECURITY_PLUGIN=true" opensearchstaging/opensearch:2.12.0.9407

docker run -it -p 9200:9200 -e "discovery.type=single-node" -e "DISABLE_INSTALL_DEMO_CONFIG=true" -e "DISABLE_SECURITY_PLUGIN=true" opensearchstaging/opensearch:2.12.0.9407

docker run -it -p 9200:9200 -e "DISABLE_INSTALL_DEMO_CONFIG=true" -e 'OPENSEARCH_INITIAL_ADMIN_PASSWORD=myStrongPassword123!' -e "discovery.type=single-node"  opensearchstaging/opensearch:2.12.0.9407 

Thank you

DarshitChanpura commented 4 months ago

docker run -it -p 9200:9200 -e "discovery.type=single-node" -e "DISABLE_INSTALL_DEMO_CONFIG=true" -e "DISABLE_SECURITY_PLUGIN=true" opensearchstaging/opensearch:2.12.0.9407

This can be shortened to :

docker run -it -p 9200:9200 -e "discovery.type=single-node" -e "DISABLE_SECURITY_PLUGIN=true" opensearchstaging/opensearch:2.12.0.9407

docker run -it -p 9200:9200 -e "DISABLE_INSTALL_DEMO_CONFIG=true" -e 'OPENSEARCH_INITIAL_ADMIN_PASSWORD=myStrongPassword123!' -e "discovery.type=single-node" opensearchstaging/opensearch:2.12.0.9407

this can be shortened to:

docker run -it -p 9200:9200 -e "DISABLE_INSTALL_DEMO_CONFIG=true" -e "discovery.type=single-node"  opensearchstaging/opensearch:2.12.0.9407

Post #4446 , DISABLE_SECURITY_PLUGIN inherently disables DISABLE_INSTALL_DEMO_CONFIG

Zhangxunmt commented 4 months ago

https://github.com/opensearch-project/ml-commons/pull/2101, https://github.com/opensearch-project/ml-commons/pull/2099. The last minute bug fixes in ml-commons.

prudhvigodithi commented 4 months ago

docker run -it -p 9200:9200 -e "discovery.type=single-node" -e "DISABLE_INSTALL_DEMO_CONFIG=true" -e "DISABLE_SECURITY_PLUGIN=true" opensearchstaging/opensearch:2.12.0.9407

This can be shortened to :

docker run -it -p 9200:9200 -e "discovery.type=single-node" -e "DISABLE_SECURITY_PLUGIN=true" opensearchstaging/opensearch:2.12.0.9407

docker run -it -p 9200:9200 -e "DISABLE_INSTALL_DEMO_CONFIG=true" -e 'OPENSEARCH_INITIAL_ADMIN_PASSWORD=myStrongPassword123!' -e "discovery.type=single-node" opensearchstaging/opensearch:2.12.0.9407

this can be shortened to:

docker run -it -p 9200:9200 -e "DISABLE_INSTALL_DEMO_CONFIG=true" -e "discovery.type=single-node"  opensearchstaging/opensearch:2.12.0.9407

Thanks @DarshitChanpura, right I wanted to test without the shortened one as previously users use to pass this way and want to make sure its not breaking.

derek-ho commented 4 months ago

@prudhvigodithi @DarshitChanpura and I have also tested on most distributions (except Debian which I will pick up tomorrow) and changes are working as expected except for a windows bug which password can't end in ! But I think that's partly due to the way we were running the command so I think we are mostly good

DarshitChanpura commented 4 months ago

Thanks @DarshitChanpura, right I wanted to test without the shortened one as previously users use to pass this way and want to make sure its not breaking.

For pre <2.12 OPENSEARCH_INITIAL_ADMIN_PASSWORD is not required to be passed, and with the new change post 2.12 only addition would be OPENSEARCH_INITIAL_ADMIN_PASSWORD. In addition to make it easier, we have re-organized the usage of demo config install script flag via #4446 so that both DISABLE_INSTALL_DEMO_CONFIG and DISABLE_SECURITY_PLUGIN are not required. Hope this answers your question.

Zhangxunmt commented 4 months ago

I still get this error when running the opensearch-dashboards from tarball 2.12.

dev-dsk-xunzh-2c-b57bd588 % bin/opensearch-dashboards log [23:16:38.409] [fatal][root] /local/home/xunzh/projects/OS2.12/opensearch-dashboards-2.12.0/plugins/assistantDashboards/node_modules/jsdom/lib/jsdom/living/nodes/HTMLInputElement-impl.js:583 this[filesSymbol] ||= FileList.createImpl(this._globalObject); ^^^

SyntaxError: Unexpected token '||=' at compileFunction () at wrapSafe (internal/modules/cjs/loader.js:1029:16) at Module._compile (internal/modules/cjs/loader.js:1078:27) at Object.Module._extensions..js (internal/modules/cjs/loader.js:1143:10) at Module.load (internal/modules/cjs/loader.js:979:32) at Function.Module._load (internal/modules/cjs/loader.js:819:12) at Module.require (internal/modules/cjs/loader.js:1003:19) at Module.Hook._require.Module.require (/local/home/xunzh/projects/OS2.12/opensearch-dashboards-2.12.0/node_modules/require-in-the-middle/index.js:80:39) at Module.Hook._require.Module.require (/local/home/xunzh/projects/OS2.12/opensearch-dashboards-2.12.0/node_modules/require-in-the-middle/index.js:80:39) at Module.Hook._require.Module.require (/local/home/xunzh/projects/OS2.12/opensearch-dashboards-2.12.0/node_modules/require-in-the-middle/index.js:80:39) at Module.Hook._require.Module.require (/local/home/xunzh/projects/OS2.12/opensearch-dashboards-2.12.0/node_modules/require-in-the-middle/index.js:80:39) at Module.Hook._require.Module.require (/local/home/xunzh/projects/OS2.12/opensearch-dashboards-2.12.0/node_modules/require-in-the-middle/index.js:80:39) at require (internal/modules/cjs/helpers.js:107:18) at Object. (/local/home/xunzh/projects/OS2.12/opensearch-dashboards-2.12.0/plugins/assistantDashboards/node_modules/jsdom/lib/jsdom/living/generated/HTMLInputElement.js:1875:14) at Module._compile (internal/modules/cjs/loader.js:1114:14) at Object.Module._extensions..js (internal/modules/cjs/loader.js:1143:10)

FATAL SyntaxError: Unexpected token '||='

sejli commented 4 months ago

Looking into the jsdom issue currently, seems like the tarball for x86 is using the 18.9.0 version as found in the tarball's node directory, which supports jsdom versions ^22.1.0. My thinking is the node_modules folder was built using a different version of node, which causes the unexpected token error. I'm unable to reproduce the issue when starting OSD using yarn, currently trying different versions to be able to get the same error.

prudhvigodithi commented 4 months ago

6th RC OpenSearch 9408 / OpenSearch Dashboards 7286 - 02/13/2024.

OpenSearch - Build 9408 OpenSearch Dashboards - Build 7286

Components missing the Release notes

asynchronous-search

sohami commented 4 months ago

Validated the docker and tarball (arm/x86) for 4th RC and running nyc_taxis test against the installed OpenSearch candidate with security plugin. Don't see any error with nyc_taxis workload.

sejli commented 4 months ago

Update on this issue

I was able to spin up a cluster by doing the following:

  1. Download the OSD tarball from here and extract it.
  2. Manually export a new node version or remove the node folder such that it uses my local environment's node 18.16.0.
  3. Run ./bin/opensearch-dashboards. On my local, I then run into this issue that @bbarani mentioned.
  4. After removing the securityAnalyticsDashboards plugin from the plugins/ directory, I'm able to start OSD with ./bin/opensearch-dashboards. I'm able to get an end-to-end working when OpenSearch backend is started without the security plugin.

I noticed that the issue @ylwu-amzn mentioned only occurred when I tested with Amazon Linux 2. When run on Ubuntu, I don't run into the Unexpected token issue, only this issue. This may be (not 100% sure) because AL2 does not support Node version 18.19.0, since GLIBC_2.27 and GLIBC_2.28 doesn't exist on AL2.

peterzhuamazon commented 4 months ago

Update on this issue

I was able to spin up a cluster by doing the following:

1. Download the OSD tarball from [here](https://github.com/opensearch-project/opensearch-build/issues/4115#issuecomment-1939823474) and extract it.

2. Manually export a new node version or remove the `node` folder such that it uses my local environment's node `18.16.0`.

3. Run `./bin/opensearch-dashboards`. On my local, I then run into [this issue](https://github.com/opensearch-project/opensearch-build/issues/4115#issuecomment-1942321347) that @bbarani mentioned.

4. After removing the `securityAnalyticsDashboards` plugin from the `plugins/` directory, I'm able to start OSD with `./bin/opensearch-dashboards`. I'm able to get an end-to-end working when OpenSearch backend is started without the security plugin.

I noticed that the issue @ylwu-amzn mentioned only occurred when I tested with Amazon Linux 2023. When run on Ubuntu, I don't run into the Unexpected token issue, only this issue. This may be (not 100% sure) because AL2023 does not support Node version 18.19.0, since GLIBC_2.27 and GLIBC_2.28 doesn't exist on AL2023.

Al2023 support up to 2.34 glibc , which is the reason we have the upgrade project from CentOS7 / AL2 to RockyLinux8 / AL2023 for Node16/18.

image

ldd (GNU libc) 2.34

Installing nvm and running it without any issues:

nvm list
->     v18.19.0
default -> 18.19.0 (-> v18.19.0)
iojs -> N/A (default)
unstable -> N/A (default)
node -> stable (-> v18.19.0) (default)
stable -> 18.19 (-> v18.19.0) (default)
lts/* -> lts/iron (-> N/A)
lts/argon -> v4.9.1 (-> N/A)
lts/boron -> v6.17.1 (-> N/A)
lts/carbon -> v8.17.0 (-> N/A)
lts/dubnium -> v10.24.1 (-> N/A)
lts/erbium -> v12.22.12 (-> N/A)
lts/fermium -> v14.21.3 (-> N/A)
lts/gallium -> v16.20.2 (-> N/A)
lts/hydrogen -> v18.19.0
lts/iron -> v20.11.0 (-> N/A)
bash-5.2# node --version
v18.19.0

bash-5.2# cat /etc/*release
Amazon Linux release 2023 (Amazon Linux)
NAME="Amazon Linux"
VERSION="2023"
ID="amzn"
ID_LIKE="fedora"
VERSION_ID="2023"
PLATFORM_ID="platform:al2023"
PRETTY_NAME="Amazon Linux 2023"
ANSI_COLOR="0;33"
CPE_NAME="cpe:2.3:o:amazon:amazon_linux:2023"
HOME_URL="https://aws.amazon.com/linux/"
BUG_REPORT_URL="https://github.com/amazonlinux/amazon-linux-2023"
SUPPORT_END="2028-03-15"
Amazon Linux release 2023 (Amazon Linux)
peterzhuamazon commented 4 months ago

New issue spot on DEB having discussion with @DarshitChanpura .

DEB is not able to pass the initial check in preinstall due to dpkg-query -W will treat 2.12 itself as a already installed version. dpkg-query -s is able to avoid that but will remove entry during upgrade, treating every installation as raw instead of upgrade. dpkg -l has the same issue as dpkg-query -W but resolve the issue with dpkg-query -s.

Awaiting @DarshitChanpura to give a final decision on this.

peterzhuamazon commented 4 months ago

Properly Resolve #4445:

peterzhuamazon commented 4 months ago

Talked to @sejli in a debug meeting and here is the discovery:

  1. securityAnalyticsDashboards needs fixes: @praveensameneni @getsaurabh02 @kavilla @AMoo-Miki @ashwin-pc

    log   [02:15:37.144] [fatal][root] Error: Cannot find module '../config'
    Require stack:
    - /local/home/user/test/opensearch-dashboards-2.12.0/plugins/securityAnalyticsDashboards/server/index.js
    - /local/home/user/test/opensearch-dashboards-2.12.0/src/core/server/plugins/plugin.js
    - /local/home/user/test/opensearch-dashboards-2.12.0/src/core/server/plugins/discovery/plugins_discovery.js
    - /local/home/user/test/opensearch-dashboards-2.12.0/src/core/server/plugins/discovery/index.js
    - /local/home/user/test/opensearch-dashboards-2.12.0/src/core/server/plugins/plugins_service.js
    - /local/home/user/test/opensearch-dashboards-2.12.0/src/core/server/plugins/index.js
    - /local/home/user/test/opensearch-dashboards-2.12.0/src/core/server/index.js
    - /local/home/user/test/opensearch-dashboards-2.12.0/src/cli/serve/serve.js
    - /local/home/user/test/opensearch-dashboards-2.12.0/src/cli/cli.js
    - /local/home/user/test/opensearch-dashboards-2.12.0/src/cli/dist.js
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:931:15)
    at Module.Hook._require.Module.require (/local/home/user/test/opensearch-dashboards-2.12.0/node_modules/require-in-the-middle/index.js:61:29)
    at require (internal/modules/cjs/helpers.js:107:18)
    at Object.<anonymous> (/local/home/user/test/opensearch-dashboards-2.12.0/plugins/securityAnalyticsDashboards/server/index.ts:9:1)
    at Module._compile (internal/modules/cjs/loader.js:1114:14)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1143:10)
    at Module.load (internal/modules/cjs/loader.js:979:32)
    at Function.Module._load (internal/modules/cjs/loader.js:819:12)
    at Module.require (internal/modules/cjs/loader.js:1003:19)
    at Module.Hook._require.Module.require (/local/home/user/test/opensearch-dashboards-2.12.0/node_modules/require-in-the-middle/index.js:80:39)
    at Module.Hook._require.Module.require (/local/home/user/test/opensearch-dashboards-2.12.0/node_modules/require-in-the-middle/index.js:80:39)
    at Module.Hook._require.Module.require (/local/home/user/test/opensearch-dashboards-2.12.0/node_modules/require-in-the-middle/index.js:80:39)
    at Module.Hook._require.Module.require (/local/home/user/test/opensearch-dashboards-2.12.0/node_modules/require-in-the-middle/index.js:80:39)
    at Module.Hook._require.Module.require (/local/home/user/test/opensearch-dashboards-2.12.0/node_modules/require-in-the-middle/index.js:80:39)
    at require (internal/modules/cjs/helpers.js:107:18)
    at PluginWrapper.getConfigDescriptor (/local/home/user/test/opensearch-dashboards-2.12.0/src/core/server/plugins/plugin.js:132:30) {
    code: 'MODULE_NOT_FOUND',
    requireStack: [
    '/local/home/user/test/opensearch-dashboards-2.12.0/plugins/securityAnalyticsDashboards/server/index.js',
    '/local/home/user/test/opensearch-dashboards-2.12.0/src/core/server/plugins/plugin.js',
    '/local/home/user/test/opensearch-dashboards-2.12.0/src/core/server/plugins/discovery/plugins_discovery.js',
    '/local/home/user/test/opensearch-dashboards-2.12.0/src/core/server/plugins/discovery/index.js',
    '/local/home/user/test/opensearch-dashboards-2.12.0/src/core/server/plugins/plugins_service.js',
    '/local/home/user/test/opensearch-dashboards-2.12.0/src/core/server/plugins/index.js',
    '/local/home/user/test/opensearch-dashboards-2.12.0/src/core/server/index.js',
    '/local/home/user/test/opensearch-dashboards-2.12.0/src/cli/serve/serve.js',
    '/local/home/user/test/opensearch-dashboards-2.12.0/src/cli/cli.js',
    '/local/home/user/test/opensearch-dashboards-2.12.0/src/cli/dist.js'
    ]
    }
    
    FATAL  Error: Cannot find module '../config'
    Require stack:
    - /local/home/user/test/opensearch-dashboards-2.12.0/plugins/securityAnalyticsDashboards/server/index.js
    - /local/home/user/test/opensearch-dashboards-2.12.0/src/core/server/plugins/plugin.js
    - /local/home/user/test/opensearch-dashboards-2.12.0/src/core/server/plugins/discovery/plugins_discovery.js
    - /local/home/user/test/opensearch-dashboards-2.12.0/src/core/server/plugins/discovery/index.js
    - /local/home/user/test/opensearch-dashboards-2.12.0/src/core/server/plugins/plugins_service.js
    - /local/home/user/test/opensearch-dashboards-2.12.0/src/core/server/plugins/index.js
    - /local/home/user/test/opensearch-dashboards-2.12.0/src/core/server/index.js
    - /local/home/user/test/opensearch-dashboards-2.12.0/src/cli/serve/serve.js
    - /local/home/user/test/opensearch-dashboards-2.12.0/src/cli/cli.js
    - /local/home/user/test/opensearch-dashboards-2.12.0/src/cli/dist.js
  2. There is no issue with 18.16.0 vs 18.19.0, as Sean was mistakenly test on AL2, not AL2023. We properly test again on AL2023 and it passed after removing securityAnalyticsDashboards.

  3. The reason it failed on AL2 is because AL2 doesnt support node 18, thus falls back to node 14.23.1. This version of node does not support jsdom 22+ as it has a minimum requirement of node 16. Since we are still support CentOS7 and the proper deprecation hasnt come yet, assistantDashboards needs to use an older version of jsdom < 22. (@xluo-aws @zane-neo @wanglam @joshuali925) https://github.com/opensearch-project/opensearch-build/issues/4379 https://github.com/opensearch-project/dashboards-assistant/blob/2.12/package.json#L24 https://github.com/jsdom/jsdom/blob/main/Changelog.md#2200


  log   [02:14:19.877] [fatal][root] /local/home/user/test/opensearch-dashboards-2.12.0/plugins/assistantDashboards/node_modules/jsdom/lib/jsdom/living/nodes/HTMLInputElement-impl.js:583
      this[filesSymbol] ||= FileList.createImpl(this._globalObject);
                        ^^^

SyntaxError: Unexpected token '||='
    at compileFunction (<anonymous>)
    at wrapSafe (internal/modules/cjs/loader.js:1029:16)
    at Module._compile (internal/modules/cjs/loader.js:1078:27)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1143:10)
    at Module.load (internal/modules/cjs/loader.js:979:32)
    at Function.Module._load (internal/modules/cjs/loader.js:819:12)
    at Module.require (internal/modules/cjs/loader.js:1003:19)
    at Module.Hook._require.Module.require (/local/home/user/test/opensearch-dashboards-2.12.0/node_modules/require-in-the-middle/index.js:80:39)
    at Module.Hook._require.Module.require (/local/home/user/test/opensearch-dashboards-2.12.0/node_modules/require-in-the-middle/index.js:80:39)
    at Module.Hook._require.Module.require (/local/home/user/test/opensearch-dashboards-2.12.0/node_modules/require-in-the-middle/index.js:80:39)
    at Module.Hook._require.Module.require (/local/home/user/test/opensearch-dashboards-2.12.0/node_modules/require-in-the-middle/index.js:80:39)
    at Module.Hook._require.Module.require (/local/home/user/test/opensearch-dashboards-2.12.0/node_modules/require-in-the-middle/index.js:80:39)
    at require (internal/modules/cjs/helpers.js:107:18)
    at Object.<anonymous> (/local/home/user/test/opensearch-dashboards-2.12.0/plugins/assistantDashboards/node_modules/jsdom/lib/jsdom/living/generated/HTMLInputElement.js:1875:14)
    at Module._compile (internal/modules/cjs/loader.js:1114:14)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1143:10)

 FATAL  SyntaxError: Unexpected token '||='

cc: @bbarani @prudhvigodithi

Thanks.

DarshitChanpura commented 4 months ago

New issue spot on DEB having discussion with @DarshitChanpura .

DEB is not able to pass the initial check in preinstall due to dpkg-query -W will treat 2.12 itself as a already installed version. dpkg-query -s is able to avoid that but will remove entry during upgrade, treating every installation as raw instead of upgrade. dpkg -l has the same issue as dpkg-query -W but resolve the issue with dpkg-query -s.

Awaiting @DarshitChanpura to give a final decision on this.

This issue was spotted during RC testing for deb, and since there is no concrete fool-proof way of stopping the installation during pre-install phase, I've raised a PR: https://github.com/opensearch-project/opensearch-build/pull/4453/ to remove any changes made to preinst script for DEB distribution. For more details around methods tested please check PR description.

prudhvigodithi commented 4 months ago

PR's merged after 6th RC generated. https://github.com/opensearch-project/dashboards-assistant/pull/147 https://github.com/opensearch-project/security-analytics-dashboards-plugin/pull/886