search

opensearch-project / opensearch-oci-object-storage

OpenSearch Repository Plugin For Oci Object Storage
Apache License 2.0
7 stars 19 forks source link

[PROPOSAL] Standardize branching strategy #27

Closed andrross closed 1 year ago

andrross commented 1 year ago

The OpenSearch project generally follows a strategy of tracking 3 releases in parallel (next major, next minor, and current). See RELEASING.md for more details. This repository currently only has a main branch that is targeting version 1.2.4. Should we update to match the OpenSearch branching strategy. If not, why not?

Assuming the answer is yes, then the steps are (I think?):

anasalkouz commented 1 year ago

@dblock or @samuel-oci not sure if you have some context on this repository Is any reason why it is not following OpenSearch branching strategy? Why it's not part of the OpenSearch release bundle?

wbeckler commented 1 year ago

I propose that this entire repo be moved here: https://github.com/opensearch-project/OpenSearch/tree/main/plugins in a subdirectory called "repository-oci," just like there is a repository-azure and a repository-s3. If not, then why not create repos for those other cloud file stores?

wbeckler commented 1 year ago

I've opened an issue suggesting this: https://github.com/opensearch-project/OpenSearch/issues/6148

samuel-oci commented 1 year ago

Hi @anasalkouz @andrross @wbeckler , some context: Originally it was created as a separate repo in order to allow the community time to decide how to address object storage repository plugins in the community. The community feedback at the time was captured here: https://github.com/opensearch-project/OpenSearch/issues/1854

I agree with @wbeckler suggestion, I think that moving it into the core for now will probably make sure it remains consistent with both versioning strategy and will make routine maintenance and upgrade efforts easier.

samuel-oci commented 1 year ago

Regarding the branching strategy, if we want to take more time before moving it into the core, using a proper conventional branching strategy can't hurt.

samuel-oci commented 1 year ago

I created a 1.3 branch from the current commit on main. After merging https://github.com/opensearch-project/opensearch-oci-object-storage/pull/33 I will create a 2.4 branch. Going forward will keep the above branching strategy after any version upgrade. Closing this for now while the suggestion to move to the monolith is discussed here: https://github.com/opensearch-project/OpenSearch/tree/main/plugins.