opensearch-project / opensearch-py-ml

Apache License 2.0
30 stars 62 forks source link

[FEATURE] Migrate to `pyproject.toml` #308

Open rawwar opened 9 months ago

rawwar commented 9 months ago

Current opensearch-py-ml project uses setup.py and setup.cfg to maintain project metadata. pyproject.toml is the new standard. PEP 621, which was accepted in 2021, designated pyproject.toml as the standard way to specify project metadata for Python packages. setuptools and other packaging tools now support pyproject.toml, and it is expected to become the de facto standard for Python packaging in the future.

pyproject.toml also supports few features that are not available in setup.cfg, such as dynamic metadata and optional dependencies.

Edit-1: Added more information on why to migrate.

rawwar commented 9 months ago

@dhrubo-os , I am willing to raise a PR for this.

dhrubo-os commented 9 months ago

@rawwar Thank you for creating the issue. I would like you to expand this issue description a bit more, such as explaining why we should adopt pyproject.toml and what advantages we will gain over the current process, etc.

rawwar commented 9 months ago

@dhrubo-os , Would you consider this as a major change? I am wondering if we should be doing this migration as part of next major release?

bilal-aamer commented 7 months ago

Hey @rawwar @dhrubo-os, would love to contribute to this migration to pyproject.toml

rawwar commented 7 months ago

@bilal-aamer , that would be great. Please feel free to raise a PR. I would be happy to help and review.

@dhrubo-os , do you think there are any pre-requisites before @bilal-aamer works on it?

dhrubo-os commented 7 months ago

I don't think so. @bilal-aamer thanks for looking into this. Assigned this to you.

rawwar commented 6 months ago

@bilal-aamer , how is it going? If you need any help, please raise a draft PR with whatever you have done so far and I can try to help.

bilal-aamer commented 6 months ago

Hey @rawwar, will do right away been looking into pyproject.toml.

Will get a generic PR out right away.