opensearch-project / opensearch-system-templates

The repository is a plugin which acts as a repository for system templates which should be loaded as part of the cluster setup. These contain application based configuration templates which are used to provide sensible defaults for various use-cases for which users may be using OpenSearch.
https://www.opensearch.org
Apache License 2.0
0 stars 4 forks source link

Use common variable for versioning #32

Closed gaiksaya closed 1 month ago

gaiksaya commented 1 month ago

Description

Use common variable for versioning since plugins are tightly coupled and can use same version overall. To avoid scenarios like https://github.com/opensearch-project/opensearch-system-templates/pull/31

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check here.

opensearch-trigger-bot[bot] commented 1 month ago

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/opensearch-system-templates/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/opensearch-system-templates/backport-2.x
# Create a new branch
git switch --create backport/backport-32-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0a981e9ab250f6aa31c0b66e8c2565d9e5acb371
# Push it to GitHub
git push --set-upstream origin backport/backport-32-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/opensearch-system-templates/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-32-to-2.x.