Closed leonwanghui closed 4 years ago
:white_check_mark: Hey leonwanghui! The commit authors and yourself have already signed the CLA.
I think there should be a note somewhere -- which is the commit / release in the broker side for the example config.
Is there a way we can keep company-specific configuration files out of this repo? And make the required information pluggable? It would be strange to have lots of different config files included as part of this repo.
Hi @mattmcneeney , I get your point. But what I'm trying to do is to provide a real broker so that we can have e2e test for broker operations.
If you think company specific is allowed (which I have no question), shall we put some open-source broker implementation in here, such as opensds?
@leonwanghui What about providing the configuration as part of running the test suite instead? This configuration is going to be different for every broker, which is why I think it doesn't really belong in the osb-checker repo.
I have a broker that I'd like to test using this suite. What I think would be useful is if I had some instructions on how I could create a config.json
configuration file for my specific broker, and then I can run the tests with npm test --config config.json
or something like that.
What do you think?
Signed-off-by: leonwanghui wanghui71leon@gmail.com
Hi all, I created a PR for pushing huaweicloud broker configuration file into this project, and the reasons are as follows:
Please be free to ask if you have any question