openshift-pipelines / console-plugin

OpenShift Pipelines (and Tekton) OpenShift console dynamic plugin
Apache License 2.0
2 stars 16 forks source link

Add rpms as its required for prefetch dependancy #177

Closed savitaashture closed 1 day ago

openshift-ci[bot] commented 3 days ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: savitaashture Once this PR has been reviewed and has the lgtm label, please assign vdemeester for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift-pipelines/console-plugin/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
savitaashture commented 3 days ago

/test console-plugin-main-console-plugin-on-pull-request

openshift-ci[bot] commented 3 days ago

@savitaashture: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

Use /test all to run all jobs.

In response to [this](https://github.com/openshift-pipelines/console-plugin/pull/177#issuecomment-2456592937): >/test console-plugin-main-console-plugin-on-pull-request Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
savitaashture commented 3 days ago

/test console-plugin-main-console-plugin-on-pull-request

openshift-ci[bot] commented 3 days ago

@savitaashture: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

Use /test all to run all jobs.

In response to [this](https://github.com/openshift-pipelines/console-plugin/pull/177#issuecomment-2457059641): >/test console-plugin-main-console-plugin-on-pull-request Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
savitaashture commented 2 days ago

Hi @vdemeester I had to have local dependency in order to fetch and build with yarn and Konflux won't have support for yarn yet like npm, rpm etc... Jira : https://issues.redhat.com/browse/STONEBLD-1753 (Support of pre-fetch for Yarn )

So I followed https://classic.yarnpkg.com/blog/2016/11/24/offline-mirror/ to have local copy so that yarn can download offline way

vdemeester commented 1 day ago

@savitaashture 🆗

savitaashture commented 1 day ago

@savitaashture 🆗

Merging the PR