add 'sleep infinity' as one of the string to wait for

openshift-psap / special-resource-operator-deprecated

Apache License 2.0

10 stars 12 forks source link

add 'sleep infinity' as one of the string to wait for #16

Closed oatakan closed 4 years ago

oatakan commented 4 years ago

On one of the systems I test with, '+ sleep infinity' shows up as the last line in the log file as opposed to '+ wait':

` Mounting NVIDIA driver rootfs...

mount --make-runbindable /sys
mount --make-private /sys
mkdir -p /run/nvidia/driver
mount --rbind / /run/nvidia/driver
_write_kernel_update_hook
'[' '!' -d /run/kernel/postinst.d ']'
return
'[' '!' -e /host/etc/containers/oci/hooks.d ']'
'[' -e /etc/containers/oci/hooks.d/oci-nvidia-hook.json ']'
cp /etc/containers/oci/hooks.d/oci-nvidia-hook.json /host/etc/containers/oci/hooks.d/.
echo 'Done, now waiting for signal' Done, now waiting for signal
trap 'echo '\''Caught signal'\''; _shutdown && { kill 619190; exit 0; }' HUP INT QUIT PIPE TERM
trap - EXIT
true
wait 619190
sleep infinity ` This PR adds another pattern (+ sleep infinity) to waitfor. I tested this with OpenShift 4.3. Not sure which branch to submit this against, so I picked master.

openshift-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: oatakan To complete the pull request process, please assign zvonkok You can assign the PR to them by writing /assign @zvonkok in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift-psap/special-resource-operator/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

openshift-ci-robot commented 4 years ago

Hi @oatakan. Thanks for your PR.

I'm waiting for a openshift-psap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

ArangoGutierrez commented 4 years ago

/cc @zvonkok

ArangoGutierrez commented 4 years ago

/uncc Deepthidharwar

zvonkok commented 4 years ago

@oatakan This will be addressed with the new push to master. There will also be a Part2 of SRO describing this new feature.

zvonkok commented 4 years ago

@oatakan Can you please turn this into an issue for tracking?

oatakan commented 4 years ago

@oatakan Can you please turn this into an issue for tracking?

done: https://github.com/openshift-psap/special-resource-operator/issues/18

lgtm-com[bot] commented 4 years ago

This pull request fixes 2 alerts when merging 06f1cbb12a7f624c5cc983d4f4d1107c0ac0117e into 98a78fb2c8abf1ebdc4c2feb0db82c6cb5fefda2 - view on LGTM.com

fixed alerts:

2 for Useless assignment to local variable