search

openshift-psap / special-resource-operator-deprecated

Apache License 2.0
10 stars 12 forks source link

Depends On: #27 Driver container base #29

Closed zvonkok closed 4 years ago

zvonkok commented 4 years ago

Hiding all the gory details from customers and building a DriverContainer base image. Added a new recipe to build the driver-container-base. 

 SPECIALRESOURCE=driver-container-base PULLPOLICY=Always make deploy
openshift-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zvonkok

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-psap/special-resource-operator/blob/master/OWNERS)~~ [zvonkok] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
zvonkok commented 4 years ago

/retest

zvonkok commented 4 years ago

/retest

kpouget commented 4 years ago

The PR defines a new specialresource (driver-container-base) and adds the manifests and operations to build it as a ubi8 image containing the kmods-via-containers installation.

Apart from a minor inconsistency mentioned in the comment above, /lgtm