Bug 1883363: Simple kmod v2

zvonkok commented 4 years ago

Heavy update on the SDK.

Added lustre-client, simple-kmod, driver-container-base as recipes. Dependent SpecialResources are created now automatically and reconciled. New field imageReference: true will add RBAC to pull images from other dependent namespaces.

SRO will deploy from the internal file-system if no ConfigMap overrides are generated.

SPECIALRESOURCE=lustre-client make

Or if yaml files are updated and should be overriden:

SPECIALRESOURCE=lustre-client make assets
SPECIALRESOURCE=lustre-client make

zvonkok commented 4 years ago

@dagrayvid PTAL

lgtm-com[bot] commented 4 years ago

This pull request introduces 4 alerts and fixes 4 when merging f12e3339e60e59e5b85f5d6a634ba010ddc2a514 into 659da3913c235dedb946b1465633ba4ffa228e07 - view on LGTM.com

new alerts:

4 for Useless assignment to local variable

fixed alerts:

4 for Useless assignment to local variable

ArangoGutierrez commented 4 years ago

/unassign @zvonkok /assign

ArangoGutierrez commented 4 years ago

Also why are we removing README and OWNERS file ?

zvonkok commented 4 years ago

@ArangoGutierrez ha, good catch, will add them back, that is why it is "Draft".

zvonkok commented 4 years ago

@ArangoGutierrez There are many reasons why a newline should be at "any" file. One is when files are concatenated, it is always good to have a newline. Some tools cannot interpret the EOF correctly and can fail.

ArangoGutierrez commented 4 years ago

@ArangoGutierrez There are many reasons why a newline should be at "any" file. One is when files are concatenated, it is always good to have a newline. Some tools cannot interpret the EOF correctly and can fail.

Understood, is an old habit to check for non needed lines when doing code review. but you are totally right.

ArangoGutierrez commented 4 years ago

Also remove bin/manager , and we probably want to add bin/ to .gitignore to prevent this from getting into future changes

ArangoGutierrez commented 4 years ago

/label tide/merge-method-squash

ArangoGutierrez commented 4 years ago

Let's hold this PR to avoid triggering CI tests until we are good to talk about merging this path /hold

lgtm-com[bot] commented 4 years ago

This pull request introduces 4 alerts and fixes 4 when merging d5d918d8b93f4c2464edd561c7251006522b8f0a into 659da3913c235dedb946b1465633ba4ffa228e07 - view on LGTM.com

new alerts:

4 for Useless assignment to local variable

fixed alerts:

4 for Useless assignment to local variable

lgtm-com[bot] commented 4 years ago

This pull request introduces 4 alerts and fixes 4 when merging 282a80b8d8b65b84b4e793d1a9fa34e45c192e42 into 659da3913c235dedb946b1465633ba4ffa228e07 - view on LGTM.com

new alerts:

4 for Useless assignment to local variable

fixed alerts:

4 for Useless assignment to local variable

lgtm-com[bot] commented 4 years ago

This pull request introduces 4 alerts and fixes 4 when merging 660993f806c6a92d2623aa0a360cca8204dadbcd into 659da3913c235dedb946b1465633ba4ffa228e07 - view on LGTM.com

new alerts:

4 for Useless assignment to local variable

fixed alerts:

4 for Useless assignment to local variable

lgtm-com[bot] commented 4 years ago

This pull request introduces 4 alerts and fixes 4 when merging 518c11b2eb03fcdede17d35a1e2f78a1f20e05d4 into 659da3913c235dedb946b1465633ba4ffa228e07 - view on LGTM.com

new alerts:

4 for Useless assignment to local variable

fixed alerts:

4 for Useless assignment to local variable

lgtm-com[bot] commented 4 years ago

This pull request introduces 4 alerts and fixes 4 when merging c78327c711769a1c1ffe4de8a43d4b335aad340a into 659da3913c235dedb946b1465633ba4ffa228e07 - view on LGTM.com

new alerts:

4 for Useless assignment to local variable

fixed alerts:

4 for Useless assignment to local variable

lgtm-com[bot] commented 4 years ago

This pull request introduces 4 alerts and fixes 4 when merging e948e53841d1d310ac387bc70cd99494a9ee136d into 659da3913c235dedb946b1465633ba4ffa228e07 - view on LGTM.com

new alerts:

4 for Useless assignment to local variable

fixed alerts:

4 for Useless assignment to local variable

lgtm-com[bot] commented 4 years ago

This pull request introduces 4 alerts and fixes 4 when merging a4832eb1b7bf8150e5fcc6007a94ae6d47a70852 into 659da3913c235dedb946b1465633ba4ffa228e07 - view on LGTM.com

new alerts:

4 for Useless assignment to local variable

fixed alerts:

4 for Useless assignment to local variable

lgtm-com[bot] commented 4 years ago

This pull request introduces 4 alerts and fixes 4 when merging b6ddba157da308f312389269138dcb91172f2259 into 659da3913c235dedb946b1465633ba4ffa228e07 - view on LGTM.com

new alerts:

4 for Useless assignment to local variable

fixed alerts:

4 for Useless assignment to local variable

lgtm-com[bot] commented 4 years ago

This pull request introduces 4 alerts and fixes 4 when merging 133ec258a8e4a27723d56c7cf141d23161fa43af into 659da3913c235dedb946b1465633ba4ffa228e07 - view on LGTM.com

new alerts:

4 for Useless assignment to local variable

fixed alerts:

4 for Useless assignment to local variable

lgtm-com[bot] commented 4 years ago

This pull request introduces 4 alerts and fixes 4 when merging 0f4408f8d850ae0c872efde7c9e7cb28d7f16ad9 into 659da3913c235dedb946b1465633ba4ffa228e07 - view on LGTM.com

new alerts:

4 for Useless assignment to local variable

fixed alerts:

4 for Useless assignment to local variable

lgtm-com[bot] commented 4 years ago

This pull request introduces 4 alerts and fixes 4 when merging 44ecc6fc65a63b3334b4afca3747e94a8cb5c82f into 659da3913c235dedb946b1465633ba4ffa228e07 - view on LGTM.com

new alerts:

4 for Useless assignment to local variable

fixed alerts:

4 for Useless assignment to local variable

lgtm-com[bot] commented 4 years ago

This pull request introduces 4 alerts and fixes 4 when merging 5ade36d6caf48e724ba3a6d8765c17c1b4450119 into 659da3913c235dedb946b1465633ba4ffa228e07 - view on LGTM.com

new alerts:

4 for Useless assignment to local variable

fixed alerts:

4 for Useless assignment to local variable

zvonkok commented 4 years ago

/unhold

lgtm-com[bot] commented 4 years ago

This pull request introduces 4 alerts and fixes 4 when merging b63f00adb42d3201ee58741518e4d4b38480b277 into 659da3913c235dedb946b1465633ba4ffa228e07 - view on LGTM.com

new alerts:

4 for Useless assignment to local variable

fixed alerts:

4 for Useless assignment to local variable

lgtm-com[bot] commented 4 years ago

This pull request introduces 4 alerts and fixes 4 when merging a1498af04a431a81645e21e78222a225a854a2d1 into 659da3913c235dedb946b1465633ba4ffa228e07 - view on LGTM.com

new alerts:

4 for Useless assignment to local variable

fixed alerts:

4 for Useless assignment to local variable

lgtm-com[bot] commented 4 years ago

This pull request introduces 4 alerts and fixes 4 when merging b321328a523b4d8e7aa72857a61e136d19644087 into 659da3913c235dedb946b1465633ba4ffa228e07 - view on LGTM.com

new alerts:

4 for Useless assignment to local variable

fixed alerts:

4 for Useless assignment to local variable

lgtm-com[bot] commented 4 years ago

This pull request introduces 4 alerts and fixes 4 when merging 10fae7150e990da84ff164833c50b6304dd4a604 into 659da3913c235dedb946b1465633ba4ffa228e07 - view on LGTM.com

new alerts:

4 for Useless assignment to local variable

fixed alerts:

4 for Useless assignment to local variable

lgtm-com[bot] commented 4 years ago

This pull request introduces 4 alerts and fixes 4 when merging 84670ac42289b1d037dc7f778cc12935618da8d8 into 659da3913c235dedb946b1465633ba4ffa228e07 - view on LGTM.com

new alerts:

4 for Useless assignment to local variable

fixed alerts:

4 for Useless assignment to local variable

zvonkok commented 4 years ago

/retest

lgtm-com[bot] commented 4 years ago

This pull request introduces 4 alerts and fixes 4 when merging 902e4aa060ac28a8137aea3afdfe9d24bdbcf479 into 659da3913c235dedb946b1465633ba4ffa228e07 - view on LGTM.com

new alerts:

4 for Useless assignment to local variable

fixed alerts:

4 for Useless assignment to local variable

zvonkok commented 4 years ago

/retest

zvonkok commented 4 years ago

/retest

On Mon., Oct. 26, 2020, 22:01 OpenShift Merge Robot < notifications@github.com> wrote:

@zvonkok https://github.com/zvonkok: The following test failed, say /retest to rerun all failed tests: Test name Commit Details Rerun command ci/prow/e2e-aws-upgrade 902e4aa https://github.com/openshift-psap/special-resource-operator/commit/902e4aa060ac28a8137aea3afdfe9d24bdbcf479 link https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift-psap_special-resource-operator/35/pull-ci-openshift-psap-special-resource-operator-master-e2e-aws-upgrade/1320764808827506688 /test e2e-aws-upgrade

Full PR test history https://prow.ci.openshift.org/pr-history?org=openshift-psap&repo=special-resource-operator&pr=35. Your PR dashboard https://prow.ci.openshift.org/pr?query=is:pr+state:open+author:zvonkok.

Instructions for interacting with me using PR comments are available here https://git.k8s.io/community/contributors/guide/pull-requests.md. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue: repository. I understand the commands that are listed here https://go.k8s.io/bot-commands.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openshift-psap/special-resource-operator/pull/35#issuecomment-716821221, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA4NPNR4FI6W4GU4QBCLZ73SMXPT7ANCNFSM4SWLCGEQ .

openshift-ci-robot commented 4 years ago

@zvonkok: This pull request references Bugzilla bug 1883363, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

* bug is open, matching expected state (open) * bug target release (4.7.0) matches configured target release for branch (4.7.0) * bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to [this](https://github.com/openshift-psap/special-resource-operator/pull/35): >Bug 1883363: Simple kmod v2 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

zvonkok commented 4 years ago

/bugzilla refresh

openshift-ci-robot commented 4 years ago

@zvonkok: This pull request references Bugzilla bug 1883363, which is valid.

3 validation(s) were run on this bug

* bug is open, matching expected state (open) * bug target release (4.7.0) matches configured target release for branch (4.7.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to [this](https://github.com/openshift-psap/special-resource-operator/pull/35#issuecomment-718577015): >/bugzilla refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

lgtm-com[bot] commented 4 years ago

This pull request introduces 4 alerts and fixes 4 when merging cf8aa4845396401d481568931f234c17b19ad468 into 659da3913c235dedb946b1465633ba4ffa228e07 - view on LGTM.com

new alerts:

4 for Useless assignment to local variable

fixed alerts:

4 for Useless assignment to local variable

lgtm-com[bot] commented 4 years ago

This pull request introduces 4 alerts and fixes 4 when merging e86e42fc210ef5c0e276038c76ff29cc3cd6f84e into f2368fc7eac03cc7171b8ac612f390a95a3f8907 - view on LGTM.com

new alerts:

4 for Useless assignment to local variable

fixed alerts:

4 for Useless assignment to local variable

zvonkok commented 4 years ago

We need to get this merged to move forward with SRO and the enablement in 4.7 and z-stream 4.6

lgtm-com[bot] commented 4 years ago

This pull request introduces 4 alerts and fixes 4 when merging d802bda5ee93cb67a36bef52500c1609094d615a into f2368fc7eac03cc7171b8ac612f390a95a3f8907 - view on LGTM.com

new alerts:

4 for Useless assignment to local variable

fixed alerts:

4 for Useless assignment to local variable

lgtm-com[bot] commented 4 years ago

This pull request introduces 4 alerts and fixes 4 when merging 6888e45b41eb43aad50f68b03fea96e64c01e082 into f2368fc7eac03cc7171b8ac612f390a95a3f8907 - view on LGTM.com

new alerts:

4 for Useless assignment to local variable

fixed alerts:

4 for Useless assignment to local variable

zvonkok commented 4 years ago

/retest

lgtm-com[bot] commented 4 years ago

This pull request introduces 4 alerts and fixes 4 when merging aee320051f5db8397aa2b79d979e0cb1838a3335 into f2368fc7eac03cc7171b8ac612f390a95a3f8907 - view on LGTM.com

new alerts:

4 for Useless assignment to local variable

fixed alerts:

4 for Useless assignment to local variable

ArangoGutierrez commented 4 years ago

/priority critical-urgent

zvonkok commented 4 years ago

/retest

ArangoGutierrez commented 4 years ago

/test e2e-aws

ArangoGutierrez commented 4 years ago

/test e2e-aws

ArangoGutierrez commented 4 years ago

/retest

zvonkok commented 4 years ago

@ArangoGutierrez the update to go 1.14 in go mod triggered a go mod vendor so some changes in the vendor folder as well.

lgtm-com[bot] commented 4 years ago

This pull request introduces 4 alerts and fixes 4 when merging 1d923f7802128d100b9513f250ae9d27958c0938 into f2368fc7eac03cc7171b8ac612f390a95a3f8907 - view on LGTM.com

new alerts:

4 for Useless assignment to local variable

fixed alerts:

4 for Useless assignment to local variable

openshift-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, zvonkok

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift-psap/special-resource-operator/blob/master/OWNERS)~~ [zvonkok] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

openshift-psap / special-resource-operator-deprecated

Bug 1883363: Simple kmod v2 #35