search

openshift / api

Canonical location of the OpenShift API definition.
http://www.openshift.org
Apache License 2.0
95 stars 510 forks source link

CORS-3607: Add Azure CAPI installer to tech preview feature set #1967

Closed sadasu closed 2 months ago

openshift-ci-robot commented 2 months ago

@sadasu: This pull request references CORS-3607 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/api/pull/1967): > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 2 months ago

Hello @sadasu! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

sadasu commented 2 months ago

/test ?

openshift-ci[bot] commented 2 months ago

@sadasu: The following commands are available to trigger required jobs:

The following commands are available to trigger optional jobs:

Use /test all to run the following jobs that were automatically triggered:

In response to [this](https://github.com/openshift/api/pull/1967#issuecomment-2237178393): >/test ? Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
r4f4 commented 2 months ago

/lgtm

sadasu commented 2 months ago

@patrickdillon, @jhixson74, @JoelSpeed, @r4f4 , this is from a local test run with the API changes vendored in:

INFO Credentials loaded from file "/home/sdasu/.azure/osServicePrincipal.json" 
INFO Consuming Install Config from target directory 
WARNING FeatureSet "TechPreviewNoUpgrade" is enabled. This FeatureSet does not allow upgrades and may affect the supportability of the cluster. 
INFO Creating infrastructure resources...         
INFO Started local control plane with envtest     
INFO Stored kubeconfig for envtest in: /home/sdasu/clusters/azure-dev/.clusterapi_output/envtest.kubeconfig 
INFO Running process: Cluster API with args [-v=2 --diagnostics-address=0 --health-addr=127.0.0.1:41185 --webhook-port=42991 --webhook-cert-dir=/tmp/envtest-serving-certs-1855440080 --kubeconfig=/home/sdasu/clusters/azure-dev/.clusterapi_output/envtest.kubeconfig] 
INFO Running process: azure infrastructure provider with args [-v=2 --health-addr=127.0.0.1:40609 --webhook-port=39677 --webhook-cert-dir=/tmp/envtest-serving-certs-42129857 --feature-gates=MachinePool=false --kubeconfig=/home/sdasu/clusters/azure-dev/.clusterapi_output/envtest.kubeconfig] 
INFO Running process: azureaso infrastructure provider with args [-v=0 -metrics-addr=0 -health-addr=127.0.0.1:34805 -webhook-port=45835 -webhook-cert-dir=/tmp/envtest-serving-certs-1061655155 -crd-pattern= -crd-management=none] 
INFO Created manifest *v1.Namespace, namespace= name=openshift-cluster-api-guests 
INFO Created manifest *v1.Namespace, namespace= name=capz-system 
INFO Created manifest *v1.Secret, namespace=openshift-cluster-api-guests name=sdasu-test-api-xc79j-azure-client-secret 
INFO Created manifest *v1beta1.AzureClusterIdentity, namespace=openshift-cluster-api-guests name=sdasu-test-api-xc79j 
INFO Created manifest *v1beta1.Cluster, namespace=openshift-cluster-api-guests name=sdasu-test-api-xc79j 
INFO Created manifest *v1beta1.AzureCluster, namespace=openshift-cluster-api-guests name=sdasu-test-api-xc79j 
INFO Waiting up to 15m0s (until 2:59PM EDT) for network infrastructure to become ready... 
INFO Network infrastructure is ready
sadasu commented 2 months ago

/test e2e-azure

openshift-ci[bot] commented 2 months ago

@sadasu: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
JoelSpeed commented 2 months ago

Can we run a selection of Azure specific payload jobs against this to get some signal? Can we link out to sippy results showing install pass rates on tech preview clusters on Azure over time?

r4f4 commented 2 months ago

/payload-job periodic-ci-openshift-release-master-ci-4.17-e2e-azure-ovn-techpreview periodic-ci-openshift-release-master-ci-4.17-e2e-azure-ovn-techpreview-serial

openshift-ci[bot] commented 2 months ago

@r4f4: trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/92a99a80-459f-11ef-9412-81830860271d-0

r4f4 commented 2 months ago

Can we run a selection of Azure specific payload jobs against this to get some signal?

@sadasu we need an Installer PR with these o/api changes vendored in and then run the /payload-job command there.

patrickdillon commented 2 months ago

Can we run a selection of Azure specific payload jobs against this to get some signal? Can we link out to sippy results showing install pass rates on tech preview clusters on Azure over time?

@JoelSpeed These (particularly the ask for sippy results) sound like asks for moving from TechPreview->Default, so I wanted to make sure you weren't mixing that up with this PR, which is just adding to the TechPreview set.

JoelSpeed commented 2 months ago

Oops, yes, yes I was. Can we at least get a PR to the installer with the bump showing a TP Azure install succeeding then?

sadasu commented 2 months ago

Can we run a selection of Azure specific payload jobs against this to get some signal?

https://github.com/openshift/installer/pull/8754 is vendoring in these changes. I will post results from Azure CAPI install when it is done.

Can we link out to sippy results showing install pass rates on tech preview clusters on Azure over time?

As @patrickdillon mentioned, we will have it ready for when we try to make CAPI installs the default.

sadasu commented 2 months ago

Oops, yes, yes I was. Can we at least get a PR to the installer with the bump showing a TP Azure install succeeding then?

https://github.com/openshift/installer/pull/8754

patrickdillon commented 2 months ago

Oops, yes, yes I was. Can we at least get a PR to the installer with the bump showing a TP Azure install succeeding then?

openshift/installer#8754

@sadasu is also working on a pr to add techpreview presubmits, so we will need that to show this off in ci

r4f4 commented 2 months ago

Job run triggered from https://github.com/openshift/installer/pull/8754#issuecomment-2239164344 has a successful CAPI install with capi output artifacts

sadasu commented 2 months ago

Tech preview presubmit jobs were added by: https://github.com/openshift/release/pull/54583

https://github.com/openshift/installer/pull/8754's e2e-azure-ovn-techpreview had a successful run.

JoelSpeed commented 2 months ago

/lgtm /label acknowledge-critical-fixes-only

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, r4f4, sadasu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/api/blob/master/OWNERS)~~ [JoelSpeed] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-bot commented 2 months ago

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api This PR has been included in build ose-cluster-config-api-container-v4.17.0-202407221413.p0.gae4f370.assembly.stream.el9. All builds following this will include this PR.