openshift / api

Canonical location of the OpenShift API definition.
http://www.openshift.org
Apache License 2.0
95 stars 510 forks source link

Added Feature Gate for Bootc Update Path #1969

Closed inesqyx closed 2 months ago

inesqyx commented 2 months ago

This is for https://github.com/openshift/enhancements/pull/1631 The MCO is experimenting a bootc based OS content update path, to prepare for the deprecation of rpm-ostree. Before bootc is fully ready, we need to gate the path from default mainly for testing purposes.

openshift-ci[bot] commented 2 months ago

Hello @inesqyx! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

inesqyx commented 2 months ago

/retest-required

inesqyx commented 2 months ago

/test verify

inesqyx commented 2 months ago

/test verify

deads2k commented 2 months ago

/assign @yuqi-zhang

deads2k commented 2 months ago

/approve

verify is still broken.

inesqyx commented 2 months ago

/test e2e-aws-ovn-techpreview

openshift-ci[bot] commented 2 months ago

@inesqyx: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp d96a9f2a8c94a35680be23720110b743d5876720 link false /test e2e-gcp

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
yuqi-zhang commented 2 months ago

/lgtm

Just noting that this will likely not be customer facing for the next release or two, but safe to have for internal testing and CI

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, inesqyx, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/api/blob/master/OWNERS)~~ [deads2k] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-bot commented 2 months ago

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api This PR has been included in build ose-cluster-config-api-container-v4.18.0-202407240243.p0.g442f06d.assembly.stream.el9. All builds following this will include this PR.