Closed athiruma closed 1 month ago
Hello @athiruma! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.
Hi @athiruma. Thanks for your PR.
I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/cc @mandre @bparees
/lgtm /ok-to-test
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: athiruma, JoelSpeed
The full list of commands accepted by this bot can be found here.
The pull request process is described here
@athiruma: all tests passed!
Full PR test history. Your PR dashboard.
[ART PR BUILD NOTIFIER]
Distgit: ose-cluster-config-api This PR has been included in build ose-cluster-config-api-container-v4.18.0-202408091844.p0.g7f2da4c.assembly.stream.el9. All builds following this will include this PR.
This PR adds the support of capacity reservation in
AwsMachineProviderConfig
. A new field,CapacityReservationID
, is added. This ID is used while creating the corresponding AWS EC2 instance and the instance is added to the capacity reservation.