search

openshift / api

Canonical location of the OpenShift API definition.
http://www.openshift.org
Apache License 2.0
95 stars 510 forks source link

[wip] Remove alibaba #1990

Open jcpowermac opened 1 month ago

openshift-ci[bot] commented 1 month ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] commented 1 month ago

Hello @jcpowermac! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

jcpowermac commented 1 month ago

/test ?

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jcpowermac Once this PR has been reviewed and has the lgtm label, please assign bparees for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/api/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 1 month ago

@jcpowermac: The following commands are available to trigger required jobs:

The following commands are available to trigger optional jobs:

Use /test all to run the following jobs that were automatically triggered:

In response to [this](https://github.com/openshift/api/pull/1990#issuecomment-2266871911): >/test ? Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
jcpowermac commented 1 month ago

/test build /test e2e-aws-ovn

/test e2e-aws-ovn-techpreview

/test e2e-upgrade /test e2e-upgrade-minor /test images /test integration /test unit /test verify /test verify-client-go /test verify-crd-schema /test verify-deps

openshift-merge-robot commented 1 month ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
JoelSpeed commented 1 month ago

@jcpowermac How many components are left that are depending on these APIs that you're aware of?

jcpowermac commented 1 month ago

@jcpowermac How many components are left that are depending on these APIs that you're aware of?

Probably quite a few. I wanted to get an idea how difficult this would be to remove and start a discussion when we are ready.

Once the vsphere features for 4.18 are in a good place I can circle back to this effort.

JoelSpeed commented 1 month ago

I had a chat with David and we are happy to remove the API, if the tests can go green as it were, so, preferable we remove all the underlying operator code first and make this the final part

openshift-ci[bot] commented 1 month ago

@jcpowermac: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify-crd-schema 5c439451be3e132be6c24384ca708ef7a5e2d9d8 link true /test verify-crd-schema
ci/prow/integration 5c439451be3e132be6c24384ca708ef7a5e2d9d8 link true /test integration
ci/prow/minor-e2e-upgrade-minor 5c439451be3e132be6c24384ca708ef7a5e2d9d8 link true /test minor-e2e-upgrade-minor
ci/prow/minor-images 5c439451be3e132be6c24384ca708ef7a5e2d9d8 link true /test minor-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).