CORS-3695: Update the api for aws cluster hosted dns options

openshift-ci-robot commented 2 months ago

@barbacbd: This pull request references CORS-3695 which is a valid jira issue.

In response to [this](https://github.com/openshift/api/pull/2046): > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

barbacbd commented 2 months ago

/cc @sadasu /cc @patrickdillon

openshift-ci[bot] commented 2 months ago

Hello @barbacbd! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

barbacbd commented 2 months ago

/label platform/aws

barbacbd commented 2 months ago

/hold

openshift-ci[bot] commented 2 months ago

@barbacbd: The label(s) platform/aws cannot be applied, because the repository doesn't have them.

In response to [this](https://github.com/openshift/api/pull/2046#issuecomment-2377703104): >/label platform/aws Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

barbacbd commented 1 month ago

/hold cancel

barbacbd commented 1 month ago

I believe the issues in verify-crd-schema are false positives. Do you feel comfortable overriding that one @JoelSpeed ? Thank you.

JoelSpeed commented 1 month ago

error in machineconfiguration/v1/zz_generated.featuregated-crd-manifests/controllerconfigs.machineconfiguration.openshift.io/AWSClusterHostedDNS.yaml: ConditionsMustHaveProperSSATags: crd/controllerconfigs.machineconfiguration.openshift.io version/v1 field/^.status.condition must define valid condition properties: observedGeneration attribute is missing
        error in machineconfiguration/v1/zz_generated.featuregated-crd-manifests/controllerconfigs.machineconfiguration.openshift.io/AWSClusterHostedDNS.yaml: ConditionsMustHaveProperSSATags: crd/controllerconfigs.machineconfiguration.openshift.io version/v1 field/^.status.conditions must set x-kubernetes-list-type with value "map"
        error in machineconfiguration/v1/zz_generated.featuregated-crd-manifests/controllerconfigs.machineconfiguration.openshift.io/AWSClusterHostedDNS.yaml: ConditionsMustHaveProperSSATags: crd/controllerconfigs.machineconfiguration.openshift.io version/v1 field/^.status.conditions must set x-kubernetes-list-map-keys with single "type" value

These ones we should take a look at 🤔

The latter two, it is a case of

// +listType=map
// +listMapKey=type

The first, I don't think should be resolved right now

JoelSpeed commented 1 month ago

Looks like you'll need to fix the vendor here before we can proceed, but otherwise I'm happy to override the schema checker issues

JoelSpeed commented 1 month ago

/lgtm /override ci/prow/verify-crd-schema

Existing failures causing verify to fail that cannot be easily rectified

JoelSpeed commented 1 month ago

/lgtm cancel

Generated protobuf needs to be updated

openshift-ci[bot] commented 1 month ago

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-crd-schema

In response to [this](https://github.com/openshift/api/pull/2046#issuecomment-2388479370): >/lgtm >/override ci/prow/verify-crd-schema > >Existing failures causing verify to fail that cannot be easily rectified Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

barbacbd commented 1 month ago

/test e2e-aws-serial-techpreview

barbacbd commented 1 month ago

/test e2e-aws-ovn-hypershift

JoelSpeed commented 1 month ago

/override ci/prow/verify-crd-schema

Existing failures that cannot be safely rectified

/lgtm

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: barbacbd, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/api/blob/master/OWNERS)~~ [JoelSpeed] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

openshift-ci[bot] commented 1 month ago

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-crd-schema

In response to [this](https://github.com/openshift/api/pull/2046#issuecomment-2391798549): >/override ci/prow/verify-crd-schema > >Existing failures that cannot be safely rectified > >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 3f43768f3915e80ffd3fec21e9b37e84cdcb0091 and 2 for PR HEAD 77162c9fc9f39de3194129851684bbae82181367 in total

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 3f43768f3915e80ffd3fec21e9b37e84cdcb0091 and 2 for PR HEAD 77162c9fc9f39de3194129851684bbae82181367 in total

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 3f43768f3915e80ffd3fec21e9b37e84cdcb0091 and 2 for PR HEAD 77162c9fc9f39de3194129851684bbae82181367 in total

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 3f43768f3915e80ffd3fec21e9b37e84cdcb0091 and 2 for PR HEAD 77162c9fc9f39de3194129851684bbae82181367 in total

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 3f43768f3915e80ffd3fec21e9b37e84cdcb0091 and 2 for PR HEAD 77162c9fc9f39de3194129851684bbae82181367 in total

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 3f43768f3915e80ffd3fec21e9b37e84cdcb0091 and 2 for PR HEAD 77162c9fc9f39de3194129851684bbae82181367 in total

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 3f43768f3915e80ffd3fec21e9b37e84cdcb0091 and 2 for PR HEAD 77162c9fc9f39de3194129851684bbae82181367 in total

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 3f43768f3915e80ffd3fec21e9b37e84cdcb0091 and 2 for PR HEAD 77162c9fc9f39de3194129851684bbae82181367 in total

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 3f43768f3915e80ffd3fec21e9b37e84cdcb0091 and 2 for PR HEAD 77162c9fc9f39de3194129851684bbae82181367 in total

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 3f43768f3915e80ffd3fec21e9b37e84cdcb0091 and 2 for PR HEAD 77162c9fc9f39de3194129851684bbae82181367 in total

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 3f43768f3915e80ffd3fec21e9b37e84cdcb0091 and 2 for PR HEAD 77162c9fc9f39de3194129851684bbae82181367 in total

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 4c68b617719d433fb38f587ed813bb4fac732383 and 1 for PR HEAD 77162c9fc9f39de3194129851684bbae82181367 in total

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 4c68b617719d433fb38f587ed813bb4fac732383 and 2 for PR HEAD 77162c9fc9f39de3194129851684bbae82181367 in total

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 4c68b617719d433fb38f587ed813bb4fac732383 and 2 for PR HEAD 77162c9fc9f39de3194129851684bbae82181367 in total

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 4c68b617719d433fb38f587ed813bb4fac732383 and 2 for PR HEAD 77162c9fc9f39de3194129851684bbae82181367 in total

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 4c68b617719d433fb38f587ed813bb4fac732383 and 2 for PR HEAD 77162c9fc9f39de3194129851684bbae82181367 in total

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 4c68b617719d433fb38f587ed813bb4fac732383 and 2 for PR HEAD 77162c9fc9f39de3194129851684bbae82181367 in total

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 4c68b617719d433fb38f587ed813bb4fac732383 and 2 for PR HEAD 77162c9fc9f39de3194129851684bbae82181367 in total

JoelSpeed commented 1 month ago

/override ci/prow/verify-crd-schema

Existing failures that cannot be safely rectified

openshift-ci[bot] commented 1 month ago

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-crd-schema

In response to [this](https://github.com/openshift/api/pull/2046#issuecomment-2393217294): >/override ci/prow/verify-crd-schema > >Existing failures that cannot be safely rectified Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 4c68b617719d433fb38f587ed813bb4fac732383 and 2 for PR HEAD 77162c9fc9f39de3194129851684bbae82181367 in total

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD b1f700bdd8d22c4033be4e4e9ef751d89ade42e8 and 2 for PR HEAD 77162c9fc9f39de3194129851684bbae82181367 in total

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD b1f700bdd8d22c4033be4e4e9ef751d89ade42e8 and 2 for PR HEAD 77162c9fc9f39de3194129851684bbae82181367 in total

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD b1f700bdd8d22c4033be4e4e9ef751d89ade42e8 and 2 for PR HEAD 77162c9fc9f39de3194129851684bbae82181367 in total

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD b1f700bdd8d22c4033be4e4e9ef751d89ade42e8 and 2 for PR HEAD 77162c9fc9f39de3194129851684bbae82181367 in total

JoelSpeed commented 1 month ago

/override ci/prow/verify-crd-schema

openshift-ci[bot] commented 1 month ago

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-crd-schema

In response to [this](https://github.com/openshift/api/pull/2046#issuecomment-2393703278): >/override ci/prow/verify-crd-schema Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

barbacbd commented 1 month ago

/test e2e-aws-serial

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD b1f700bdd8d22c4033be4e4e9ef751d89ade42e8 and 2 for PR HEAD 77162c9fc9f39de3194129851684bbae82181367 in total

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD b1f700bdd8d22c4033be4e4e9ef751d89ade42e8 and 2 for PR HEAD 77162c9fc9f39de3194129851684bbae82181367 in total

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD b1f700bdd8d22c4033be4e4e9ef751d89ade42e8 and 2 for PR HEAD 77162c9fc9f39de3194129851684bbae82181367 in total

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD b1f700bdd8d22c4033be4e4e9ef751d89ade42e8 and 2 for PR HEAD 77162c9fc9f39de3194129851684bbae82181367 in total

openshift / api

CORS-3695: Update the api for aws cluster hosted dns options #2046