MGMT-18464: MGMT-18452: Add validations to make iSCSI disk eligible

[adriengentil]

This PR adds 2 checks before making iSSI disks be be eligible as installation disk.

MGMT-18464: Check the state of the disk, we need to ensure that it is "running" otherwise the installtion of RHCOS will fail on the disk.

MGMT-18464: Check if the discovery as been booted using iBFT, this check ensure that the iSCSI disk is actually a disk on which we will be able to boot from.

[openshift-ci-robot]

@adriengentil: This pull request references MGMT-18464 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/assisted-installer-agent/pull/819): >This PR adds 2 checks before making iSSI disks be be eligible as >installation disk. > >[MGMT-18464](https://issues.redhat.com//browse/MGMT-18464): Check the state of the disk, we need to ensure that it is >"running" otherwise the installtion of RHCOS will fail on the disk. > >[MGMT-18464](https://issues.redhat.com//browse/MGMT-18464): Check if the discovery as been booted using iBFT, this check >ensure that the iSCSI disk is actually a disk on which we will be able >to boot from. > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fassisted-installer-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriengentil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/assisted-installer-agent/blob/master/OWNERS)~~ [adriengentil] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

[adriengentil]

/cc @AlonaKaplan @eifrach @rccrdpccl

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 60.08%. Comparing base (d599caa) to head (6e3466d). Report is 1 commits behind head on master.

Additional details and impacted files

[](https://app.codecov.io/gh/openshift/assisted-installer-agent/pull/819?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) ```diff @@ Coverage Diff @@ ## master #819 +/- ## ========================================== + Coverage 59.44% 60.08% +0.63% ========================================== Files 74 74 Lines 3842 3888 +46 ========================================== + Hits 2284 2336 +52 + Misses 1389 1385 -4 + Partials 169 167 -2 ``` | [Files with missing lines](https://app.codecov.io/gh/openshift/assisted-installer-agent/pull/819?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) | Coverage Δ | | |---|---|---| | [src/inventory/disks.go](https://app.codecov.io/gh/openshift/assisted-installer-agent/pull/819?src=pr&el=tree&filepath=src%2Finventory%2Fdisks.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift#diff-c3JjL2ludmVudG9yeS9kaXNrcy5nbw==) | `91.33% <100.00%> (+2.98%)` | :arrow_up: |

[adriengentil]

/hold Might had to add some more tests

[adriengentil]

We should think about moving most of the logic to the service and use the agent to collect the information.

in this case the service won't make use of this information, except for validations, that's why I put them here. I don't expect this code to change often, so I think it's ok for the moment to have them here, I will think about moving them in the service if we need further updates and if we need more flexibility.

[adriengentil]

/retest

[openshift-ci[bot]]

@adriengentil: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

[eifrach]

/lgtm

[adriengentil]

/unhold

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: ose-agent-installer-node-agent This PR has been included in build ose-agent-installer-node-agent-container-v4.18.0-202411131039.p0.ga8a3349.assembly.stream.el9. All builds following this will include this PR.