openshift / boilerplate

Standardize conventions used for development and tooling across repositories
Apache License 2.0
14 stars 69 forks source link

KONFLUX-3729: swap to new base image on update #444

Closed jbpratt closed 1 month ago

jbpratt commented 1 month ago

operators should now start pointing to the konflux built base image, it is public and can be pulled from Jenkins without issue; this swap will be required when an operator begins onboarding onto konflux

❯ git reset --hard && git clean -d -f && BOILERPLATE_GIT_REPO=git@github.com:jbpratt/boilerplate.git BOILERPLATE_GIT_CLONE="git clone -b konflux-swapover-2" make boilerplate-update
HEAD is now at c1c56e3 Merge pull request #397 from jbpratt/bump-boilerplate-x
...
executing /var/home/bpratt/git/openshift/osd-example-operator/boilerplate/openshift/golang-osd-operator/update PRE
executing /var/home/bpratt/git/openshift/osd-example-operator/boilerplate/openshift/golang-osd-operator/update POST
Copying .codecov.yml to your repository root.
Copying OWNERS_ALIASES to your repository root.
Copying dependabot.yml to .github/dependabot.yml
Copying Dockerfile.olm-registry to build/Dockerfile.olm-registry
Overwriting /var/home/bpratt/git/openshift/osd-example-operator/build/Dockerfile's initial FROM with quay.io/redhat-services-prod/boilerplate/image:image-v5.0.3
...
❯ git diff build/Dockerfile
diff --git a/build/Dockerfile b/build/Dockerfile
index fcc09cc..cc91529 100644
--- a/build/Dockerfile
+++ b/build/Dockerfile
@@ -1,4 +1,4 @@
-FROM quay.io/app-sre/boilerplate:image-v5.0.3 AS builder
+FROM quay.io/redhat-services-prod/boilerplate/image:image-v5.0.3 AS builder

 WORKDIR /workspace
 # Copy the Go Modules manifests
...
openshift-ci-robot commented 1 month ago

@jbpratt: This pull request references KONFLUX-3729 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the feature to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/boilerplate/pull/444): >operators should now start pointing to the konflux built base image, it is public and can be pulled from Jenkins without issue; this swap will be required when an operator begins onboarding onto konflux > >``` >❯ git reset --hard && git clean -d -f && BOILERPLATE_GIT_REPO=git@github.com:jbpratt/boilerplate.git BOILERPLATE_GIT_CLONE="git clone -b konflux-swapover-2" make boilerplate-update >HEAD is now at c1c56e3 Merge pull request #397 from jbpratt/bump-boilerplate-x >... >executing /var/home/bpratt/git/openshift/osd-example-operator/boilerplate/openshift/golang-osd-operator/update PRE >executing /var/home/bpratt/git/openshift/osd-example-operator/boilerplate/openshift/golang-osd-operator/update POST >Copying .codecov.yml to your repository root. >Copying OWNERS_ALIASES to your repository root. >Copying dependabot.yml to .github/dependabot.yml >Copying Dockerfile.olm-registry to build/Dockerfile.olm-registry >Overwriting /var/home/bpratt/git/openshift/osd-example-operator/build/Dockerfile's initial FROM with quay.io/redhat-services-prod/boilerplate/image:image-v5.0.3 >... >❯ git diff build/Dockerfile >diff --git a/build/Dockerfile b/build/Dockerfile >index fcc09cc..cc91529 100644 >--- a/build/Dockerfile >+++ b/build/Dockerfile >@@ -1,4 +1,4 @@ >-FROM quay.io/app-sre/boilerplate:image-v5.0.3 AS builder >+FROM quay.io/redhat-services-prod/boilerplate/image:image-v5.0.3 AS builder > > WORKDIR /workspace > # Copy the Go Modules manifests >... >``` Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fboilerplate). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jbpratt commented 1 month ago

/hold

openshift-ci[bot] commented 1 month ago

@jbpratt: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
mmazur commented 1 month ago

/lgtm

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jbpratt, mmazur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/boilerplate/blob/master/OWNERS)~~ [mmazur] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jbpratt commented 1 month ago

/unhold