search

openshift / boilerplate

Standardize conventions used for development and tooling across repositories
Apache License 2.0
14 stars 69 forks source link

Exit early if skopeo binary not found #473

Closed joshbranham closed 4 days ago

joshbranham commented 1 week ago

Recently a user was trying to update boilerplate for a repo and getting unexpected output. It turned out that they did not have skopeo installed (neither did I), and had to install it first. This makes that case a bit more obvious by printing a message.

joshbranham commented 1 week ago

/test images pr-check

joshbranham commented 1 week ago

/test images pr-check

jbpratt commented 1 week ago

/retest

jbpratt commented 1 week ago

/lgtm

jharrington22 commented 4 days ago

/lgtm

openshift-ci[bot] commented 4 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jbpratt, jharrington22, joshbranham

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/boilerplate/blob/master/OWNERS)~~ [jharrington22] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 4 days ago

/retest-required

Remaining retests: 0 against base HEAD 5bc54000bbd68fd8ff51be941e4bd622b8855cc9 and 2 for PR HEAD 0ed6bd57140fc4e000a11dabc6a1f69c27884f62 in total

openshift-ci-robot commented 4 days ago

/retest-required

Remaining retests: 0 against base HEAD 5bc54000bbd68fd8ff51be941e4bd622b8855cc9 and 2 for PR HEAD 0ed6bd57140fc4e000a11dabc6a1f69c27884f62 in total

openshift-ci-robot commented 4 days ago

/retest-required

Remaining retests: 0 against base HEAD 5bc54000bbd68fd8ff51be941e4bd622b8855cc9 and 2 for PR HEAD 0ed6bd57140fc4e000a11dabc6a1f69c27884f62 in total

openshift-ci[bot] commented 4 days ago

@joshbranham: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).