search

openshift / cluster-etcd-operator

Operator to manage the lifecycle of the etcd members of an OpenShift cluster
Apache License 2.0
95 stars 127 forks source link

OCPBUGS-33495: return errors in wait-for-ceo #1260

Closed hasbro17 closed 4 months ago

hasbro17 commented 4 months ago

Fixes OCPBUGS-33495 as we were swallowing errors in the wait-for-ceo cmd

/cc @dusk125 @tjungblu

openshift-ci-robot commented 4 months ago

@hasbro17: This pull request references Jira Issue OCPBUGS-33495, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @geliu2016

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1260): >Fixes [OCPBUGS-33495](https://issues.redhat.com/browse/OCPBUGS-33495) as we were swallowing errors in the wait-for-ceo cmd > >/cc @dusk125 @tjungblu Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
hasbro17 commented 4 months ago

/cherry-pick release-4.15

openshift-cherrypick-robot commented 4 months ago

@hasbro17: once the present PR merges, I will cherry-pick it on top of release-4.15 in a new PR and assign it to you.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1260#issuecomment-2103836992): >/cherry-pick release-4.15 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
rphillips commented 4 months ago

/payload 4.17 ci blocking /payload 4.17 nightly blocking

openshift-ci[bot] commented 4 months ago

@rphillips: trigger 4 job(s) of type blocking for the ci release of OCP 4.17

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/efc3dbb0-0e8e-11ef-9936-c9253d6333a1-0

trigger 8 job(s) of type blocking for the nightly release of OCP 4.17

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/efc3dbb0-0e8e-11ef-9936-c9253d6333a1-1

rphillips commented 4 months ago

/hold

Going to hold this until payloads pass and there is some thorough testing. The different platforms could have been passing previously, and fail with this PR.

rphillips commented 4 months ago

/retest-required

openshift-ci[bot] commented 4 months ago

@hasbro17: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-qe-no-capabilities 8e131b58aed9068e5e4a7f73fbebec42d1dd6c22 link false /test e2e-gcp-qe-no-capabilities

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
rphillips commented 4 months ago

/hold cancel

payloads lgtm

hasbro17 commented 4 months ago

Shameless self-lgtm (since Allen and thomas are out) to see if this has any effects on the bootstrap failures in CI over the weekend.

/lgtm

openshift-ci[bot] commented 4 months ago

@hasbro17: you cannot LGTM your own PR.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1260#issuecomment-2105537005): >Shameless self-lgtm (since Allen and thomas are out) to see if this has any effects on the bootstrap failures in CI over the weekend. > >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
rphillips commented 4 months ago

/lgtm

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hasbro17, rphillips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-etcd-operator/blob/master/OWNERS)~~ [hasbro17] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 4 months ago

@hasbro17: Jira Issue OCPBUGS-33495: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-33495 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1260): >Fixes [OCPBUGS-33495](https://issues.redhat.com/browse/OCPBUGS-33495) as we were swallowing errors in the wait-for-ceo cmd > >/cc @dusk125 @tjungblu Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-cherrypick-robot commented 4 months ago

@hasbro17: new pull request created: #1261

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1260#issuecomment-2103836992): >/cherry-pick release-4.15 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-bot commented 4 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-etcd-operator-container-v4.17.0-202405130312.p0.g00a3a5c.assembly.stream.el9 for distgit cluster-etcd-operator. All builds following this will include this PR.