search

openshift / cluster-etcd-operator

Operator to manage the lifecycle of the etcd members of an OpenShift cluster
Apache License 2.0
95 stars 127 forks source link

TRT-1687: Revert #1268 "ETCD-606: Batch bundle revision rollout" #1270

Closed dgoodwin closed 3 months ago

dgoodwin commented 3 months ago

Reverts #1268 ; tracked by https://issues.redhat.com/browse/TRT-1687

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

Appear to be intermittently failing a pathological event test enough to take out 4.17 CI payloads

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

/payload-aggregate periodic-ci-openshift-release-master-ci-4.17-upgrade-from-stable-4.16-e2e-aws-ovn-upgrade 10

CC: @tjungblu

PR created by Revertomatic:tm:
openshift-ci-robot commented 3 months ago

@dgoodwin: This pull request references TRT-1687 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1270): > >Reverts #1268 ; tracked by https://issues.redhat.com/browse/TRT-1687 > >Per [OpenShift policy](https://github.com/openshift/enhancements/blob/master/enhancements/release/improving-ci-signal.md#quick-revert), we are reverting this breaking change to get CI and/or nightly payloads flowing again. > >Appear to be intermittently failing a pathological event test enough to take out 4.17 CI payloads > >To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem: > >``` >/payload-aggregate periodic-ci-openshift-release-master-ci-4.17-upgrade-from-stable-4.16-e2e-aws-ovn-upgrade 10 >``` > >CC: @tjungblu > >
>PR created by Revertomatic:tm: >
> Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
tjungblu commented 3 months ago

/lgtm

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin, tjungblu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-etcd-operator/blob/master/OWNERS)~~ [tjungblu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dgoodwin commented 3 months ago

/override ci/prow/e2e-operator-fips /override ci/prow/e2e-operator /override ci/prow/e2e-aws-ovn-single-node /override ci/prow/e2e-aws-ovn-serial /override ci/prow/e2e-aws-ovn-etcd-scaling /override ci/prow/e2e-aws-etcd-recovery /override ci/prow/e2e-agnostic-ovn /override ci/prow/e2e-gcp-qe-no-capabilities /override ci/prow/e2e-agnostic-ovn-upgrade

openshift-ci[bot] commented 3 months ago

@dgoodwin: Overrode contexts on behalf of dgoodwin: ci/prow/e2e-agnostic-ovn, ci/prow/e2e-agnostic-ovn-upgrade, ci/prow/e2e-aws-etcd-recovery, ci/prow/e2e-aws-ovn-etcd-scaling, ci/prow/e2e-aws-ovn-serial, ci/prow/e2e-aws-ovn-single-node, ci/prow/e2e-gcp-qe-no-capabilities, ci/prow/e2e-operator, ci/prow/e2e-operator-fips

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1270#issuecomment-2139377271): >/override ci/prow/e2e-operator-fips >/override ci/prow/e2e-operator >/override ci/prow/e2e-aws-ovn-single-node >/override ci/prow/e2e-aws-ovn-serial >/override ci/prow/e2e-aws-ovn-etcd-scaling >/override ci/prow/e2e-aws-etcd-recovery >/override ci/prow/e2e-agnostic-ovn >/override ci/prow/e2e-gcp-qe-no-capabilities >/override ci/prow/e2e-agnostic-ovn-upgrade > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 3 months ago

@dgoodwin: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 3 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-etcd-operator-container-v4.17.0-202405301713.p0.g0b37c81.assembly.stream.el9 for distgit cluster-etcd-operator. All builds following this will include this PR.