search

openshift / cluster-etcd-operator

Operator to manage the lifecycle of the etcd members of an OpenShift cluster
Apache License 2.0
95 stars 127 forks source link

ETCD-607: gate leaf cert generation (with bundle revision) #1275

Closed tjungblu closed 3 months ago

tjungblu commented 3 months ago

/hold

this is a slight improvement over #1269 by not having a two-phase commit issue on storing the revision

openshift-ci-robot commented 3 months ago

@tjungblu: This pull request references ETCD-607 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1275): >/hold > >this is a slight improvement over #1269 by not having a two-phase commit issue on storing the revision Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
tjungblu commented 3 months ago

/payload 4.17 nightly blocking /test e2e-aws-ovn-single-node /test e2e-metal-assisted /test e2e-metal-ipi-ovn-ipv6 /payload-aggregate periodic-ci-openshift-release-master-nightly-4.17-e2e-metal-ovn-assisted 10

openshift-ci[bot] commented 3 months ago

@tjungblu: trigger 8 job(s) of type blocking for the nightly release of OCP 4.17

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a44563b0-2a3c-11ef-8671-a083945c426a-0

trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a44563b0-2a3c-11ef-8671-a083945c426a-1

tjungblu commented 3 months ago

/retest

tjungblu commented 3 months ago

/hold cancel

tjungblu commented 3 months ago

/payload 4.17 nightly blocking /payload-aggregate periodic-ci-openshift-release-master-nightly-4.17-e2e-metal-ovn-assisted 10

openshift-ci[bot] commented 3 months ago

@tjungblu: trigger 8 job(s) of type blocking for the nightly release of OCP 4.17

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/4c832c00-2d3b-11ef-94ad-73baca02afa0-0

trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/4c832c00-2d3b-11ef-94ad-73baca02afa0-1

hasbro17 commented 3 months ago

/lgtm

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hasbro17, tjungblu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-etcd-operator/blob/master/OWNERS)~~ [hasbro17,tjungblu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 3 months ago

/retest-required

Remaining retests: 0 against base HEAD cd4c841cc897423a41972ba4be6bb713a266b230 and 2 for PR HEAD 1d0ff3f5de7399c2cd930ab6c079d5ad953f9b5e in total

tjungblu commented 3 months ago

Thanks! I'll wait for the aggregation results once more, the job has to retest anyway :)

/hold

tjungblu commented 3 months ago

/hold cancel

all good, @dgoodwin / @neisw fyi we're going to merge this - which I hope will not cause any further issues this time around.

dgoodwin commented 3 months ago

Thanks for investigating and fixing+testing thoroughly, sounds good to us.

openshift-ci[bot] commented 3 months ago

@tjungblu: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 3 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-etcd-operator-container-v4.17.0-202406181842.p0.g29055c7.assembly.stream.el9 for distgit cluster-etcd-operator. All builds following this will include this PR.