search

openshift / cluster-etcd-operator

Operator to manage the lifecycle of the etcd members of an OpenShift cluster
Apache License 2.0
95 stars 127 forks source link

ETCD-593: Enable experimental-stop-grpc-service-on-defrag #1279

Open Elbehery opened 3 months ago

Elbehery commented 3 months ago

This PR enable --experimental-stop-grpc-service-on-defrag on OCP/Etcd.

cc @openshift/openshift-team-etcd

openshift-ci-robot commented 3 months ago

@Elbehery: This pull request references ETCD-593 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1279): >This PR enable `--experimental-stop-grpc-service-on-defrag` on OCP/Etcd. > >cc @openshift/openshift-team-etcd > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
dusk125 commented 3 months ago

/lgtm

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dusk125, Elbehery

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-etcd-operator/blob/master/OWNERS)~~ [Elbehery,dusk125] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
hasbro17 commented 3 months ago

/hold

We need to test and validate whether this flag is actually stopping grpc on the degraded member or if we need to enable something on the etcd client side as well. https://github.com/kubernetes/kubernetes/pull/124787

openshift-ci[bot] commented 3 months ago

@Elbehery: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-qe-no-capabilities b42f48efd27f3815a447663a7a501535d56342ee link false /test e2e-gcp-qe-no-capabilities
ci/prow/e2e-operator-fips b42f48efd27f3815a447663a7a501535d56342ee link false /test e2e-operator-fips
ci/prow/e2e-aws-etcd-recovery b42f48efd27f3815a447663a7a501535d56342ee link false /test e2e-aws-etcd-recovery
ci/prow/e2e-aws-ovn-etcd-scaling b42f48efd27f3815a447663a7a501535d56342ee link unknown /test e2e-aws-ovn-etcd-scaling

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 1 week ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

dusk125 commented 1 week ago

/remove-lifecycle stale