search

openshift / cluster-etcd-operator

Operator to manage the lifecycle of the etcd members of an OpenShift cluster
Apache License 2.0
95 stars 127 forks source link

OCPBUGS-36407: Rename Dockerfile.rhel7 to Dockerfile.ocp #1289

Closed ashwindasr closed 2 months ago

ashwindasr commented 2 months ago

Refactor name to Dockerfile.ocp as a better, version independent, alternative to Dockerfile.rhel7 since contents are actually rhel9.

Please follow up with other changes in this/other repos if necessary. ART has set a fallback for this component in 4.17, hence no other configuration is required from ART's side for 4.17.

openshift-ci-robot commented 2 months ago

@ashwindasr: This pull request references Jira Issue OCPBUGS-36407, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @geliu2016

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1289): >Refactor name to `Dockerfile.ocp` as a better version independent alternative to `Dockerfile.rhel7` since contents are actually rhel9. > >CI PR: https://github.com/openshift/release/pull/53877 > >Please follow up with other changes in this/other repos if necessary. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 2 months ago

@ashwindasr: This pull request references Jira Issue OCPBUGS-36407, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @geliu2016

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1289): >Refactor name to `Dockerfile.ocp` as a better version independent alternative to `Dockerfile.rhel7` since contents are actually rhel9. > >CI PR: https://github.com/openshift/release/pull/53877 > >Please follow up with other changes in this/other repos if necessary. ART has set a [fallback](https://github.com/openshift-eng/ocp-build-data/pull/5033) for this component, hence no other configuration is required from ART's side Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
ashwindasr commented 2 months ago

Thanks @geliu2016

But looks like https://github.com/openshift/release/pull/53877 needs to merge first for the tests to pass?

geliu2016 commented 2 months ago

Thanks @geliu2016

But looks like openshift/release#53877 needs to merge first for the tests to pass?

Hi ashwindasr, pre-merge-tested is need to be done before pr merge, code review may ensure this fix before code merge.

tjungblu commented 2 months ago

/lgtm

openshift-ci-robot commented 2 months ago

/retest-required

Remaining retests: 0 against base HEAD d82a13d2456cb89d6c64b508f80f7f6c36166c98 and 2 for PR HEAD cd33ec3ca23357d96fc3e65622724dfa493a0cca in total

tjungblu commented 2 months ago

/retest-required

tjungblu commented 2 months ago

@ashwindasr there seems some verification that hardcodes the docker file: https://github.com/openshift/cluster-etcd-operator/blob/master/Makefile#L34

openshift-ci-robot commented 2 months ago

@ashwindasr: This pull request references Jira Issue OCPBUGS-36407, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @geliu2016

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1289): >Refactor name to `Dockerfile.ocp` as a better, version independent, alternative to `Dockerfile.rhel7` since contents are actually rhel9. > >- [x] CI PR: https://github.com/openshift/release/pull/53877 > >Please follow up with other changes in this/other repos if necessary. ART has set a [fallback](https://github.com/openshift-eng/ocp-build-data/pull/5033) for this component in 4.17, hence no other configuration is required from ART's side for 4.17. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
tjungblu commented 2 months ago

/lgtm

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashwindasr, geliu2016, tjungblu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-etcd-operator/blob/master/OWNERS)~~ [tjungblu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ashwindasr commented 2 months ago

/retest

openshift-ci-robot commented 2 months ago

@ashwindasr: Jira Issue OCPBUGS-36407: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-36407 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1289): >Refactor name to `Dockerfile.ocp` as a better, version independent, alternative to `Dockerfile.rhel7` since contents are actually rhel9. > >- [x] CI PR: https://github.com/openshift/release/pull/53877 > >Please follow up with other changes in this/other repos if necessary. ART has set a [fallback](https://github.com/openshift-eng/ocp-build-data/pull/5033) for this component in 4.17, hence no other configuration is required from ART's side for 4.17. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 2 months ago

@ashwindasr: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-qe-no-capabilities cd33ec3ca23357d96fc3e65622724dfa493a0cca link false /test e2e-gcp-qe-no-capabilities
ci/prow/e2e-metal-ovn-sno-cert-rotation-shutdown 8c9c2986d01d1b953c4450e8b19627d687d51c78 link false /test e2e-metal-ovn-sno-cert-rotation-shutdown

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 2 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-etcd-operator-container-v4.17.0-202407022311.p0.g9d7b786.assembly.stream.el9 for distgit cluster-etcd-operator. All builds following this will include this PR.