search

openshift / cluster-etcd-operator

Operator to manage the lifecycle of the etcd members of an OpenShift cluster
Apache License 2.0
95 stars 127 forks source link

ETCD-604: Prune revisioned resources #1292

Closed tjungblu closed 2 months ago

tjungblu commented 2 months ago

This cleans up some certificates that were copied but are not longer needed. At the same time, updating the docs to the state of today.

openshift-ci-robot commented 2 months ago

@tjungblu: This pull request references ETCD-604 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1292): >This cleans up some certificates that were copied but are not longer needed. At the same time, updating the docs to the state of today. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
tjungblu commented 2 months ago

seems kube-apiserver has this bundle hardcoded (wtf)

  - lastTransitionTime: "2024-07-03T15:26:51Z"
    message: |-
      GuardControllerDegraded: [Missing operand on node ip-10-0-107-23.us-east-2.compute.internal, Missing operand on node ip-10-0-121-222.us-east-2.compute.internal, Missing operand on node ip-10-0-8-249.us-east-2.compute.internal]
      InstallerControllerDegraded: missing required resources: [configmaps: etcd-serving-ca-1,kube-apiserver-audit-policies-1,kubelet-serving-ca-1,sa-token-signing-certs-1, secrets: etcd-client-1,localhost-recovery-client-token-1,localhost-recovery-serving-certkey-1]
      RevisionControllerDegraded: configmap "etcd-serving-ca" not found
    reason: GuardController_SyncError::InstallerController_Error::RevisionController_ContentCreationError
    status: "True"

edit: https://github.com/openshift/cluster-kube-apiserver-operator/blob/a88d4ae8e0a9c8d3457e8488d9da7f04680240d3/pkg/operator/resourcesynccontroller/resourcesynccontroller.go#L27-L32

I'll probably open a PR over there to use the "proper" bundle

tjungblu commented 2 months ago

okay, I pass, this is littered almost everywhere in openshift by now: https://github.com/search?q=org%3Aopenshift%20%22etcd-serving-ca%22&type=code

reverting this part

tjungblu commented 2 months ago

/retest

hasbro17 commented 2 months ago

/lgtm /retest-required

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hasbro17, tjungblu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-etcd-operator/blob/master/OWNERS)~~ [hasbro17,tjungblu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 2 months ago

/retest-required

Remaining retests: 0 against base HEAD f161fde0797d68765875927c5ca762dc13378855 and 2 for PR HEAD 7352ccc299145c2a423926aa134c45538bb81bb5 in total

tjungblu commented 2 months ago

/override ci/prow/e2e-aws-ovn-etcd-scaling

this also fails in other PRs

openshift-ci[bot] commented 2 months ago

@tjungblu: Overrode contexts on behalf of tjungblu: ci/prow/e2e-aws-ovn-etcd-scaling

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1292#issuecomment-2242375482): >/override ci/prow/e2e-aws-ovn-etcd-scaling > >this also fails in other PRs > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
tjungblu commented 2 months ago

/label acknowledge-critical-fixes-only

shift week's over :)

openshift-ci-robot commented 2 months ago

/retest-required

Remaining retests: 0 against base HEAD c33725e4bd463cf4597e710330b7747a1c051911 and 2 for PR HEAD 7352ccc299145c2a423926aa134c45538bb81bb5 in total

openshift-ci[bot] commented 2 months ago

@tjungblu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-operator-fips 7352ccc299145c2a423926aa134c45538bb81bb5 link false /test e2e-operator-fips
ci/prow/e2e-metal-ovn-ha-cert-rotation-shutdown 7352ccc299145c2a423926aa134c45538bb81bb5 link false /test e2e-metal-ovn-ha-cert-rotation-shutdown
ci/prow/e2e-metal-ovn-sno-cert-rotation-shutdown 7352ccc299145c2a423926aa134c45538bb81bb5 link false /test e2e-metal-ovn-sno-cert-rotation-shutdown
ci/prow/e2e-aws-etcd-recovery 7352ccc299145c2a423926aa134c45538bb81bb5 link false /test e2e-aws-etcd-recovery
ci/prow/e2e-aws-etcd-certrotation 7352ccc299145c2a423926aa134c45538bb81bb5 link false /test e2e-aws-etcd-certrotation

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
tjungblu commented 2 months ago

/override ci/prow/e2e-aws-ovn-single-node

unrelated conformance failure

openshift-ci[bot] commented 2 months ago

@tjungblu: Overrode contexts on behalf of tjungblu: ci/prow/e2e-aws-ovn-single-node

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1292#issuecomment-2242959568): >/override ci/prow/e2e-aws-ovn-single-node > >unrelated conformance failure Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-bot commented 2 months ago

[ART PR BUILD NOTIFIER]

Distgit: cluster-etcd-operator This PR has been included in build cluster-etcd-operator-container-v4.17.0-202407221718.p0.gd7596d0.assembly.stream.el9. All builds following this will include this PR.