search

openshift / cluster-etcd-operator

Operator to manage the lifecycle of the etcd members of an OpenShift cluster
Apache License 2.0
95 stars 127 forks source link

Revert "OCPBUGS-36621: add etcd-all-bundles to cvo create-only" #1295

Closed tjungblu closed 2 months ago

tjungblu commented 2 months ago

Reverts openshift/cluster-etcd-operator#1293

leaving this here as this is not effectively fixing the issue

openshift-ci-robot commented 2 months ago

@tjungblu: This pull request references Jira Issue OCPBUGS-36621, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @geliu2016

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1295): >Reverts openshift/cluster-etcd-operator#1293 > >leaving this here as this is not effectively fixing the issue Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
hasbro17 commented 2 months ago

/lgtm

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hasbro17, tjungblu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-etcd-operator/blob/master/OWNERS)~~ [hasbro17,tjungblu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 2 months ago

/retest-required

Remaining retests: 0 against base HEAD f161fde0797d68765875927c5ca762dc13378855 and 2 for PR HEAD fbecd1562949166b494ed4e918d8e8871827b082 in total

hasbro17 commented 2 months ago

/label acknowledge-critical-fixes-only /retest-required

We need this to revert back to the old behavior of when the etcd-all-bundles configmap is missing altogether. Basically change the signal from https://issues.redhat.com/browse/OCPBUGS-36929 to https://issues.redhat.com/browse/OCPBUGS-36621

That way we can fix the stall in the cert controller on the missing configmap symptom.

hasbro17 commented 2 months ago

/retest-required

openshift-ci[bot] commented 2 months ago

@tjungblu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ovn-sno-cert-rotation-shutdown fbecd1562949166b494ed4e918d8e8871827b082 link false /test e2e-metal-ovn-sno-cert-rotation-shutdown
ci/prow/e2e-aws-etcd-recovery fbecd1562949166b494ed4e918d8e8871827b082 link false /test e2e-aws-etcd-recovery
ci/prow/e2e-operator-fips fbecd1562949166b494ed4e918d8e8871827b082 link false /test e2e-operator-fips
ci/prow/e2e-metal-ovn-ha-cert-rotation-shutdown fbecd1562949166b494ed4e918d8e8871827b082 link false /test e2e-metal-ovn-ha-cert-rotation-shutdown

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
hasbro17 commented 2 months ago

/retest-required

hasbro17 commented 2 months ago

The scaling job failure is orthogonal and needs to be fixed to not rely on CPMS's status.ReadyReplicas which can sometimes not go to 4 and stall the test. https://issues.redhat.com/browse/ETCD-637 But that's for another PR in origin so will override for now as the revert is unrelated to that.

/override ci/prow/e2e-aws-ovn-etcd-scaling

openshift-ci[bot] commented 2 months ago

@hasbro17: Overrode contexts on behalf of hasbro17: ci/prow/e2e-aws-ovn-etcd-scaling

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1295#issuecomment-2237213810): >The scaling job failure is orthogonal and needs to be fixed to not rely on CPMS's status.ReadyReplicas which can sometimes not go to 4 and stall the test. >https://issues.redhat.com/browse/ETCD-637 >But that's for another PR in origin so will override for now as the revert is unrelated to that. > >/override ci/prow/e2e-aws-ovn-etcd-scaling Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 2 months ago

@tjungblu: Jira Issue OCPBUGS-36621: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-36621 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1295): >Reverts openshift/cluster-etcd-operator#1293 > >leaving this here as this is not effectively fixing the issue Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 2 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-etcd-operator-container-v4.17.0-202407182142.p0.g99ad889.assembly.stream.el9 for distgit cluster-etcd-operator. All builds following this will include this PR.