search

openshift / cluster-etcd-operator

Operator to manage the lifecycle of the etcd members of an OpenShift cluster
Apache License 2.0
95 stars 127 forks source link

ETCD-636: expose PruneOpts #1297

Closed Elbehery closed 2 months ago

Elbehery commented 2 months ago

This PR exposes pruneOpts struct.

This is part of https://issues.redhat.com/browse/ETCD-636

cc @openshift/openshift-team-etcd

openshift-ci-robot commented 2 months ago

@Elbehery: This pull request references ETCD-636 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1297): >This PR exposes `pruneOpts` struct. > >This is part of https://issues.redhat.com/browse/ETCD-636 > >cc @openshift/openshift-team-etcd Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
tjungblu commented 2 months ago

/lgtm

openshift-ci-robot commented 2 months ago

/retest-required

Remaining retests: 0 against base HEAD d7596d074dcd6546f2b3410f12fa61b3caad5b4e and 2 for PR HEAD d6d7e1f970e434bed54bf7f6c71f51a3c470df7b in total

tjungblu commented 2 months ago

/override ci/prow/e2e-aws-ovn-etcd-scaling /override ci/prow/e2e-aws-ovn-single-node

openshift-ci[bot] commented 2 months ago

@tjungblu: Overrode contexts on behalf of tjungblu: ci/prow/e2e-aws-ovn-etcd-scaling, ci/prow/e2e-aws-ovn-single-node

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1297#issuecomment-2245022497): >/override ci/prow/e2e-aws-ovn-etcd-scaling >/override ci/prow/e2e-aws-ovn-single-node > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
tjungblu commented 2 months ago

/override ci/prow/e2e-aws-ovn-etcd-scaling /override ci/prow/e2e-aws-ovn-single-node

openshift-ci[bot] commented 2 months ago

@tjungblu: Overrode contexts on behalf of tjungblu: ci/prow/e2e-aws-ovn-etcd-scaling, ci/prow/e2e-aws-ovn-single-node

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1297#issuecomment-2245142792): >/override ci/prow/e2e-aws-ovn-etcd-scaling >/override ci/prow/e2e-aws-ovn-single-node Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
Elbehery commented 2 months ago

creating a cluster with this PR atop to debug the failure in TestPeriodicBackupHappyPath

tjungblu commented 2 months ago

/lgtm

tjungblu commented 2 months ago

/override ci/prow/e2e-aws-ovn-etcd-scaling /override ci/prow/e2e-aws-ovn-single-node

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Elbehery, tjungblu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-etcd-operator/blob/master/OWNERS)~~ [Elbehery,tjungblu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 2 months ago

@tjungblu: Overrode contexts on behalf of tjungblu: ci/prow/e2e-aws-ovn-etcd-scaling, ci/prow/e2e-aws-ovn-single-node

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1297#issuecomment-2245454481): >/override ci/prow/e2e-aws-ovn-etcd-scaling >/override ci/prow/e2e-aws-ovn-single-node Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 2 months ago

/retest-required

Remaining retests: 0 against base HEAD ceb5dbfdff3e98c0560bc7d1fecbfd150dac9be6 and 2 for PR HEAD 7cc8c1f06027e98fdc210ad3465473e8954e5633 in total

Elbehery commented 2 months ago

/retest-required

Elbehery commented 2 months ago

/retest-required

Elbehery commented 2 months ago

/override ci/prow/e2e-aws-ovn-etcd-scaling /override ci/prow/e2e-aws-ovn-single-node

openshift-ci[bot] commented 2 months ago

@Elbehery: Overrode contexts on behalf of Elbehery: ci/prow/e2e-aws-ovn-etcd-scaling, ci/prow/e2e-aws-ovn-single-node

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1297#issuecomment-2246408005): >/override ci/prow/e2e-aws-ovn-etcd-scaling >/override ci/prow/e2e-aws-ovn-single-node Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 2 months ago

@Elbehery: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ovn-ha-cert-rotation-shutdown 7cc8c1f06027e98fdc210ad3465473e8954e5633 link false /test e2e-metal-ovn-ha-cert-rotation-shutdown
ci/prow/e2e-aws-etcd-certrotation 7cc8c1f06027e98fdc210ad3465473e8954e5633 link false /test e2e-aws-etcd-certrotation
ci/prow/e2e-aws-etcd-recovery 7cc8c1f06027e98fdc210ad3465473e8954e5633 link false /test e2e-aws-etcd-recovery
ci/prow/e2e-metal-ovn-sno-cert-rotation-shutdown 7cc8c1f06027e98fdc210ad3465473e8954e5633 link false /test e2e-metal-ovn-sno-cert-rotation-shutdown

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 2 months ago

[ART PR BUILD NOTIFIER]

Distgit: cluster-etcd-operator This PR has been included in build cluster-etcd-operator-container-v4.18.0-202407240243.p0.g3ee038d.assembly.stream.el9. All builds following this will include this PR.