search

openshift / cluster-etcd-operator

Operator to manage the lifecycle of the etcd members of an OpenShift cluster
Apache License 2.0
95 stars 127 forks source link

ETCD-636: add backup server sidecar #1298

Closed Elbehery closed 2 months ago

Elbehery commented 2 months ago

This PR adds backup-server sidecar template.

This is part of https://issues.redhat.com/browse/ETCD-636

cc @openshift/openshift-team-etcd

openshift-ci-robot commented 2 months ago

@Elbehery: This pull request references ETCD-635 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1298): >This PR adds `backup-server` sidecar template. > >This is part of https://issues.redhat.com/browse/ETCD-636 > >cc @openshift/openshift-team-etcd Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Elbehery

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-etcd-operator/blob/master/OWNERS)~~ [Elbehery] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
Elbehery commented 2 months ago

/label tide/merge-method-squash

Elbehery commented 2 months ago

/retest-required

Elbehery commented 2 months ago

/retest-required

Elbehery commented 2 months ago

e2e operator failed due to empty args 

  - name: etcd-backup-server
    image: registry.build03.ci.openshift.org/ci-op-r34mdkbx/stable@sha256:2ae71921641f510e0dcd434b00560b821a9e87aea39993907a219ae573835732
    imagePullPolicy: IfNotPresent
    terminationMessagePolicy: FallbackToLogsOnError
    command: [cluster-etcd-operator]
    args:
    - backup-server

    - --timezone=
    - --schedule=
    -

fixing ...

tjungblu commented 2 months ago

@Elbehery maybe it makes it easier if all list items are indented the same, you can also add the backup-server in the golang code instead of the template

Elbehery commented 2 months ago

@Elbehery maybe it makes it easier if all list items are indented the same, you can also add the backup-server in the golang code instead of the template

hmmm .. so the template would contain only the container definition, but not the args, correct ?

Elbehery commented 2 months ago

yes u r right 👍🏽 thxxx

Elbehery commented 2 months ago

/retest-required

Elbehery commented 2 months ago

/retest-required

openshift-ci[bot] commented 2 months ago

@Elbehery: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-etcd-certrotation 2123e073c586aedac46008f3330eb1a58670d889 link false /test e2e-aws-etcd-certrotation
ci/prow/e2e-metal-ovn-sno-cert-rotation-shutdown 2123e073c586aedac46008f3330eb1a58670d889 link false /test e2e-metal-ovn-sno-cert-rotation-shutdown
ci/prow/e2e-aws-ovn-etcd-scaling 2123e073c586aedac46008f3330eb1a58670d889 link true /test e2e-aws-ovn-etcd-scaling
ci/prow/e2e-aws-etcd-recovery 2123e073c586aedac46008f3330eb1a58670d889 link false /test e2e-aws-etcd-recovery
ci/prow/e2e-metal-ovn-ha-cert-rotation-shutdown 2123e073c586aedac46008f3330eb1a58670d889 link false /test e2e-metal-ovn-ha-cert-rotation-shutdown

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
Elbehery commented 2 months ago

/hold

Elbehery commented 2 months ago

closing in favor of https://github.com/openshift/cluster-etcd-operator/pull/1301

openshift-ci-robot commented 1 month ago

@Elbehery: This pull request references ETCD-636 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1298): >This PR adds `backup-server` sidecar template. > >This is part of https://issues.redhat.com/browse/ETCD-636 > >cc @openshift/openshift-team-etcd Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.