search

openshift / cluster-etcd-operator

Operator to manage the lifecycle of the etcd members of an OpenShift cluster
Apache License 2.0
95 stars 127 forks source link

only update envvar listeners on real changes #1299

Closed tjungblu closed 2 months ago

tjungblu commented 2 months ago

While reviewing the changes in the backup PR, I've seen that I've introduced unnecessary listener updates during the lock refactoring two years ago.

This PR ensures we return early when the envvars has not changed.

openshift-merge-robot commented 2 months ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tjungblu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-etcd-operator/blob/master/OWNERS)~~ [tjungblu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 2 months ago

@tjungblu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-operator-fips 590a54c5ada39a5e4f7e80684728064d4bbd2eaa link false /test e2e-operator-fips
ci/prow/e2e-aws-ovn-etcd-scaling 590a54c5ada39a5e4f7e80684728064d4bbd2eaa link true /test e2e-aws-ovn-etcd-scaling
ci/prow/e2e-aws-etcd-recovery 590a54c5ada39a5e4f7e80684728064d4bbd2eaa link false /test e2e-aws-etcd-recovery
ci/prow/unit 590a54c5ada39a5e4f7e80684728064d4bbd2eaa link true /test unit
ci/prow/e2e-agnostic-ovn 590a54c5ada39a5e4f7e80684728064d4bbd2eaa link true /test e2e-agnostic-ovn
ci/prow/e2e-metal-ovn-ha-cert-rotation-shutdown 590a54c5ada39a5e4f7e80684728064d4bbd2eaa link false /test e2e-metal-ovn-ha-cert-rotation-shutdown
ci/prow/e2e-aws-ovn-serial 590a54c5ada39a5e4f7e80684728064d4bbd2eaa link true /test e2e-aws-ovn-serial
ci/prow/e2e-metal-ovn-sno-cert-rotation-shutdown 590a54c5ada39a5e4f7e80684728064d4bbd2eaa link false /test e2e-metal-ovn-sno-cert-rotation-shutdown
ci/prow/e2e-aws-etcd-certrotation 590a54c5ada39a5e4f7e80684728064d4bbd2eaa link false /test e2e-aws-etcd-certrotation
ci/prow/e2e-operator 590a54c5ada39a5e4f7e80684728064d4bbd2eaa link true /test e2e-operator
ci/prow/e2e-agnostic-ovn-upgrade 590a54c5ada39a5e4f7e80684728064d4bbd2eaa link true /test e2e-agnostic-ovn-upgrade
ci/prow/e2e-aws-ovn-single-node 590a54c5ada39a5e4f7e80684728064d4bbd2eaa link true /test e2e-aws-ovn-single-node
ci/prow/images 590a54c5ada39a5e4f7e80684728064d4bbd2eaa link true /test images
ci/prow/verify 590a54c5ada39a5e4f7e80684728064d4bbd2eaa link true /test verify
ci/prow/verify-deps 590a54c5ada39a5e4f7e80684728064d4bbd2eaa link true /test verify-deps

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).