ETCD-661: Add `etcd-backup-server` scheduling logic - Githubissues

openshift / cluster-etcd-operator

Operator to manage the lifecycle of the etcd members of an OpenShift cluster

Apache License 2.0

95 stars 127 forks source link

ETCD-661: Add `etcd-backup-server` scheduling logic #1306

Closed Elbehery closed 2 weeks ago

Elbehery commented 1 month ago

This PR adds etcd-backup-server scheduling logic.

This is part of https://issues.redhat.com/browse/ETCD-636

cc @openshift/openshift-team-etcd

[ ] set default schedule in case the CR has empty string note
[x] Add the backup Path to static pods

openshift-ci-robot commented 1 month ago

@Elbehery: This pull request references ETCD-635 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1306): >This PR adds etcd-backup-server scheduling logic. > >This is part of https://issues.redhat.com/browse/ETCD-636 > >cc @openshift/openshift-team-etcd Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

Elbehery commented 1 month ago

/label tide/merge-method-squash

openshift-ci-robot commented 1 month ago

@Elbehery: This pull request references ETCD-636 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1306): >This PR adds etcd-backup-server scheduling logic. > >This is part of https://issues.redhat.com/browse/ETCD-636 > >cc @openshift/openshift-team-etcd Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

openshift-ci-robot commented 4 weeks ago

@Elbehery: This pull request references ETCD-661 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1306): >This PR adds etcd-backup-server scheduling logic. > >This is part of https://issues.redhat.com/browse/ETCD-636 > >cc @openshift/openshift-team-etcd Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

Elbehery commented 4 weeks ago

/jira refresh

openshift-ci-robot commented 4 weeks ago

@Elbehery: This pull request references ETCD-661 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1306#issuecomment-2318268320): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

Elbehery commented 3 weeks ago

/retest-required

openshift-ci-robot commented 3 weeks ago

@Elbehery: This pull request references ETCD-661 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1306): >This PR adds etcd-backup-server scheduling logic. > >This is part of https://issues.redhat.com/browse/ETCD-636 > >cc @openshift/openshift-team-etcd > >- [ ] set default schedule in case the CR has empty string >- [ ] Raise an update PR to API, rejecting empty string Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

openshift-ci-robot commented 3 weeks ago

@Elbehery: This pull request references ETCD-661 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1306): >This PR adds etcd-backup-server scheduling logic. > >This is part of https://issues.redhat.com/browse/ETCD-636 > >cc @openshift/openshift-team-etcd > >- [ ] set default schedule in case the CR has empty string >- [ ] Raise an update PR to API, rejecting empty string >- [ ] Add the backup Path to static pods Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

openshift-ci-robot commented 3 weeks ago

@Elbehery: This pull request references ETCD-661 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1306): >This PR adds etcd-backup-server scheduling logic. > >This is part of https://issues.redhat.com/browse/ETCD-636 > >cc @openshift/openshift-team-etcd > >- [ ] set default schedule in case the CR has empty string [note](https://github.com/openshift/api/blob/master/config/v1alpha1/types_backup.go#L51) >- [ ] Add the backup Path to static pods Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

openshift-ci-robot commented 3 weeks ago

@Elbehery: This pull request references ETCD-661 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1306): >This PR adds etcd-backup-server scheduling logic. > >This is part of https://issues.redhat.com/browse/ETCD-636 > >cc @openshift/openshift-team-etcd > >- [ ] set default schedule in case the CR has empty string [note](https://github.com/openshift/api/blob/master/config/v1alpha1/types_backup.go#L51) >- [x] Add the backup Path to static pods Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

Elbehery commented 3 weeks ago

/jira refresh

openshift-ci-robot commented 3 weeks ago

@Elbehery: This pull request references ETCD-661 which is a valid jira issue.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1306#issuecomment-2328793146): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

Elbehery commented 3 weeks ago

/retest-required

Elbehery commented 2 weeks ago

/retest-required

openshift-ci[bot] commented 2 weeks ago

@Elbehery: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-etcd-certrotation	0e16d79d4494f653e016bda3d64f8726ceaafefb	link	false	`/test e2e-aws-etcd-certrotation`
ci/prow/e2e-metal-ovn-ha-cert-rotation-shutdown	0e16d79d4494f653e016bda3d64f8726ceaafefb	link	false	`/test e2e-metal-ovn-ha-cert-rotation-shutdown`
ci/prow/e2e-aws-etcd-recovery	0e16d79d4494f653e016bda3d64f8726ceaafefb	link	false	`/test e2e-aws-etcd-recovery`
ci/prow/e2e-metal-ovn-sno-cert-rotation-shutdown	0e16d79d4494f653e016bda3d64f8726ceaafefb	link	false	`/test e2e-metal-ovn-sno-cert-rotation-shutdown`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

tjungblu commented 2 weeks ago

/lgtm

openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Elbehery, tjungblu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-etcd-operator/blob/master/OWNERS)~~ [Elbehery,tjungblu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

openshift-bot commented 2 weeks ago

[ART PR BUILD NOTIFIER]

Distgit: cluster-etcd-operator This PR has been included in build cluster-etcd-operator-container-v4.18.0-202409090821.p0.g735f37b.assembly.stream.el9. All builds following this will include this PR.