openshift / cluster-etcd-operator

Operator to manage the lifecycle of the etcd members of an OpenShift cluster
Apache License 2.0
95 stars 127 forks source link

ETCD-662: Add `etcd-backup-server` e2e test #1307

Closed Elbehery closed 2 weeks ago

Elbehery commented 1 month ago

This PR adds etcd-backup-server e2e test.

This is part of https://issues.redhat.com/browse/ETCD-636

cc @openshift/openshift-team-etcd

openshift-ci-robot commented 1 month ago

@Elbehery: This pull request references Etcd-635 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1307): >This PR adds `etcd-backup-server` e2e test. > >This is part of https://issues.redhat.com/browse/ETCD-636 > >cc @openshift/openshift-team-etcd Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Elbehery

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-etcd-operator/blob/master/OWNERS)~~ [Elbehery] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
Elbehery commented 1 month ago

/label tide/merge-method-squash

Elbehery commented 1 month ago

tested against 4.17 cluster

melbeher@melbeher-mac e2e % go test -run TestEtcdBackupServer -v  
=== RUN   TestEtcdBackupServer
I0730 18:53:10.391280   41470 backup_test.go:679] found files on node [ip-10-0-116-171.us-west-1.compute.internal]: [. ./current-backup ./current-backup/snapshot_2024-07-30_165000.db ./current-backup/static_kuberesources_2024-07-30_165000.tar.gz ]
I0730 18:53:20.904011   41470 backup_test.go:679] found files on node [ip-10-0-5-44.us-west-1.compute.internal]: [. ./current-backup ./current-backup/snapshot_2024-07-30_165000.db ./current-backup/static_kuberesources_2024-07-30_165000.tar.gz ]
I0730 18:53:31.426464   41470 backup_test.go:679] found files on node [ip-10-0-52-197.us-west-1.compute.internal]: [. ./current-backup ./current-backup/snapshot_2024-07-30_165000.db ./current-backup/static_kuberesources_2024-07-30_165000.tar.gz ]
--- PASS: TestEtcdBackupServer (349.26s)
PASS
ok      github.com/openshift/cluster-etcd-operator/test/e2e 350.801s
Elbehery commented 1 month ago

this PR is failing, since the scheduling PR is not merged yet

I have tested this e2e against a 4.17 cluster, with https://github.com/openshift/cluster-etcd-operator/pull/1301 atop of it and it succeeds

openshift-ci-robot commented 1 month ago

@Elbehery: This pull request references Etcd-636 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1307): >This PR adds `etcd-backup-server` e2e test. > >This is part of https://issues.redhat.com/browse/ETCD-636 > >cc @openshift/openshift-team-etcd Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 4 weeks ago

@Elbehery: This pull request references ETCD-662 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1307): >This PR adds `etcd-backup-server` e2e test. > >This is part of https://issues.redhat.com/browse/ETCD-636 > >cc @openshift/openshift-team-etcd Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 2 weeks ago

@Elbehery: This pull request references ETCD-662 which is a valid jira issue.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1307): >This PR adds `etcd-backup-server` e2e test. > >This is part of https://issues.redhat.com/browse/ETCD-636 > >cc @openshift/openshift-team-etcd Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
Elbehery commented 2 weeks ago

/hold

openshift-ci[bot] commented 2 weeks ago

@Elbehery: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-operator 7fae22ac5648fd29475f4206e79d6a33009791c6 link true /test e2e-operator
ci/prow/e2e-metal-ovn-sno-cert-rotation-shutdown 7fae22ac5648fd29475f4206e79d6a33009791c6 link false /test e2e-metal-ovn-sno-cert-rotation-shutdown
ci/prow/e2e-metal-ovn-ha-cert-rotation-shutdown 7fae22ac5648fd29475f4206e79d6a33009791c6 link false /test e2e-metal-ovn-ha-cert-rotation-shutdown
ci/prow/e2e-aws-etcd-recovery 7fae22ac5648fd29475f4206e79d6a33009791c6 link false /test e2e-aws-etcd-recovery
ci/prow/e2e-aws-ovn-single-node 7fae22ac5648fd29475f4206e79d6a33009791c6 link true /test e2e-aws-ovn-single-node
ci/prow/e2e-aws-ovn-etcd-scaling 7fae22ac5648fd29475f4206e79d6a33009791c6 link true /test e2e-aws-ovn-etcd-scaling
ci/prow/e2e-operator-fips 7fae22ac5648fd29475f4206e79d6a33009791c6 link false /test e2e-operator-fips
ci/prow/unit 7fae22ac5648fd29475f4206e79d6a33009791c6 link true /test unit
ci/prow/e2e-aws-etcd-certrotation 7fae22ac5648fd29475f4206e79d6a33009791c6 link false /test e2e-aws-etcd-certrotation

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
Elbehery commented 2 weeks ago

closing this in favor of https://github.com/openshift/origin/pull/29098