search

openshift / cluster-etcd-operator

Operator to manage the lifecycle of the etcd members of an OpenShift cluster
Apache License 2.0
95 stars 127 forks source link

OCPBUGS-36462: ensure ordering in member health checks #1308

Closed tjungblu closed 1 month ago

tjungblu commented 1 month ago

Changes in the health check caused equality checks during member removal to result in incorrect vertical scaling behavior.

openshift-ci-robot commented 1 month ago

@tjungblu: This pull request references Jira Issue OCPBUGS-36462, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @geliu2016

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1308): >Changes in the health check caused equality checks during member removal to result in incorrect vertical scaling behavior. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
Elbehery commented 1 month ago

/lgtm /approve

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 428a8fdfe916b159cb6b7b4a98826fe63c1f9a6f and 2 for PR HEAD 7f7e1ad0199b11e5517ffc934700edfcf8ab289d in total

tjungblu commented 1 month ago

/jira backport release-4.16

Elbehery commented 1 month ago

/jira backport release-4.16

is this new label ?

i am out-dated

tjungblu commented 1 month ago

no idea if that even works: https://docs.ci.openshift.org/docs/architecture/jira/#cherrypickingbackporting

Elbehery commented 1 month ago

usually the bot notifies that a backport will be created once this is merged

i think this is not working

i recall they added multiple branches to one command as per the mail that was sent

dusk125 commented 1 month ago

/lgtm

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dusk125, Elbehery, tjungblu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-etcd-operator/blob/master/OWNERS)~~ [Elbehery,dusk125,tjungblu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 428a8fdfe916b159cb6b7b4a98826fe63c1f9a6f and 2 for PR HEAD 5d1ada4a8a69c0fd35f5dd4956b0584811f8bace in total

tjungblu commented 1 month ago

/retest

openshift-ci-robot commented 1 month ago

@tjungblu: Jira Issue OCPBUGS-36462: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-36462 has not been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1308): >Changes in the health check caused equality checks during member removal to result in incorrect vertical scaling behavior. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

Distgit: cluster-etcd-operator This PR has been included in build cluster-etcd-operator-container-v4.18.0-202408011146.p0.gc160ece.assembly.stream.el9. All builds following this will include this PR.

tjungblu commented 1 month ago

/cherry-pick release-4.16

openshift-cherrypick-robot commented 1 month ago

@tjungblu: #1308 failed to apply on top of branch "release-4.16":

Applying: OCPBUGS-36462: ensure ordering in member health checks
Using index info to reconstruct a base tree...
M   pkg/etcdcli/health.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/etcdcli/health.go
CONFLICT (content): Merge conflict in pkg/etcdcli/health.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OCPBUGS-36462: ensure ordering in member health checks
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1308#issuecomment-2263222094): >/cherry-pick release-4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
tjungblu commented 1 month ago

/jira clone release-4.16

tjungblu commented 1 month ago

/jira backport release-4.16

openshift-ci-robot commented 1 month ago

@tjungblu: The following backport issues have been created:

Queuing cherrypicks to the requested branches to be created after this PR merges: /cherrypick release-4.16

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1308#issuecomment-2263230888): >/jira backport release-4.16 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-cherrypick-robot commented 1 month ago

@openshift-ci-robot: #1308 failed to apply on top of branch "release-4.16":

Applying: OCPBUGS-36462: ensure ordering in member health checks
Using index info to reconstruct a base tree...
M   pkg/etcdcli/health.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/etcdcli/health.go
CONFLICT (content): Merge conflict in pkg/etcdcli/health.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OCPBUGS-36462: ensure ordering in member health checks
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1308#issuecomment-2263231347): >@tjungblu: The following backport issues have been created: >- [OCPBUGS-37820](https://issues.redhat.com//browse/OCPBUGS-37820) for branch release-4.16 > >Queuing cherrypicks to the requested branches to be created after this PR merges: >/cherrypick release-4.16 > >
> >In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1308#issuecomment-2263230888): > >>/jira backport release-4.16 > > >Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository. >

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

JoelSpeed commented 1 month ago

/jira refresh

openshift-ci-robot commented 1 month ago

@JoelSpeed: Jira Issue OCPBUGS-36462: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-36462 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1308#issuecomment-2272838671): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.