search

openshift / cluster-etcd-operator

Operator to manage the lifecycle of the etcd members of an OpenShift cluster
Apache License 2.0
95 stars 127 forks source link

NO-JIRA: degrade targetconfigcontroller on quorum loss #1309

Closed tjungblu closed 1 month ago

tjungblu commented 1 month ago

This is a more general refactoring to degrade the whole controller when quorum is lost. This should make it easier to assert in e2e tests and is more consistent with the behavior in the other controllers.

openshift-ci-robot commented 1 month ago

@tjungblu: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1309): >This is a more general refactoring to degrade the whole controller when quorum is lost. This should make it easier to assert in e2e tests and is more consistent with the behavior in the other controllers. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
dusk125 commented 1 month ago

/lgtm

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dusk125, tjungblu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-etcd-operator/blob/master/OWNERS)~~ [dusk125,tjungblu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 428a8fdfe916b159cb6b7b4a98826fe63c1f9a6f and 2 for PR HEAD f0f83802ae70507ab71440a2bc06a5b2279da9e5 in total

tjungblu commented 1 month ago

/retest

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD c160ece34d1b7f087366f0612970d8856a45f52e and 1 for PR HEAD f0f83802ae70507ab71440a2bc06a5b2279da9e5 in total

tjungblu commented 1 month ago

unrelated failure in kube version migration

/override ci/prow/e2e-aws-ovn-etcd-scaling

openshift-ci[bot] commented 1 month ago

@tjungblu: tjungblu unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1309#issuecomment-2262911993): >unrelated failure in kube version migration > >/override ci/prow/e2e-aws-ovn-etcd-scaling Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
tjungblu commented 1 month ago

/override ci/prow/e2e-aws-ovn-etcd-scaling

openshift-ci[bot] commented 1 month ago

@tjungblu: tjungblu unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1309#issuecomment-2262917976): >/override ci/prow/e2e-aws-ovn-etcd-scaling Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
hasbro17 commented 1 month ago

/override ci/prow/e2e-aws-ovn-etcd-scaling

Scaling test has already passed in that run https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_cluster-etcd-operator/1309/pull-ci-openshift-cluster-etcd-operator-master-e2e-aws-ovn-etcd-scaling/1818957024638013440

openshift-ci[bot] commented 1 month ago

@hasbro17: Overrode contexts on behalf of hasbro17: ci/prow/e2e-aws-ovn-etcd-scaling

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1309#issuecomment-2264152028): >/override ci/prow/e2e-aws-ovn-etcd-scaling > >Scaling test has already passed in that run >https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_cluster-etcd-operator/1309/pull-ci-openshift-cluster-etcd-operator-master-e2e-aws-ovn-etcd-scaling/1818957024638013440 > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
hasbro17 commented 1 month ago

tjungblu unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file

But we're all approvers in the OWNERS file so what gives? https://github.com/openshift/cluster-etcd-operator/blob/master/OWNERS

tjungblu commented 1 month ago

I've opened a DPTP bug already: https://issues.redhat.com/browse/DPTP-4116

tjungblu commented 1 month ago

/retest-required

tjungblu commented 1 month ago

/retest

openshift-ci[bot] commented 1 month ago

@tjungblu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ovn-ha-cert-rotation-shutdown f0f83802ae70507ab71440a2bc06a5b2279da9e5 link false /test e2e-metal-ovn-ha-cert-rotation-shutdown
ci/prow/e2e-metal-ovn-sno-cert-rotation-shutdown f0f83802ae70507ab71440a2bc06a5b2279da9e5 link false /test e2e-metal-ovn-sno-cert-rotation-shutdown
ci/prow/e2e-aws-etcd-recovery f0f83802ae70507ab71440a2bc06a5b2279da9e5 link false /test e2e-aws-etcd-recovery

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

Distgit: cluster-etcd-operator This PR has been included in build cluster-etcd-operator-container-v4.18.0-202408021814.p0.g37ac49d.assembly.stream.el9. All builds following this will include this PR.