openshift / cluster-etcd-operator

Operator to manage the lifecycle of the etcd members of an OpenShift cluster
Apache License 2.0
95 stars 127 forks source link

OCPBUGS-38341: prefer env var over hardcoding ciphers #1314

Closed tjungblu closed 1 month ago

tjungblu commented 1 month ago

This rectifies the hardcoding of the ciphers that I've introduced in #970, which is shadowing the ciphers set through the etcd cluster CRD.

openshift-ci-robot commented 1 month ago

@tjungblu: This pull request references Jira Issue OCPBUGS-38341, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1314): >This rectifies the hardcoding of the ciphers that I've introduced in #970, which is shadowing the ciphers set through the etcd cluster CRD. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
tjungblu commented 1 month ago

/jira refresh /retest-required

openshift-ci-robot commented 1 month ago

@tjungblu: This pull request references Jira Issue OCPBUGS-38341, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1314#issuecomment-2285727180): >/jira refresh >/retest-required Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
tjungblu commented 1 month ago

/jira-backport release-4.17,release-4.16,release-4.15,release-4.14,release-4.13

dusk125 commented 1 month ago

/lgtm

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dusk125, tjungblu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-etcd-operator/blob/master/OWNERS)~~ [dusk125,tjungblu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tjungblu commented 1 month ago

seems to fail on some SELinux error in storage

/override ci/prow/e2e-aws-ovn-serial

openshift-ci[bot] commented 1 month ago

@tjungblu: Overrode contexts on behalf of tjungblu: ci/prow/e2e-aws-ovn-serial

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1314#issuecomment-2286140656): >seems to fail on some SELinux error in storage > >/override ci/prow/e2e-aws-ovn-serial Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 1 month ago

@tjungblu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ovn-ha-cert-rotation-shutdown c0de9813f72acf081186daf2c59e14099e2462e9 link false /test e2e-metal-ovn-ha-cert-rotation-shutdown
ci/prow/e2e-metal-ovn-sno-cert-rotation-shutdown c0de9813f72acf081186daf2c59e14099e2462e9 link false /test e2e-metal-ovn-sno-cert-rotation-shutdown
ci/prow/e2e-aws-etcd-certrotation c0de9813f72acf081186daf2c59e14099e2462e9 link false /test e2e-aws-etcd-certrotation
ci/prow/e2e-aws-etcd-recovery c0de9813f72acf081186daf2c59e14099e2462e9 link false /test e2e-aws-etcd-recovery

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
tjungblu commented 1 month ago

/jira refresh

openshift-ci-robot commented 1 month ago

@tjungblu: This pull request references Jira Issue OCPBUGS-38341, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1314#issuecomment-2286151803): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 month ago

@tjungblu: Jira Issue OCPBUGS-38341: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-38341 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1314): >This rectifies the hardcoding of the ciphers that I've introduced in #970, which is shadowing the ciphers set through the etcd cluster CRD. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

Distgit: cluster-etcd-operator This PR has been included in build cluster-etcd-operator-container-v4.18.0-202408132015.p0.g38886b6.assembly.stream.el9. All builds following this will include this PR.

tjungblu commented 1 month ago

/cherry-pick release-4.17,release-4.16,release-4.15,release-4.14,release-4.13

openshift-cherrypick-robot commented 1 month ago

@tjungblu: cannot checkout release-4.17,release-4.16,release-4.15,release-4.14,release-4.13: error checking out "release-4.17,release-4.16,release-4.15,release-4.14,release-4.13": exit status 1 error: pathspec 'release-4.17,release-4.16,release-4.15,release-4.14,release-4.13' did not match any file(s) known to git

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1314#issuecomment-2288129148): >/cherry-pick release-4.17,release-4.16,release-4.15,release-4.14,release-4.13 > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
tjungblu commented 1 month ago

/cherry-pick release-4.17 release-4.16 release-4.15 release-4.14 release-4.13

openshift-cherrypick-robot commented 1 month ago

@tjungblu: new pull request created: #1316

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1314#issuecomment-2288131343): > >/cherry-pick release-4.17 release-4.16 release-4.15 release-4.14 release-4.13 > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.