search

openshift / cluster-etcd-operator

Operator to manage the lifecycle of the etcd members of an OpenShift cluster
Apache License 2.0
95 stars 127 forks source link

WIP: Replace readyz sidecar container with etcds own probes #1321

Closed jubittajohn closed 3 weeks ago

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jubittajohn Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/cluster-etcd-operator/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tjungblu commented 1 month ago

(just checking something for another ticket - don't be confused)

/override ci/prow/e2e-aws-etcd-recovery

openshift-ci[bot] commented 1 month ago

@tjungblu: Overrode contexts on behalf of tjungblu: ci/prow/e2e-aws-etcd-recovery

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1321#issuecomment-2298654793): >(just checking something for another ticket - don't be confused) > >/override ci/prow/e2e-aws-etcd-recovery Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 1 month ago

@jubittajohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agnostic-ovn-upgrade 2cf5c88da63583ed13e1bff9fee4dabd39f3f152 link true /test e2e-agnostic-ovn-upgrade
ci/prow/e2e-operator 2cf5c88da63583ed13e1bff9fee4dabd39f3f152 link true /test e2e-operator
ci/prow/e2e-operator-fips 2cf5c88da63583ed13e1bff9fee4dabd39f3f152 link false /test e2e-operator-fips
ci/prow/e2e-aws-etcd-certrotation 2cf5c88da63583ed13e1bff9fee4dabd39f3f152 link false /test e2e-aws-etcd-certrotation
ci/prow/e2e-agnostic-ovn 2cf5c88da63583ed13e1bff9fee4dabd39f3f152 link true /test e2e-agnostic-ovn
ci/prow/e2e-aws-ovn-etcd-scaling 2cf5c88da63583ed13e1bff9fee4dabd39f3f152 link true /test e2e-aws-ovn-etcd-scaling
ci/prow/e2e-aws-ovn-serial 2cf5c88da63583ed13e1bff9fee4dabd39f3f152 link true /test e2e-aws-ovn-serial
ci/prow/e2e-metal-ovn-sno-cert-rotation-shutdown 2cf5c88da63583ed13e1bff9fee4dabd39f3f152 link false /test e2e-metal-ovn-sno-cert-rotation-shutdown
ci/prow/e2e-metal-ovn-ha-cert-rotation-shutdown 2cf5c88da63583ed13e1bff9fee4dabd39f3f152 link false /test e2e-metal-ovn-ha-cert-rotation-shutdown
ci/prow/e2e-aws-ovn-single-node 2cf5c88da63583ed13e1bff9fee4dabd39f3f152 link true /test e2e-aws-ovn-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-merge-robot commented 3 weeks ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
tjungblu commented 3 weeks ago

let's shelve this until we have a solution for https://github.com/etcd-io/etcd/issues/18477

/close

openshift-ci[bot] commented 3 weeks ago

@tjungblu: Closed this PR.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1321#issuecomment-2326751571): >let's shelve this until we have a solution for >https://github.com/etcd-io/etcd/issues/18477 > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.