search

openshift / cluster-etcd-operator

Operator to manage the lifecycle of the etcd members of an OpenShift cluster
Apache License 2.0
95 stars 127 forks source link

OCPBUGS-38573: use pooled client for etcd single member health checks #1324

Closed tjungblu closed 1 month ago

tjungblu commented 1 month ago

This should reduce CPU consumption because of less TLS handshakes and makes it usable from other places too.

This is fixing the reverted patch by supplying a pool to the GetMemberHealth to avoid multiple goroutines changing the endpoints inadvertently

openshift-ci-robot commented 1 month ago

@tjungblu: This pull request references Jira Issue OCPBUGS-38573, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @geliu2016

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1324): >This should reduce CPU consumption because of less TLS handshakes and makes it usable from other places too. > >This is fixing the reverted patch by supplying a pool to the GetMemberHealth to avoid multiple goroutines changing the endpoints inadvertently Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
dusk125 commented 1 month ago

/lgtm

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dusk125, tjungblu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-etcd-operator/blob/master/OWNERS)~~ [dusk125,tjungblu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tjungblu commented 1 month ago

/cherry-pick release-4.17

openshift-cherrypick-robot commented 1 month ago

@tjungblu: once the present PR merges, I will cherry-pick it on top of release-4.17 in a new PR and assign it to you.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1324#issuecomment-2302349562): >/cherry-pick release-4.17 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 164c37f68839b6d76bd724bb1ff9316bd62f6f97 and 2 for PR HEAD 382422e0f68744ac8abede40103ba8537796f203 in total

tjungblu commented 1 month ago

/retest-required

tjungblu commented 1 month ago

/retest-required

dusk125 commented 1 month ago

/retest-required

openshift-ci[bot] commented 1 month ago

@tjungblu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-etcd-certrotation 382422e0f68744ac8abede40103ba8537796f203 link false /test e2e-aws-etcd-certrotation
ci/prow/e2e-metal-ovn-sno-cert-rotation-shutdown 382422e0f68744ac8abede40103ba8537796f203 link false /test e2e-metal-ovn-sno-cert-rotation-shutdown
ci/prow/e2e-metal-ovn-ha-cert-rotation-shutdown 382422e0f68744ac8abede40103ba8537796f203 link false /test e2e-metal-ovn-ha-cert-rotation-shutdown
ci/prow/e2e-aws-etcd-recovery 382422e0f68744ac8abede40103ba8537796f203 link false /test e2e-aws-etcd-recovery

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 164c37f68839b6d76bd724bb1ff9316bd62f6f97 and 2 for PR HEAD 382422e0f68744ac8abede40103ba8537796f203 in total

tjungblu commented 1 month ago

/retest-required

openshift-ci-robot commented 1 month ago

@tjungblu: Jira Issue OCPBUGS-38573: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-38573 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1324): >This should reduce CPU consumption because of less TLS handshakes and makes it usable from other places too. > >This is fixing the reverted patch by supplying a pool to the GetMemberHealth to avoid multiple goroutines changing the endpoints inadvertently Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-cherrypick-robot commented 1 month ago

@tjungblu: new pull request created: #1327

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1324#issuecomment-2302349562): >/cherry-pick release-4.17 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-bot commented 4 weeks ago

[ART PR BUILD NOTIFIER]

Distgit: cluster-etcd-operator This PR has been included in build cluster-etcd-operator-container-v4.18.0-202408272341.p0.g60e6acf.assembly.stream.el9. All builds following this will include this PR.