search

openshift / cluster-etcd-operator

Operator to manage the lifecycle of the etcd members of an OpenShift cluster
Apache License 2.0
95 stars 127 forks source link

ETCD-652: Store latest etcd leader revision in datadir #1326

Closed tjungblu closed 4 weeks ago

tjungblu commented 1 month ago

This will query all endpoints in a sidecar and provide a local output in /var/lib/etcd/revision.json with the raftindex of all endpoints and the maximum observed.

openshift-ci-robot commented 1 month ago

@tjungblu: This pull request references ETCD-652 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1326): >This will query all endpoints in a sidecar and provide a local output in /var/lib/etcd/revision.json with the raftindex of all endpoints and the maximum observed. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
dusk125 commented 1 month ago

/lgtm

tjungblu commented 1 month ago

/hold

might need to do some optimizations still :)

tjungblu commented 4 weeks ago

/hold cancel

dusk125 commented 4 weeks ago

/lgtm

openshift-ci[bot] commented 4 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dusk125, tjungblu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-etcd-operator/blob/master/OWNERS)~~ [dusk125,tjungblu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 4 weeks ago

/retest-required

Remaining retests: 0 against base HEAD 60e6acf0c59380118505ba46e247ad82ca86b0c5 and 2 for PR HEAD 8e95d35a7a9b48956caa9c2ae89a9c00ab3a0786 in total

openshift-ci[bot] commented 4 weeks ago

@tjungblu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ovn-ha-cert-rotation-shutdown 8e95d35a7a9b48956caa9c2ae89a9c00ab3a0786 link false /test e2e-metal-ovn-ha-cert-rotation-shutdown
ci/prow/e2e-aws-etcd-certrotation 8e95d35a7a9b48956caa9c2ae89a9c00ab3a0786 link false /test e2e-aws-etcd-certrotation
ci/prow/e2e-aws-etcd-recovery 8e95d35a7a9b48956caa9c2ae89a9c00ab3a0786 link false /test e2e-aws-etcd-recovery
ci/prow/e2e-metal-ovn-sno-cert-rotation-shutdown 8e95d35a7a9b48956caa9c2ae89a9c00ab3a0786 link false /test e2e-metal-ovn-sno-cert-rotation-shutdown

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 3 weeks ago

[ART PR BUILD NOTIFIER]

Distgit: cluster-etcd-operator This PR has been included in build cluster-etcd-operator-container-v4.18.0-202408301116.p0.gfde1581.assembly.stream.el9. All builds following this will include this PR.