search

openshift / cluster-etcd-operator

Operator to manage the lifecycle of the etcd members of an OpenShift cluster
Apache License 2.0
95 stars 127 forks source link

ETCD-656: add cluster identifier to revision.json #1337

Closed tjungblu closed 2 weeks ago

tjungblu commented 2 weeks ago

This is required because the cluster id is not stored in the raft hardstate. It proved difficult to re-generate this from within the initial cluster discovery binary based on environment variables, so we're storing it more explicitly in the revision.json. EDIT: turns out this is also stored in the WAL metadata.

This also fixes a flake when the leader is terminated in the unit tests.

requirement for https://github.com/openshift/etcd/pull/284

openshift-ci-robot commented 2 weeks ago

@tjungblu: This pull request references ETCD-656 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1337): >This is required because the cluster id is not stored in the raft hardstate. It proved difficult to re-generate this from within the initial cluster discovery binary based on environment variables, so we're storing it more explicitly in the revision.json. > >This also fixes a flake when the leader is terminated in the unit tests. > >requirement for https://github.com/openshift/etcd/pull/284 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
Elbehery commented 2 weeks ago

/lgtm /approve

openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Elbehery, tjungblu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-etcd-operator/blob/master/OWNERS)~~ [Elbehery,tjungblu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 2 weeks ago

@tjungblu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-etcd-certrotation 239858702f43ddcf77f20d5111b72c5d595d4c4d link false /test e2e-aws-etcd-certrotation
ci/prow/e2e-metal-ovn-ha-cert-rotation-shutdown 239858702f43ddcf77f20d5111b72c5d595d4c4d link false /test e2e-metal-ovn-ha-cert-rotation-shutdown
ci/prow/e2e-aws-etcd-recovery 239858702f43ddcf77f20d5111b72c5d595d4c4d link false /test e2e-aws-etcd-recovery
ci/prow/e2e-metal-ovn-sno-cert-rotation-shutdown 239858702f43ddcf77f20d5111b72c5d595d4c4d link false /test e2e-metal-ovn-sno-cert-rotation-shutdown

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 2 weeks ago

[ART PR BUILD NOTIFIER]

Distgit: cluster-etcd-operator This PR has been included in build cluster-etcd-operator-container-v4.18.0-202409121910.p0.g0b7f488.assembly.stream.el9. All builds following this will include this PR.