openshift / cluster-etcd-operator

Operator to manage the lifecycle of the etcd members of an OpenShift cluster
Apache License 2.0
95 stars 127 forks source link

ETCD-662: fix: etcd-backup-server prune path #1341

Closed Elbehery closed 3 days ago

Elbehery commented 6 days ago

follow up on https://github.com/openshift/cluster-etcd-operator/pull/1340

openshift-ci-robot commented 6 days ago

@Elbehery: This pull request references ETCD-662 which is a valid jira issue.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1341): >follow up on https://github.com/openshift/cluster-etcd-operator/pull/1340 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
Elbehery commented 6 days ago

/retest-required

Elbehery commented 6 days ago

/retest-required

openshift-ci[bot] commented 6 days ago

@Elbehery: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-etcd-certrotation e7f392699c8b516423dba7a360787cde0f6677f1 link false /test e2e-aws-etcd-certrotation
ci/prow/e2e-aws-etcd-recovery e7f392699c8b516423dba7a360787cde0f6677f1 link false /test e2e-aws-etcd-recovery
ci/prow/e2e-metal-ovn-ha-cert-rotation-shutdown e7f392699c8b516423dba7a360787cde0f6677f1 link false /test e2e-metal-ovn-ha-cert-rotation-shutdown
ci/prow/e2e-metal-ovn-sno-cert-rotation-shutdown e7f392699c8b516423dba7a360787cde0f6677f1 link false /test e2e-metal-ovn-sno-cert-rotation-shutdown

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
tjungblu commented 3 days ago

/lgtm

openshift-ci[bot] commented 3 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Elbehery, tjungblu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-etcd-operator/blob/master/OWNERS)~~ [Elbehery,tjungblu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-bot commented 3 days ago

[ART PR BUILD NOTIFIER]

Distgit: cluster-etcd-operator This PR has been included in build cluster-etcd-operator-container-v4.18.0-202409231442.p0.g8a284c5.assembly.stream.el9. All builds following this will include this PR.