openshift / cluster-kube-apiserver-operator

The kube-apiserver operator installs and maintains the kube-apiserver on a cluster
Apache License 2.0
74 stars 159 forks source link

OCPBUGS-19160: Updating ose-cluster-kube-apiserver-operator images to be consistent with ART #1550

Closed openshift-bot closed 1 year ago

openshift-bot commented 1 year ago

Updating ose-cluster-kube-apiserver-operator-container image to be consistent with ART TLDR: Product builds replace base and builder images as configured. This PR is to ensure that CI builds use the same base images as the product builds.

Component owners, please ensure that this PR merges as it impacts the fidelity of your CI signal. Patch-manager / leads, this PR is a no-op from a product perspective -- feel free to manually apply any labels (e.g. jira/valid-bug) to help the PR merge as long as tests are passing. If the PR is labeled "needs-ok-to-test", this is to limit costs for re-testing these PRs while they wait for review. Issue /ok-to-test to remove this tag and help the PR to merge.

Detail: This repository is out of sync with the downstream product builds for this component. One or more images differ from those being used by ART to create product builds. This should be addressed to ensure that the component's CI testing is accurately reflecting what customers will experience.

The information within the following ART component metadata is driving this alignment request: ose-cluster-kube-apiserver-operator.yml.

The vast majority of these PRs are opened because a different Golang version is being used to build the downstream component. ART compiles most components with the version of Golang being used by the control plane for a given OpenShift release. Exceptions to this convention (i.e. you believe your component must be compiled with a Golang version independent from the control plane) must be granted by the OpenShift architecture team and communicated to the ART team.

Roles & Responsibilities:

ART has been configured to reconcile your CI build root image (see https://docs.ci.openshift.org/docs/architecture/ci-operator/#build-root-image). In order for your upstream .ci-operator.yaml configuration to be honored, you must set the following in your openshift/release ci-operator configuration file:

build_root:
  from_repository: true

Change behavior of future PRs:

If you have any questions about this pull request, please reach out to @release-artists in the #forum-ocp-art coreos slack channel.

openshift-ci-robot commented 1 year ago

@openshift-bot: This pull request references Jira Issue OCPBUGS-19160, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.15.0) matches configured target version for branch (4.15.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @wangke19

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1550): >Updating ose-cluster-kube-apiserver-operator images to be consistent with ART >__TLDR__: >Component owners, please ensure that this PR merges as it impacts the fidelity >of your CI signal. Patch-manager / leads, this PR is a no-op from a product >perspective -- feel free to manually apply any labels (e.g. jira/valid-bug) to help the >PR merge as long as tests are passing. If the PR is labeled "needs-ok-to-test", this is >to limit costs for re-testing these PRs while they wait for review. Issue /ok-to-test >to remove this tag and help the PR to merge. > >__Detail__: >This repository is out of sync with the downstream product builds for this component. >One or more images differ from those being used by ART to create product builds. This >should be addressed to ensure that the component's CI testing is accurately >reflecting what customers will experience. > >The information within the following ART component metadata is driving this alignment >request: [ose-cluster-kube-apiserver-operator.yml](https://github.com/openshift/ocp-build-data/tree/da6a5af1fa96762cc8410f09fc28c0457280f59a/images/ose-cluster-kube-apiserver-operator.yml). > >The vast majority of these PRs are opened because a different Golang version is being >used to build the downstream component. ART compiles most components with the version >of Golang being used by the control plane for a given OpenShift release. Exceptions >to this convention (i.e. you believe your component must be compiled with a Golang >version independent from the control plane) must be granted by the OpenShift >architecture team and communicated to the ART team. > >__Roles & Responsibilities__: >- Component owners are responsible for ensuring these alignment PRs merge with passing > tests OR that necessary metadata changes are reported to the ART team: `@release-artists` > in `#forum-ocp-art` on Slack. If necessary, the changes required by this pull request can be > introduced with a separate PR opened by the component team. Once the repository is aligned, > this PR will be closed automatically. >- Patch-manager or those with sufficient privileges within this repository may add > any required labels to ensure the PR merges once tests are passing. Downstream builds > are *already* being built with these changes. Merging this PR only improves the fidelity > of our CI. > >ART has been configured to reconcile your CI build root image (see https://docs.ci.openshift.org/docs/architecture/ci-operator/#build-root-image). >In order for your upstream .ci-operator.yaml configuration to be honored, you must set the following in your openshift/release ci-operator configuration file: >``` >build_root: > from_repository: true >``` > >If you have any questions about this pull request, please reach out to `@release-artists` in the `#forum-ocp-art` coreos slack channel. > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 1 year ago

@openshift-bot: This pull request references Jira Issue OCPBUGS-19160, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.15.0) matches configured target version for branch (4.15.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @wangke19

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1550): >Updating ose-cluster-kube-apiserver-operator images to be consistent with ART >__TLDR__: >Component owners, please ensure that this PR merges as it impacts the fidelity >of your CI signal. Patch-manager / leads, this PR is a no-op from a product >perspective -- feel free to manually apply any labels (e.g. jira/valid-bug) to help the >PR merge as long as tests are passing. If the PR is labeled "needs-ok-to-test", this is >to limit costs for re-testing these PRs while they wait for review. Issue /ok-to-test >to remove this tag and help the PR to merge. > >__Detail__: >This repository is out of sync with the downstream product builds for this component. >One or more images differ from those being used by ART to create product builds. This >should be addressed to ensure that the component's CI testing is accurately >reflecting what customers will experience. > >The information within the following ART component metadata is driving this alignment >request: [ose-cluster-kube-apiserver-operator.yml](https://github.com/openshift/ocp-build-data/tree/6831b59dddc5b63282076d3abe04593ad1945148/images/ose-cluster-kube-apiserver-operator.yml). > >The vast majority of these PRs are opened because a different Golang version is being >used to build the downstream component. ART compiles most components with the version >of Golang being used by the control plane for a given OpenShift release. Exceptions >to this convention (i.e. you believe your component must be compiled with a Golang >version independent from the control plane) must be granted by the OpenShift >architecture team and communicated to the ART team. > >__Roles & Responsibilities__: >- Component owners are responsible for ensuring these alignment PRs merge with passing > tests OR that necessary metadata changes are reported to the ART team: `@release-artists` > in `#forum-ocp-art` on Slack. If necessary, the changes required by this pull request can be > introduced with a separate PR opened by the component team. Once the repository is aligned, > this PR will be closed automatically. >- Patch-manager or those with sufficient privileges within this repository may add > any required labels to ensure the PR merges once tests are passing. Downstream builds > are *already* being built with these changes. Merging this PR only improves the fidelity > of our CI. > >ART has been configured to reconcile your CI build root image (see https://docs.ci.openshift.org/docs/architecture/ci-operator/#build-root-image). >In order for your upstream .ci-operator.yaml configuration to be honored, you must set the following in your openshift/release ci-operator configuration file: >``` >build_root: > from_repository: true >``` > >If you have any questions about this pull request, please reach out to `@release-artists` in the `#forum-ocp-art` coreos slack channel. > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 1 year ago

@openshift-bot: This pull request references Jira Issue OCPBUGS-19160, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.15.0) matches configured target version for branch (4.15.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @wangke19

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1550): >Updating ose-cluster-kube-apiserver-operator images to be consistent with ART >__TLDR__: >Component owners, please ensure that this PR merges as it impacts the fidelity >of your CI signal. Patch-manager / leads, this PR is a no-op from a product >perspective -- feel free to manually apply any labels (e.g. jira/valid-bug) to help the >PR merge as long as tests are passing. If the PR is labeled "needs-ok-to-test", this is >to limit costs for re-testing these PRs while they wait for review. Issue /ok-to-test >to remove this tag and help the PR to merge. > >__Detail__: >This repository is out of sync with the downstream product builds for this component. >One or more images differ from those being used by ART to create product builds. This >should be addressed to ensure that the component's CI testing is accurately >reflecting what customers will experience. > >The information within the following ART component metadata is driving this alignment >request: [ose-cluster-kube-apiserver-operator.yml](https://github.com/openshift/ocp-build-data/tree/1734f02719122dc25f5a783fbb767ca8afc07f65/images/ose-cluster-kube-apiserver-operator.yml). > >The vast majority of these PRs are opened because a different Golang version is being >used to build the downstream component. ART compiles most components with the version >of Golang being used by the control plane for a given OpenShift release. Exceptions >to this convention (i.e. you believe your component must be compiled with a Golang >version independent from the control plane) must be granted by the OpenShift >architecture team and communicated to the ART team. > >__Roles & Responsibilities__: >- Component owners are responsible for ensuring these alignment PRs merge with passing > tests OR that necessary metadata changes are reported to the ART team: `@release-artists` > in `#forum-ocp-art` on Slack. If necessary, the changes required by this pull request can be > introduced with a separate PR opened by the component team. Once the repository is aligned, > this PR will be closed automatically. >- Patch-manager or those with sufficient privileges within this repository may add > any required labels to ensure the PR merges once tests are passing. Downstream builds > are *already* being built with these changes. Merging this PR only improves the fidelity > of our CI. > >ART has been configured to reconcile your CI build root image (see https://docs.ci.openshift.org/docs/architecture/ci-operator/#build-root-image). >In order for your upstream .ci-operator.yaml configuration to be honored, you must set the following in your openshift/release ci-operator configuration file: >``` >build_root: > from_repository: true >``` > >If you have any questions about this pull request, please reach out to `@release-artists` in the `#forum-ocp-art` coreos slack channel. > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 1 year ago

@openshift-bot: This pull request references Jira Issue OCPBUGS-19160, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.15.0) matches configured target version for branch (4.15.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @wangke19

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1550): >Updating ose-cluster-kube-apiserver-operator images to be consistent with ART >__TLDR__: >Component owners, please ensure that this PR merges as it impacts the fidelity >of your CI signal. Patch-manager / leads, this PR is a no-op from a product >perspective -- feel free to manually apply any labels (e.g. jira/valid-bug) to help the >PR merge as long as tests are passing. If the PR is labeled "needs-ok-to-test", this is >to limit costs for re-testing these PRs while they wait for review. Issue /ok-to-test >to remove this tag and help the PR to merge. > >__Detail__: >This repository is out of sync with the downstream product builds for this component. >One or more images differ from those being used by ART to create product builds. This >should be addressed to ensure that the component's CI testing is accurately >reflecting what customers will experience. > >The information within the following ART component metadata is driving this alignment >request: [ose-cluster-kube-apiserver-operator.yml](https://github.com/openshift/ocp-build-data/tree/01fbfd6d60e2c7362a134b541dd2fe9c451fe9e3/images/ose-cluster-kube-apiserver-operator.yml). > >The vast majority of these PRs are opened because a different Golang version is being >used to build the downstream component. ART compiles most components with the version >of Golang being used by the control plane for a given OpenShift release. Exceptions >to this convention (i.e. you believe your component must be compiled with a Golang >version independent from the control plane) must be granted by the OpenShift >architecture team and communicated to the ART team. > >__Roles & Responsibilities__: >- Component owners are responsible for ensuring these alignment PRs merge with passing > tests OR that necessary metadata changes are reported to the ART team: `@release-artists` > in `#forum-ocp-art` on Slack. If necessary, the changes required by this pull request can be > introduced with a separate PR opened by the component team. Once the repository is aligned, > this PR will be closed automatically. >- Patch-manager or those with sufficient privileges within this repository may add > any required labels to ensure the PR merges once tests are passing. Downstream builds > are *already* being built with these changes. Merging this PR only improves the fidelity > of our CI. > >ART has been configured to reconcile your CI build root image (see https://docs.ci.openshift.org/docs/architecture/ci-operator/#build-root-image). >In order for your upstream .ci-operator.yaml configuration to be honored, you must set the following in your openshift/release ci-operator configuration file: >``` >build_root: > from_repository: true >``` > >If you have any questions about this pull request, please reach out to `@release-artists` in the `#forum-ocp-art` coreos slack channel. > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
wangke19 commented 1 year ago

Did a pre-merge verify, detail see, https://issues.redhat.com/browse/OCPBUGS-19160?focusedId=23135345&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-23135345 /label qe-approved

wangke19 commented 1 year ago

/lgtm

wangke19 commented 1 year ago

/retest

openshift-ci[bot] commented 1 year ago

@openshift-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node 98ab15dfec6ca8d6dfdf22444052990d81ec4e73 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-aws-operator-disruptive-single-node 98ab15dfec6ca8d6dfdf22444052990d81ec4e73 link false /test e2e-aws-operator-disruptive-single-node
ci/prow/e2e-gcp-operator-single-node 98ab15dfec6ca8d6dfdf22444052990d81ec4e73 link false /test e2e-gcp-operator-single-node
ci/prow/e2e-metal-single-node-live-iso 98ab15dfec6ca8d6dfdf22444052990d81ec4e73 link false /test e2e-metal-single-node-live-iso

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
tkashem commented 1 year ago

/lgtm /approve

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-bot, tkashem, wangke19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-kube-apiserver-operator/blob/master/OWNERS)~~ [tkashem] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 1 year ago

@openshift-bot: Jira Issue OCPBUGS-19160: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-19160 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1550): >Updating ose-cluster-kube-apiserver-operator-container image to be consistent with ART >__TLDR__: >Product builds replace base and builder images as configured. This PR is to ensure >that CI builds use the same base images as the product builds. > >Component owners, please ensure that this PR merges as it impacts the fidelity >of your CI signal. Patch-manager / leads, this PR is a no-op from a product >perspective -- feel free to manually apply any labels (e.g. jira/valid-bug) to help the >PR merge as long as tests are passing. If the PR is labeled "needs-ok-to-test", this is >to limit costs for re-testing these PRs while they wait for review. Issue /ok-to-test >to remove this tag and help the PR to merge. > >__Detail__: >This repository is out of sync with the downstream product builds for this component. >One or more images differ from those being used by ART to create product builds. This >should be addressed to ensure that the component's CI testing is accurately >reflecting what customers will experience. > >The information within the following ART component metadata is driving this alignment >request: [ose-cluster-kube-apiserver-operator.yml](https://github.com/openshift/ocp-build-data/tree/b3328c792d7f910589632ac823510a0cd804c531/images/ose-cluster-kube-apiserver-operator.yml). > >The vast majority of these PRs are opened because a different Golang version is being >used to build the downstream component. ART compiles most components with the version >of Golang being used by the control plane for a given OpenShift release. Exceptions >to this convention (i.e. you believe your component must be compiled with a Golang >version independent from the control plane) must be granted by the OpenShift >architecture team and communicated to the ART team. > >__Roles & Responsibilities__: >- Component owners are responsible for ensuring these alignment PRs merge with passing > tests OR that necessary metadata changes are reported to the ART team: `@release-artists` > in `#forum-ocp-art` on Slack. If necessary, the changes required by this pull request can be > introduced with a separate PR opened by the component team. Once the repository is aligned, > this PR will be closed automatically. >- Patch-manager or those with sufficient privileges within this repository may add > any required labels to ensure the PR merges once tests are passing. Downstream builds > are *already* being built with these changes. Merging this PR only improves the fidelity > of our CI. > >ART has been configured to reconcile your CI build root image (see https://docs.ci.openshift.org/docs/architecture/ci-operator/#build-root-image). >In order for your upstream .ci-operator.yaml configuration to be honored, you must set the following in your openshift/release ci-operator configuration file: >``` >build_root: > from_repository: true >``` > >__Change behavior of future PRs__: >* In case you just want to follow the base images that ART suggests, you can configure additional labels to be > set up automatically. This means that such a PR would *merge without human intervention* (and awareness!) in the future. > To do so, open a PR to set the `auto_label` attribute in the image configuration. [Example](https://github.com/openshift-eng/ocp-build-data/pull/1778) >* You can set a commit prefix, like `UPSTREAM: : `. [An example](https://github.com/openshift-eng/ocp-build-data/blob/6831b59dddc5b63282076d3abe04593ad1945148/images/ose-cluster-api.yml#L11). > >If you have any questions about this pull request, please reach out to `@release-artists` in the `#forum-ocp-art` coreos slack channel. > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-merge-robot commented 1 year ago

Fix included in accepted release 4.15.0-0.nightly-2023-11-03-082930