search

openshift / cluster-kube-apiserver-operator

The kube-apiserver operator installs and maintains the kube-apiserver on a cluster
Apache License 2.0
74 stars 159 forks source link

[release-4.14] OCPBUGS-22718: manifests/0000_90_kube-apiserver-operator_04_servicemonitor-apiserver: Rename to kube-apiserver-performance-recording-rules #1572

Closed openshift-cherrypick-robot closed 1 year ago

openshift-cherrypick-robot commented 1 year ago

This is an automated cherry-pick of #1566

/assign sdodson

openshift-ci-robot commented 1 year ago

@openshift-cherrypick-robot: Detected clone of Jira Issue OCPBUGS-20331 with correct target version. Will retitle the PR to link to the clone. /retitle [release-4.14] OCPBUGS-22718: manifests/0000_90_kube-apiserver-operator_04_servicemonitor-apiserver: Rename to kube-apiserver-performance-recording-rules

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1572): >This is an automated cherry-pick of #1566 > >/assign sdodson Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
sdodson commented 1 year ago

/close No need for backport per upstream PR

@vrutkovs pointed out that this PrometheusRule was new in 4.14, so we won't need to backport this change to 4.14. I've rerolled with https://github.com/openshift/cluster-kube-apiserver-operator/commit/0b6040beb51aaf239e28f2a07f64c8d1c41a95fc -> https://github.com/openshift/cluster-kube-apiserver-operator/commit/0412fb31e03c5c278d1ba90a267507392c9a1fc8 to sit in parallel with https://github.com/openshift/cluster-kube-apiserver-operator/pull/1565 instead of on top of it.

openshift-ci-robot commented 1 year ago

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-22718, which is valid.

6 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.14.0) matches configured target version for branch (4.14.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST) * dependent bug [Jira Issue OCPBUGS-20331](https://issues.redhat.com//browse/OCPBUGS-20331) is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED) * dependent [Jira Issue OCPBUGS-20331](https://issues.redhat.com//browse/OCPBUGS-20331) targets the "4.15.0" version, which is one of the valid target versions: 4.15.0 * bug has dependents

Requesting review from QA contact: /cc @wangke19

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1572): >This is an automated cherry-pick of #1566 > >/assign sdodson Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot Once this PR has been reviewed and has the lgtm label, please assign soltysh for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/cluster-kube-apiserver-operator/blob/release-4.14/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 1 year ago

@sdodson: Closed this PR.

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1572#issuecomment-1787155816): >/close >No need for backport per upstream PR >>@vrutkovs pointed out that this PrometheusRule was new in 4.14, so we won't need to backport this change to 4.14. I've rerolled with https://github.com/openshift/cluster-kube-apiserver-operator/commit/0b6040beb51aaf239e28f2a07f64c8d1c41a95fc -> https://github.com/openshift/cluster-kube-apiserver-operator/commit/0412fb31e03c5c278d1ba90a267507392c9a1fc8 to sit in parallel with https://github.com/openshift/cluster-kube-apiserver-operator/pull/1565 instead of on top of it. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 1 year ago

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-22718. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1572): >This is an automated cherry-pick of #1566 > >/assign sdodson Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.