search

openshift / cluster-kube-apiserver-operator

The kube-apiserver operator installs and maintains the kube-apiserver on a cluster
Apache License 2.0
74 stars 159 forks source link

OCPBUGS-22969: Use v1 for flowcontrol API #1577

Closed tkashem closed 7 months ago

openshift-ci-robot commented 1 year ago

@tkashem: This pull request references Jira Issue OCPBUGS-22969, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.15.0) matches configured target version for branch (4.15.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @wangke19

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1577): > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
tkashem commented 1 year ago

(it will perma fail until the 1.29 rebase lands, since flowcontrol v1 has been introduced in 1.29) /hold

openshift-bot commented 9 months ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

tkashem commented 9 months ago

/hold cancel /retest

openshift-bot commented 8 months ago

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

tkashem commented 8 months ago

/retest-required

tkashem commented 8 months ago

/remove-lifecycle rotten

p0lyn0mial commented 8 months ago

/lgtm

openshift-ci[bot] commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: p0lyn0mial, tkashem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-kube-apiserver-operator/blob/master/OWNERS)~~ [p0lyn0mial,tkashem] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 8 months ago

/retest-required

Remaining retests: 0 against base HEAD e6cba0a210714e935ac20c95873cc63e1175bb43 and 2 for PR HEAD 6f7f6453494e8a3b6034bba02c479228c682d0bf in total

openshift-ci-robot commented 7 months ago

/retest-required

Remaining retests: 0 against base HEAD 7ae98754c33c0d61e858385f647edb5c195305ec and 1 for PR HEAD 6f7f6453494e8a3b6034bba02c479228c682d0bf in total

openshift-ci[bot] commented 7 months ago

@tkashem: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-operator-single-node 6f7f6453494e8a3b6034bba02c479228c682d0bf link false /test e2e-gcp-operator-single-node
ci/prow/e2e-aws-operator-disruptive-single-node 6f7f6453494e8a3b6034bba02c479228c682d0bf link false /test e2e-aws-operator-disruptive-single-node
ci/prow/e2e-aws-ovn-single-node 6f7f6453494e8a3b6034bba02c479228c682d0bf link false /test e2e-aws-ovn-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 7 months ago

/retest-required

Remaining retests: 0 against base HEAD 75997469bf86c912869e11065b675095c78125b3 and 0 for PR HEAD 6f7f6453494e8a3b6034bba02c479228c682d0bf in total

openshift-ci-robot commented 7 months ago

@tkashem: Jira Issue OCPBUGS-22969: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-22969 has not been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1577): > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-kube-apiserver-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 7 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-kube-apiserver-operator-container-v4.16.0-202404042110.p0.gb16e36c.assembly.stream.el9 for distgit ose-cluster-kube-apiserver-operator. All builds following this will include this PR.

openshift-merge-robot commented 7 months ago

Fix included in accepted release 4.16.0-0.nightly-2024-04-18-141003