search

openshift / cluster-kube-apiserver-operator

The kube-apiserver operator installs and maintains the kube-apiserver on a cluster
Apache License 2.0
74 stars 159 forks source link

OBSDA-553: add provider name to cluster_infrastructure_provider when external platform #1638

Closed rccrdpccl closed 9 months ago

rccrdpccl commented 9 months ago

This will help track installations for third party platform (such as OCI) integrating through external platform

openshift-ci-robot commented 9 months ago

@rccrdpccl: This pull request references OBSDA-553 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the feature to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1638): >This will help track installations for third party platform (such as OCI) integrating through external platform Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-kube-apiserver-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
rccrdpccl commented 9 months ago

/cc @adriengentil

rccrdpccl commented 9 months ago

/hold

rccrdpccl commented 9 months ago

Couldn't really avoid adding another label as it would break compatibility

rccrdpccl commented 9 months ago

/retest

rccrdpccl commented 9 months ago

/retest

rccrdpccl commented 9 months ago

/retest

rccrdpccl commented 9 months ago

/unhold

openshift-ci[bot] commented 9 months ago

@rccrdpccl: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-operator-single-node 2fc368138651c0aaefc508cc220c68f28f5684de link false /test e2e-gcp-operator-single-node
ci/prow/e2e-aws-operator-disruptive-single-node 2fc368138651c0aaefc508cc220c68f28f5684de link false /test e2e-aws-operator-disruptive-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci[bot] commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rccrdpccl, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-kube-apiserver-operator/blob/master/OWNERS)~~ [vrutkovs] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
rccrdpccl commented 9 months ago

/cherry-pick release-4.15

rccrdpccl commented 9 months ago

/cherry-pick release-4.16

rccrdpccl commented 9 months ago

/cherry-pick release-4.17

openshift-cherrypick-robot commented 9 months ago

@rccrdpccl: new pull request created: #1639

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1638#issuecomment-1935787292): >/cherry-pick release-4.15 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-cherrypick-robot commented 9 months ago

@rccrdpccl: new pull request created: #1640

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1638#issuecomment-1935787506): >/cherry-pick release-4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-cherrypick-robot commented 9 months ago

@rccrdpccl: new pull request created: #1641

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1638#issuecomment-1935787646): >/cherry-pick release-4.17 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
rccrdpccl commented 8 months ago

/cherry-pick release-4.14

openshift-cherrypick-robot commented 8 months ago

@rccrdpccl: new pull request created: #1657

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1638#issuecomment-2015182970): >/cherry-pick release-4.14 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.