search

openshift / cluster-kube-apiserver-operator

The kube-apiserver operator installs and maintains the kube-apiserver on a cluster
Apache License 2.0
74 stars 159 forks source link

[release-4.14] OCPBUGS-29722: webhookcontroller: report when a webhook resource is missing a caBundle provided by the service-ca-operator #1646

Closed openshift-cherrypick-robot closed 8 months ago

openshift-cherrypick-robot commented 9 months ago

This is an automated cherry-pick of #1587

/assign wangke19

openshift-ci-robot commented 9 months ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-24005 has been cloned as Jira Issue OCPBUGS-29722. Will retitle bug to link to clone. /retitle [release-4.14] OCPBUGS-29722: webhookcontroller: report when a webhook resource is missing a caBundle provided by the service-ca-operator

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1646): >This is an automated cherry-pick of #1587 > >/assign wangke19 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-kube-apiserver-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 9 months ago

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-29722, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1646): >This is an automated cherry-pick of #1587 > >/assign wangke19 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-kube-apiserver-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
wangke19 commented 9 months ago

Jira issue https://issues.redhat.com/browse/OCPQE-19214 requires this fix

wangke19 commented 9 months ago

/retest

wangke19 commented 9 months ago

/test images

wangke19 commented 9 months ago

/test e2e-azure-ovn

wangke19 commented 9 months ago

/test e2e-gcp-operator-single-node

wangke19 commented 9 months ago

/test e2e-aws-ovn-upgrade

wangke19 commented 9 months ago

/test e2e-aws-operator-disruptive-single-node

openshift-ci[bot] commented 9 months ago

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-operator-disruptive-single-node 6f8bc840ace469d40eb4eaf97790d55fbfacbce9 link false /test e2e-aws-operator-disruptive-single-node
ci/prow/e2e-gcp-operator-single-node 6f8bc840ace469d40eb4eaf97790d55fbfacbce9 link false /test e2e-gcp-operator-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
wangke19 commented 9 months ago

/assign @p0lyn0mial

wangke19 commented 9 months ago

/lgtm

wangke19 commented 9 months ago

@p0lyn0mial Please help review the pr when you are free. It is required by one Jira issue https://issues.redhat.com/browse/OCPQE-19214. Thanks.

wangke19 commented 9 months ago

/jira refresh

openshift-ci-robot commented 9 months ago

@wangke19: This pull request references Jira Issue OCPBUGS-29722, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1646#issuecomment-1956064097): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-kube-apiserver-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
wangke19 commented 9 months ago

/jira refresh

openshift-ci-robot commented 9 months ago

@wangke19: This pull request references Jira Issue OCPBUGS-29722, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1646#issuecomment-1956065926): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-kube-apiserver-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
wangke19 commented 9 months ago

/jira refresh

openshift-ci-robot commented 9 months ago

@wangke19: This pull request references Jira Issue OCPBUGS-29722, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.14.z) matches configured target version for branch (4.14.z) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST) * dependent bug [Jira Issue OCPBUGS-27491](https://issues.redhat.com//browse/OCPBUGS-27491) is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-27491](https://issues.redhat.com//browse/OCPBUGS-27491) targets the "4.15.0" version, which is one of the valid target versions: 4.15.0 * bug has dependents

Requesting review from QA contact: /cc @wangke19

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1646#issuecomment-1956075653): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-kube-apiserver-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
wangke19 commented 9 months ago

Pre-merge verified the associated bug, got the expected results. Detail see https://issues.redhat.com/browse/OCPBUGS-29722?focusedId=24205553&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-24205553, /label qe-approved

openshift-ci[bot] commented 9 months ago

@wangke19: The label(s) /label qe-approved. cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1646#issuecomment-1956383927): >Pre-merge verified the associated bug, got the expected results. Detail see https://issues.redhat.com/browse/OCPBUGS-29722?focusedId=24205553&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-24205553, >/label qe-approved. > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
wangke19 commented 9 months ago

/label qe-approved

openshift-ci-robot commented 9 months ago

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-29722, which is valid.

6 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.14.z) matches configured target version for branch (4.14.z) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST) * dependent bug [Jira Issue OCPBUGS-27491](https://issues.redhat.com//browse/OCPBUGS-27491) is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-27491](https://issues.redhat.com//browse/OCPBUGS-27491) targets the "4.15.0" version, which is one of the valid target versions: 4.15.0 * bug has dependents

Requesting review from QA contact: /cc @wangke19

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1646): >This is an automated cherry-pick of #1587 > >/assign wangke19 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-kube-apiserver-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
p0lyn0mial commented 9 months ago

/approve

openshift-ci[bot] commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, p0lyn0mial, wangke19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-kube-apiserver-operator/blob/release-4.14/OWNERS)~~ [p0lyn0mial] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
p0lyn0mial commented 9 months ago

feel free to also backport https://github.com/openshift/cluster-kube-apiserver-operator/pull/1647 (once merges)

wangke19 commented 9 months ago

Wait until this pr 1647 is merged before back-porting to 4.14

wangke19 commented 9 months ago

/hold

wangke19 commented 8 months ago

/unhold

wangke19 commented 8 months ago

https://github.com/openshift/cluster-kube-apiserver-operator/pull/1647 has not been merged. /hold

wangke19 commented 8 months ago

https://github.com/openshift/cluster-kube-apiserver-operator/pull/1647 has been merged. /unhold

wangke19 commented 8 months ago

/label cherry-pick-approved

tkashem commented 8 months ago

/label backport-risk-assessed

openshift-ci-robot commented 8 months ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-29722: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-29722 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1646): >This is an automated cherry-pick of #1587 > >/assign wangke19 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-kube-apiserver-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
p0lyn0mial commented 8 months ago

Wait until this pr https://github.com/openshift/cluster-kube-apiserver-operator/pull/1647 is merged before back-porting to 4.14

opened https://github.com/openshift/cluster-kube-apiserver-operator/pull/1650

openshift-bot commented 8 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-kube-apiserver-operator-container-v4.14.0-202403051609.p0.g9aae543.assembly.stream.el8 for distgit ose-cluster-kube-apiserver-operator. All builds following this will include this PR.

openshift-merge-robot commented 8 months ago

Fix included in accepted release 4.14.0-0.nightly-2024-03-06-185545