search

openshift / cluster-kube-apiserver-operator

The kube-apiserver operator installs and maintains the kube-apiserver on a cluster
Apache License 2.0
74 stars 159 forks source link

WRKLDS-1015: tolerate node-role.kubernetes.io/control-plane:NoExecute #1664

Closed knelasevero closed 7 months ago

knelasevero commented 7 months ago

Required to be able to advise customers to follow workflow described in https://github.com/openshift/enhancements/pull/1583. If they want to taint control-plane nodes to avoid any other thing to run there (while enforcing it further with validating admission policies), control plane workloads need to tolerate that taint.

knelasevero commented 7 months ago

The actual operand doesn't need it as it is static pod and it has Operator:Exists Toleration

openshift-ci-robot commented 7 months ago

@knelasevero: This pull request references WRKLDS-1015 which is a valid jira issue.

In response to [this](https://github.com/openshift/cluster-kube-apiserver-operator/pull/1664): >Required to be able to advise customers to follow workflow described in https://github.com/openshift/enhancements/pull/1583. If they want to taint control-plane nodes to avoid any other thing to run there (while enforcing it further with validating admission policies), control plane workloads need to tolerate that taint. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-kube-apiserver-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
knelasevero commented 7 months ago

/retest

knelasevero commented 7 months ago

/retest

openshift-ci[bot] commented 7 months ago

@knelasevero: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-operator-single-node a448c4c6820f42742ef6fc67a293707e739dfe94 link false /test e2e-gcp-operator-single-node
ci/prow/e2e-aws-operator-disruptive-single-node a448c4c6820f42742ef6fc67a293707e739dfe94 link false /test e2e-aws-operator-disruptive-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
knelasevero commented 7 months ago

/retest-required

ingvagabund commented 7 months ago

/lgtm

p0lyn0mial commented 7 months ago

have you forgot to apply the toleration to kube-apiserver's manifest ?

knelasevero commented 7 months ago

have you forgot to apply the toleration to kube-apiserver's manifest ?

https://github.com/openshift/cluster-kube-apiserver-operator/blob/b16e36ca91558fb1f562ebf15d4d4ee3760ef6f6/bindata/assets/kube-apiserver/pod.yaml#L269

Core static pods already tolerate every taint.

https://kubernetes.io/docs/concepts/scheduling-eviction/taint-and-toleration/: An empty key with operator Exists matches all keys, values and effects which means this will tolerate everything.

p0lyn0mial commented 7 months ago

have you forgot to apply the toleration to kube-apiserver's manifest ?

@ingvagabund pointed me to https://github.com/openshift/cluster-kube-apiserver-operator/blob/master/bindata/assets/kube-apiserver/pod.yaml#L268-L269 which means that kas tolerates all taints.

/lgtm /approve

openshift-ci[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund, knelasevero, p0lyn0mial

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-kube-apiserver-operator/blob/master/OWNERS)~~ [p0lyn0mial] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-bot commented 7 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-kube-apiserver-operator-container-v4.16.0-202404221110.p0.g65eb450.assembly.stream.el9 for distgit ose-cluster-kube-apiserver-operator. All builds following this will include this PR.